From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89ECBC27C55 for ; Mon, 10 Jun 2024 19:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F04B6B00A2; Mon, 10 Jun 2024 15:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A18A6B00A3; Mon, 10 Jun 2024 15:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01A986B00A4; Mon, 10 Jun 2024 15:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5B9A6B00A2 for ; Mon, 10 Jun 2024 15:21:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 85124140F14 for ; Mon, 10 Jun 2024 19:21:46 +0000 (UTC) X-FDA: 82215948612.17.699589B Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf28.hostedemail.com (Postfix) with ESMTP id A167EC000B for ; Mon, 10 Jun 2024 19:21:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=2Y4kKBN4; dmarc=none; spf=pass (imf28.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.52 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718047304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=jjChYwH57ZvCkugsxXIRMqAnuhL1Y2EzreTb3w0k6jPwBBzaIU1W/IR3QPO6DH9GoZJB4r gahk7tU4UZhLf+b0dJrfyji1S3e7fXwAoHXkiwzUDqa44y+kz7CXbzexZ96/yGDCa/imb9 c6mAUw6QtgWI6ZpjyAQ9cR13aeF/jig= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=2Y4kKBN4; dmarc=none; spf=pass (imf28.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.52 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718047304; a=rsa-sha256; cv=none; b=X0kRFAn+1hPBd8h6t2yAdRHoR6la9+GbZvN9TkJ7SKpathFhnZHx6tzYK5Fq7V+Dj2aUdu TgQzNFThQz8bvhfFTasixqtNnmNOtU950Y4CAsfBQRUCDh5JGyuzxT2oEe13EzQXDwWzLf Q8jeHldmdAAKUtPB8d6/vBoHUW4Mj/4= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4217926991fso23443265e9.3 for ; Mon, 10 Jun 2024 12:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1718047303; x=1718652103; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=2Y4kKBN40Bi2A52B+ElE4/bpRerXCuvR7hCwpsCx/Tsw2JhxojsTB3uTSPn21UTjlm Nq//K9C0IPklCYhkQYBTUxhhsh4e7E4Osw/pWtbO9ziWBOK48MvmGdMKF0m0NVTl57tn Zx1dKQwSyXPuohtcEP6QJv/o2lbDlNyQGPQZD+2G3P/kI8itoB1r6aBbSXhFRDwPYWEH P+PijtA/UnhWBZF5dJl8DQnTOqg2DAhAdw1QKaUWbUT4GxepK8u7Fa0eQ15vsoxY8I1W 9+3l/BGbDW4tUPFsjhh7xIyvVYqJ+GJDikEjUeOMkrSVt2TFXDBPmPMpu81c40I7cTTH 020g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718047303; x=1718652103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=wGThlK+jOT1uyA+ZtSyjWUHMuJyFVHCCihXSpajTLFSyagsrwfMEh8IQWtvZyjwtXL w0BINSr1YjTBRy1LrEiUPPi4cYyJPb+4mke0CTQBaRa0CETRlyrtYBcDEaAYMs6sy5IY JyQ9mk+KrVqn6pzzUMwk/6CdIcwPJuETRWewwJylA18//36h3uu1j40J/XuX4SboQKGY Jughgnc+Vco2nAoHl8MBWSiGlzA9q/ds99VDR6VPj2/lJAMmZK1zJy/A40LYbF2wG36G tU+lPMDxiZANmNalzvi4WoVgCDwyh8PsGukOVsZ3f1kJ1w5Q4j2cSr93ThZ9iCArIZq4 mVlQ== X-Forwarded-Encrypted: i=1; AJvYcCWomfFqx/32ajuBbK3aXsL13btepGi7m0dP94KregvBJPYRGRRctknV3a+byfLfwtURCyJbE5mXV8VW+XcyNsk7Bs4= X-Gm-Message-State: AOJu0YwoHL8lkVwOWAeAlyHH/FrDWZX0vD2UVVe0LJVkRORyzPcIwiwh Nw+1jII1v1/YUsbJRZys/ImAG6OnFqL5FDCrVtORbCWs9lqM9CisS3VPLL5ZqH8nJ2NOSiPzkgk YhLA= X-Google-Smtp-Source: AGHT+IG5R+6QdrL5vtPI3P3UQJ+Eps+bOHM+4T1uVpoya5SI1oL4hgnotnXL1Fs02cAYdrCTAMaMxg== X-Received: by 2002:a05:600c:138e:b0:421:2df2:2850 with SMTP id 5b1f17b1804b1-42164a21d60mr105810015e9.31.1718047303182; Mon, 10 Jun 2024 12:21:43 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4218193b0c0sm65469985e9.31.2024.06.10.12.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:21:42 -0700 (PDT) Date: Mon, 10 Jun 2024 20:21:41 +0100 From: Qais Yousef To: Daniel Bristot de Oliveira Cc: Sebastian Andrzej Siewior , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240610192141.dibvhzrvx7hacvd7@airbuntu> References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> <20240605132454.cjo4sjtybaeyeuze@airbuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A167EC000B X-Stat-Signature: dpg1e77jbzpszr37y38j7w917mgi35es X-Rspam-User: X-HE-Tag: 1718047304-68351 X-HE-Meta: U2FsdGVkX18OedoJlDcDRXwO+Mpr6fU0TyGQW9cJE7ZSkT0f+PchMQ8XuCXATM2Vw3bMhLlcuMP68/fAW5Hsm4f0ysq+wi168rLeN3q/yiXsI10bbJn3+1HaBo8SvSz620KLdBO2a34Xk5cQlgkY6NfXje4R5U5FNeEvDXBWCkGAbSsjeyHMOXKwEqiusKWww0Bg70plLzDo8jSuCVWYpIyjpKvcfjH1f6sB1Ut11mCtIF3QUnoIR4T768VtvZpoyCcSOpUntNgM+jnrJ5s4Jj4V+NBAMMxda9WslINNTY2QsnmjeZqCJ0cvU4AnhXG2pX7oj4CAuBGPjt2cvjsh0WhLHUoS3Ju+w3XAU0DW6KjGL82M+XIF9rzNpO4W0g56bQutMFdoK+FLtlnEfmfXbLbkNJAGW7/ocLEVri5EA+5tTRZx6xY5jyVsOrFLa0KleNgPlBUo6uO1bbvehXVIbR3U9sBWyuIUGYaKFA2l7D2zBanE7a8g0PxNxAQ8d5k+1BAZk5AfdvJhmFchWcDfhx94V2m7kaiLDTGC6K2a/Ap46C8+qROB7CfqP2SPOiMYg9A1yQDlImgCjQKoxYUkYJu30vtFownVeylIvo/DGnAwHeH0pNyHXbWe4eLbyMWmi+COEyguw+E3Pn9MsQ1zQGOYt5m2godT3npqzAubq3KGh1EzFsiVjKof208TnNeujFmlBpjT5yQjd+ihQ+9OQ8Nc/P6AV6R4ivZ9YVL1haAQOj4M1j6R/7ff88A+L6uaoGFgWfuXMEMpHH/j2J1aZNbYWRog5GrF7VUkzaDpyihReLL1bL/FV9efjdXcO/pNvyoQjtjWZ05m4+je5GRwUjOhGa8ZZIHiQC7Qx83XbTUY70R2tkIxhGalyUosVS6YwQLSbbsqm/jKY0xd2+YUIavO0XeXNKFVmNSVt4xOzbANQFrldq8N7cmbzFdEIMKQUvuy5e1zNNk0VDNzLav dKyOLND/ Utmt6MvQSISxpacCgxrKk4VC2BIr9HBSdWorkISY6OaNbP0nwgd4XpfrNUzKwfcXJwwHQWk2ToPA8lYpxASw0f4TDfkeCtKGp9xVDpCgwyMyrqElKNui0Gpf/MmbWSlDrXQ58M5xnUa7UxsdjQFG1VdwRpy0Yblr/EMx1qSrs7YQfpM7Tf7Hdh93Y6leoJtInS9PDFD07XnobK8oOShXyNVANVsfH2NkT1Se8L/ZC/GxYkdf19EAH6kDHM/804aCNIG1pcpi5vLv3pXixzuwxM0sy6xGvyf5x/00a6nLbZAtaSA510yW5fGZ6dGO0NSJFUnPA4UbKOKqCy8SrDpJ2RehpKV7vDBiSSYYi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000085, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/05/24 16:07, Daniel Bristot de Oliveira wrote: > On 6/5/24 15:24, Qais Yousef wrote: > >>> But rt is a shortened version of realtime, and so it is making *it less* > >>> clear that we also have DL here. > >> Can SCHED_DL be considered a real-time scheduling class as in opposite > >> to SCHED_BATCH for instance? Due to its requirements it fits for a real > >> time scheduling class, right? > >> And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. > > Yeah I think the usage of realtime to cover both makes sense. I followed your > > precedence with task_is_realtime(). > > > > Anyway. If people really find this confusing, what would make sense is to split > > them and ask users to call rt_task() and dl_task() explicitly without this > > wrapper. I personally like it better with the wrapper. But happy to follow the > > crowd. > > For me, doing dl_ things it is better to keep them separate, so I can > easily search for dl_ specific checks. > > rt_or_dl_task(p); I posted a new version with this suggestion as the top patch so that it can be shredded more :-) Thanks for having a look. Cheers -- Qais Yousef