From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Jeff Xu <jeffxu@chromium.org>, Shuah Khan <shuah@kernel.org>
Cc: Andrei Vagin <avagin@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <david@redhat.com>, Kees Cook <kees@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Peter Xu <peterx@redhat.com>, Rich Felker <dalias@libc.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 1/5] selftests/mm: mseal, self_elf: fix missing __NR_mseal
Date: Fri, 7 Jun 2024 19:10:19 -0700 [thread overview]
Message-ID: <20240608021023.176027-2-jhubbard@nvidia.com> (raw)
In-Reply-To: <20240608021023.176027-1-jhubbard@nvidia.com>
The selftests/mm build isn't exactly "broken", according to the current
documentation, which still claims that one must run "make headers",
before building the kselftests. However, according to the new plan to
get rid of that requirement [1], they are future-broken: attempting to
build selftests/mm *without* first running "make headers" will fail due
to not finding __NR_mseal.
Therefore, add __NR_mseal, to a new mseal_helpers.h file. That file is
small right now, but subsequent patches will add a lot more content to
it.
[1] commit e076eaca5906 ("selftests: break the dependency upon local
header files")
Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing")
Cc: Jeff Xu <jeffxu@chromium.org>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
tools/testing/selftests/mm/mseal_helpers.h | 5 +++++
tools/testing/selftests/mm/mseal_test.c | 1 +
tools/testing/selftests/mm/seal_elf.c | 1 +
3 files changed, 7 insertions(+)
create mode 100644 tools/testing/selftests/mm/mseal_helpers.h
diff --git a/tools/testing/selftests/mm/mseal_helpers.h b/tools/testing/selftests/mm/mseal_helpers.h
new file mode 100644
index 000000000000..b922d453a014
--- /dev/null
+++ b/tools/testing/selftests/mm/mseal_helpers.h
@@ -0,0 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __NR_mseal
+#define __NR_mseal 462
+#endif
diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index 41998cf1dcf5..20949617a036 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -17,6 +17,7 @@
#include <sys/ioctl.h>
#include <sys/vfs.h>
#include <sys/stat.h>
+#include "mseal_helpers.h"
/*
* need those definition for manually build using gcc.
diff --git a/tools/testing/selftests/mm/seal_elf.c b/tools/testing/selftests/mm/seal_elf.c
index f2babec79bb6..4053951a535c 100644
--- a/tools/testing/selftests/mm/seal_elf.c
+++ b/tools/testing/selftests/mm/seal_elf.c
@@ -16,6 +16,7 @@
#include <sys/ioctl.h>
#include <sys/vfs.h>
#include <sys/stat.h>
+#include "mseal_helpers.h"
/*
* need those definition for manually build using gcc.
--
2.45.2
next prev parent reply other threads:[~2024-06-08 2:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 2:10 [PATCH 0/5] cleanups, fixes, and progress towards avoiding "make headers" John Hubbard
2024-06-08 2:10 ` John Hubbard [this message]
2024-06-11 4:26 ` [PATCH 1/5] selftests/mm: mseal, self_elf: fix missing __NR_mseal Jeff Xu
2024-06-08 2:10 ` [PATCH 2/5] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h John Hubbard
2024-06-08 2:10 ` [PATCH 3/5] mm/selftests: kvm, mdwe fixes to avoid requiring "make headers" John Hubbard
2024-06-08 2:15 ` John Hubbard
2024-06-08 2:10 ` [PATCH 4/5] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items John Hubbard
2024-06-11 4:26 ` Jeff Xu
2024-06-08 2:10 ` [PATCH 5/5] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS John Hubbard
2024-06-11 4:27 ` Jeff Xu
2024-06-11 4:34 ` John Hubbard
2024-06-11 4:21 ` [PATCH 0/5] cleanups, fixes, and progress towards avoiding "make headers" Jeff Xu
2024-06-11 4:33 ` John Hubbard
2024-06-11 4:45 ` Jeff Xu
2024-06-11 6:25 ` John Hubbard
2024-06-11 9:31 ` David Hildenbrand
2024-06-11 14:13 ` Jeff Xu
2024-06-11 9:36 ` David Hildenbrand
2024-06-11 20:54 ` John Hubbard
2024-06-12 8:24 ` David Hildenbrand
2024-06-13 2:11 ` John Hubbard
2024-06-13 21:27 ` John Hubbard
2024-06-14 11:42 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608021023.176027-2-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=axelrasmussen@google.com \
--cc=brauner@kernel.org \
--cc=dalias@libc.org \
--cc=david@redhat.com \
--cc=jeffxu@chromium.org \
--cc=kees@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox