From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8915C27C53 for ; Sat, 8 Jun 2024 00:51:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4351B6B009C; Fri, 7 Jun 2024 20:51:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E39B6B009D; Fri, 7 Jun 2024 20:51:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285486B009E; Fri, 7 Jun 2024 20:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B0086B009C for ; Fri, 7 Jun 2024 20:51:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AE073A396E for ; Sat, 8 Jun 2024 00:51:48 +0000 (UTC) X-FDA: 82205893896.06.B576C4A Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf02.hostedemail.com (Postfix) with ESMTP id B85AB80004 for ; Sat, 8 Jun 2024 00:51:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hR+wXIUF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717807906; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GKmEYYbLN6RZt0gVgrc1uNmBvZwEN49C/Juti4dcLvY=; b=xqNrTb4Hb8IST75Qj1/RyIQmSxLMmx17z0KXFyvtXFXl/Yj6gkU3onA9dWj2fdm3+7evBr VgykexuHq28MkJucZ2XhEcYOwxZ1dszNXf3OLY6CEXc4ErvpI7I/P/PMn6MPsSwAjVKm0c FhQCtPwkCoieXkq4XsTqKsh6ay4jzXg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hR+wXIUF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717807906; a=rsa-sha256; cv=none; b=lgRHo3XNOdcoErHfhQFO4BfZRo43aWNcGdzll2P4b+v0TGcwZOV/TyXSCkE+yggPPvJu5j p+I+31gldMGuxDOSFxRRatvZ0XN/iCZ9x+3vRD2X8ijxhnqSCNSZmsLrfrle0cvK19KWxT nmPe+Lv2xGg0x3uCtFYjW1V7ztH3EqA= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-57a50ac2ca1so3414868a12.0 for ; Fri, 07 Jun 2024 17:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717807905; x=1718412705; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GKmEYYbLN6RZt0gVgrc1uNmBvZwEN49C/Juti4dcLvY=; b=hR+wXIUFhh0z/qS3DTcvlPtpZtKZgRTs4ATngT/hm1kwby7yQmiGV0ft+xmsmz8x/Y uSIERljNhCxlXKarF/CrXbEEzsM8PJ6eyT6ixZXrUz1PLPyrXpPtJtdCCgju37t2p1BN g5zadLF7ACdby00QpzxgHBfnvp/CPptGKo7SMB3Yg7rk2BOxc5J3RuTFeo2MmiTwXUWk 7DtclIyw2w6+71ftQS9MX4Cqu45ihS96kCXfT6KuvplTymapYPr4MslnvBCGzFMGKvUU aVJ/wuV34mXJ/X6F5+uERhZACwQJ9yO9xJwSipO+SkpKem/2lpr7WXU0fQBGX2QpH+T0 SEZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717807905; x=1718412705; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GKmEYYbLN6RZt0gVgrc1uNmBvZwEN49C/Juti4dcLvY=; b=Yn0TMXF7yxrXlE0+pF1yo1/A7kmHMZacq8u8euyOGYoKpQwo+F0pJ68gkxBMsKC6/O 6lLGJpPTqvoz/SWv+kt2NlzRV4m0mvvAxzY6rnu4xTdBtPGCYwjm7Hn7+D1fLDoi16og aFT6oRKAPgMKkmGJnVLYdWYY0ajA0HmY+5s/Ntk/OxM0Nd8/AhVwup3jvX5TWFuDfk5i 2ZNZqUVetyvFLW7/ISsY1AEQMUjotB7kdTW5x8FOQPy9L0wDBfvMw4ZlEyiJDEBgyIZL NgCLryDVtC5uB7YllkG7pNYP4QEyesu8GoVINWCPyFTO+F1RMrO/iaKr9z3eykN6oXAh 5YKA== X-Forwarded-Encrypted: i=1; AJvYcCWSj22b6/NFmrnCRMSD17Tw138mUw6E/M94hfzZmqPVElPjsQOZtQ1OIjHj5GJrQk01AkT2CHVbaFmuLjiR4g5vAag= X-Gm-Message-State: AOJu0YxTMaTnOtKnK8GOPfYNDZ8+P52a2NanVDIChwqS2gdDwemjhP4N 9WjFF53u6Zt1Hyd5mt8JkEo3z3FyOIWtU1WI6HFgv3r2OZRVlQuH X-Google-Smtp-Source: AGHT+IFFEYhn95X5wlp0yvy/g7BNLOY7hnRErafTSEW36dxiClkkU80brBOdzArkxY2Ye0XwiTQFZw== X-Received: by 2002:a17:906:3610:b0:a69:7d72:b0d6 with SMTP id a640c23a62f3a-a6cdbef7773mr244615066b.71.1717807905171; Fri, 07 Jun 2024 17:51:45 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c805ccb1csm317710066b.80.2024.06.07.17.51.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2024 17:51:44 -0700 (PDT) Date: Sat, 8 Jun 2024 00:51:44 +0000 From: Wei Yang To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Wei Yang Subject: Re: [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long" Message-ID: <20240608005144.ypbq4442bh46tmqb@master> Reply-To: Wei Yang References: <20240607083711.62833-1-david@redhat.com> <20240607083711.62833-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607083711.62833-3-david@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: B85AB80004 X-Stat-Signature: uhbgz65xq3da7n5sk7xesn9quuq93qmw X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717807906-222658 X-HE-Meta: U2FsdGVkX1+Cw/x1U2rRXAI2J8mWmhPStOW3hHTppsY6jvYnOfMm8jEJDXAtnu5LAfQ5qKfxGmghywkuvZ4jlOXcVvLPGQ8IKciFiW3AgeAWPTReKF7D1dU+6FK3Z4G2nE1H87zVlSOB+E6xoRUqNpgc82qyPfSV2L2YjGmsr0PCyyGCZUAj4Cv6fQM9QeSqZUuccECzlHPMiyiK8o7iPUFLurcFLZY/Xtks4iF6CMhxA1fGlsgFTCCMnG9O+3YHuf83E+07hrUqrl+aOc1W0nuYazpW+e+IueV46qKwKDyyFTG5ZtgvFrMSIG0Cc+D8hmSlI+U31UxzD3LWVL48/eTuC8xojc3xTFA4x13CeAEpaPWEQJF0+ZWDePqCYhkzMkZo4F5QP4UMdLwhCuQBq6pGbQCVcFxRxMLvFTujQ0hSuI+9VVAxGn3e58f+6Dmw2HLG+jInx9CIDprVKeWGA5TsAiuCheAFHQfbLluuNNvWBzwiw2/UNx70yuOT0AWtrRq+hUKwBQWQxERiYoBQTxj8SMWWFAgQZiBI6d2LLaHEnVZIw5uVtPKmvWwRrsuhU6g0mh3eGECSBKjZG5ZA7mWAmDOZOLRxaFEUBpeKeX5uErKQsy7fuAe79cq9HsLvJu4ZVCZH4eLZEanI/bI0Iu1Kj+QwnLuxX/oB3nU0WQ3JX9ZYWmgmvCOVs2Ra7K85fArduNw9jQlFsHlWx4jIcYjjcZZzxC/s6IVDF/fkHdIavXe0mvLNfDeq7H1hFvtO2k6Qs1qO/15EX+bFzZThktdRvEjs4wdvhM2zWkXXHvc5m+DDgp2oA5TmQrZEO5GO5uM6GNc0dPzowFVCrMGrtERrxAGSSf7HJlnYXKcDh+NeENL5BlvjRt8BvhwjmU9QdyzvF8EXnhcsZmO8HNoltgs48VGDNaLGp+JAfenYJ1TWYEks7TLboisC9WGEOxsnds4FkDLFo4eKUnRb4og gIuVi+bo Hlja0ZE2k2CgKa9CzPrfdPEeLxXHC/hPiXGFocb7yPnMxJQtWs7VcRmRyyCCyG/dEuX+625af773OYipOeEOApqOwwwQxp/Ae8VF86TJR0lERoh/TkTkXufVS8jb10xKCXYUNUCDlegtmjpNcpj6g/96Pm05iz7/lHF4ZaZwt8PBjE0t5+YMImmUk2ANjBndpA1e13g8CCOapW9g4ki7jBH7j+fLYNALsEwuxKf4FwqWLfPiEeP33p7yOUcfwmK2UYr+5wbCoZHlbUrZCNovGga9LJ897jGIAKHJDoKZ+ancmEMvmmZ8O8EQpvyeK6s+3sq5CH+VphELOKk0WKLcsh6/aeyL5+JMD5Qtk012o7rrmT03eV67vOqdSZO/4fjAsVbNo52F84b4EIFz08eyR6RdWfxmFXv/VwDMMBkXHsea8GpUKf8Lgvs+RMYZEQcnuLe5yvZdmLFLIxUyJcKFeWB3zimHqZxFj9+bA3pm7obvvsEFt/FqoXeEVQgkaJjz0uIfpy9Q/4KULcJk+3MBCfA+G3a15XEmKj5sxrO8/as5OGkI93Esa8RghQDSklnaTl4aGFh4MNXIxsYH28pD5EqNwoGSGhJCIeBr8+Ya14z7GEYwQ4vOqwMDKOmAOlz9Yf1pEepOitvu4eeVLO6GnV+k9CIA76LQ+ucw3MPoV39P8foib6ta4wivF70LaQxeS1nRGARJpD8OSog8sJpf7shpQ2LXD+BvbChMQEugHuzUgYS3nHPFftRCVk/Hijy/R04Jck6TAMX24zcQfepi5n0Aq7fw2mxMkdytfWb0aSHffpBmo6ZPxJe1iRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 10:37:11AM +0200, David Hildenbrand wrote: >It looks rather weird that totalhigh_pages() returns an >"unsigned long" but nr_free_highpages() returns an "unsigned int". > >Let's return an "unsigned long" from nr_free_highpages() to be >consistent. > >While at it, use a plain "0" instead of a "0UL" in the !CONFIG_HIGHMEM >totalhigh_pages() implementation, to make these look alike as well. I am not sure why not use 0UL for both? > >Signed-off-by: David Hildenbrand >--- > include/linux/highmem-internal.h | 8 ++++---- > include/linux/highmem.h | 2 +- > mm/highmem.c | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/include/linux/highmem-internal.h b/include/linux/highmem-internal.h >index 65f865fbbac04..dd100e849f5e0 100644 >--- a/include/linux/highmem-internal.h >+++ b/include/linux/highmem-internal.h >@@ -131,10 +131,10 @@ static inline void __kunmap_atomic(const void *addr) > preempt_enable(); > } > >-unsigned int __nr_free_highpages(void); >+unsigned long __nr_free_highpages(void); > unsigned long __totalhigh_pages(void); > >-static inline unsigned int nr_free_highpages(void) >+static inline unsigned long nr_free_highpages(void) > { > return __nr_free_highpages(); > } >@@ -234,8 +234,8 @@ static inline void __kunmap_atomic(const void *addr) > preempt_enable(); > } > >-static inline unsigned int nr_free_highpages(void) { return 0; } >-static inline unsigned long totalhigh_pages(void) { return 0UL; } >+static inline unsigned long nr_free_highpages(void) { return 0; } >+static inline unsigned long totalhigh_pages(void) { return 0; } > > static inline bool is_kmap_addr(const void *x) > { >diff --git a/include/linux/highmem.h b/include/linux/highmem.h >index 6b0d6f3c8580c..930a591b9b616 100644 >--- a/include/linux/highmem.h >+++ b/include/linux/highmem.h >@@ -179,7 +179,7 @@ static inline void *kmap_local_folio(struct folio *folio, size_t offset); > static inline void *kmap_atomic(struct page *page); > > /* Highmem related interfaces for management code */ >-static inline unsigned int nr_free_highpages(void); >+static inline unsigned long nr_free_highpages(void); > static inline unsigned long totalhigh_pages(void); > > #ifndef ARCH_HAS_FLUSH_ANON_PAGE >diff --git a/mm/highmem.c b/mm/highmem.c >index 3c4e9f8c26dcd..1ece1e69031e7 100644 >--- a/mm/highmem.c >+++ b/mm/highmem.c >@@ -111,10 +111,10 @@ static inline wait_queue_head_t *get_pkmap_wait_queue_head(unsigned int color) > } > #endif > >-unsigned int __nr_free_highpages(void) >+unsigned long __nr_free_highpages(void) > { >+ unsigned long pages = 0; > struct zone *zone; >- unsigned int pages = 0; > > for_each_populated_zone(zone) { > if (is_highmem(zone)) >-- >2.45.1 -- Wei Yang Help you, Help me