From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F36C27C53 for ; Sat, 8 Jun 2024 00:35:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1556B0096; Fri, 7 Jun 2024 20:35:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252576B0098; Fri, 7 Jun 2024 20:35:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 119126B009A; Fri, 7 Jun 2024 20:35:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E7E8D6B0096 for ; Fri, 7 Jun 2024 20:35:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 884021218BE for ; Sat, 8 Jun 2024 00:35:40 +0000 (UTC) X-FDA: 82205853240.30.CAE80E1 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 8EA2014000B for ; Sat, 8 Jun 2024 00:35:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="foWB/C9S"; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717806938; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PwnY+afJtQRcurBWHlV8xjfZpI4xfm/VsTFnlFZn1u4=; b=7od+PaTgBQFpLsijcgTXTYDeK87edz3iTyOnYYuI75dSUr95YqTQQLz4XA5s+WcTcgL5lr AEMPLn33HVKIezo+m3tAs9TlGPKn2GmuiLxJgjwDMkYJMJLx+XUXeboC4cvxlcExWlH/o1 q+ubrr+Gfd8sxas+F8CLME60gCHX8iA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717806938; a=rsa-sha256; cv=none; b=eaHcE+r2H85ounr63VPSB2SwgsTK6Ice+cAs9BF4XDaaozbztoP9RDI/8L5iUPbJYiWVLt JkOmQORupqQUk3rTKR4cFmSbWYHJAqA2gFv+N1l1ifT8pvQL14YNLbWT8mlkHi+AHVjWU7 ohVPpBCuPAs/Y8bMpEjJugQv9LC7yqg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="foWB/C9S"; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ead2c6b50bso27100001fa.0 for ; Fri, 07 Jun 2024 17:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717806937; x=1718411737; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PwnY+afJtQRcurBWHlV8xjfZpI4xfm/VsTFnlFZn1u4=; b=foWB/C9S6tqpIan1AvPL305y4Yr+kDkeJUKDS2xq0vFmHzhwfhm81nNd2WBlA0j7/t ybz5nSYnrJiaJqIcYdpyNvRlLfqDxN9EYIjTxqr2aigxVrGfljgyUAnIQ2qP0mpJT+1K Xh2vZEit9PGqVRQr3PS4FbYSlVo4UffxBKY79kNbeMjDwUxSmOMiVq+RHK2Nez5Ll22i 2GN2G7QbCcfIYDALZEuYt/fVp3CfrJvqIWsEi6hLJ9FW9q/+PFH1+eCbjbPjCRN9tTWJ 6/+7I1Lks8oSHx3MCmzTc+gwlNdna1hrO1u7f5cL8z/0wV3AXncm77pIxHszqwAfVet3 m9YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717806937; x=1718411737; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PwnY+afJtQRcurBWHlV8xjfZpI4xfm/VsTFnlFZn1u4=; b=FvOsqqlWCTHEcYTIiQNxAfXDL0jt6e4bUlvolJGN7uwVkOu7Adg+tojXdSDZ5Zhxms 3iYQue22GGjDKCNl5pquVejbruWnf38kM73rKwL2456KIRl/PqtPqrg1AB0SwTpZwUQF T9dhEStz65yYwGAQBepgAAEwofeD3E6cCJ4rR6Y4Fcvq1ZYSgroi9uOkIz8xxnVsXIy7 RTIdjaGocMlaDrUa1/arfyddFanjj5nC+G1vqJ5HaOBtblxvlZFTW6U0HNscu9JOIn0A D6zPI+awHBQdFwO4OWtPYh5sn5CqEK/VIJF8xmmG5r9N2UG8Pj2hCtJmiV5xCl+lmyBy 76HQ== X-Forwarded-Encrypted: i=1; AJvYcCVLmAYUijaxw2HR1/vApydOuk64FyMm2uvSGr6Su3+vBwDixDB/PkuO9Wr50RXSmEYmtIXxJ0Mq1YivgULjpypTo6Q= X-Gm-Message-State: AOJu0YwtIcg6n72caPsvznRbuf2fGRQeVij0mioRAkswsCoU3exL/pnc uAccwsDuI69R1fzbYjw86iKI8ojMQjyZSdUw2BXr8vXR9nQOZ/56Esg2rzVn X-Google-Smtp-Source: AGHT+IGq2Tz3EhvXHorAeVRHt2WVvV1fDVMQQdeNMsd53WYIaAkOT3qKbjKDPHVvhgDxlOi6idF8+A== X-Received: by 2002:a2e:a589:0:b0:2e7:1bb6:2e8b with SMTP id 38308e7fff4ca-2eadce713c9mr27386591fa.35.1717806936504; Fri, 07 Jun 2024 17:35:36 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aae23405asm3517810a12.82.2024.06.07.17.35.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2024 17:35:35 -0700 (PDT) Date: Sat, 8 Jun 2024 00:35:35 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: don't initialize page->lru again Message-ID: <20240608003535.cxrupjomwaxh7zpi@master> Reply-To: Wei Yang References: <20240605221436.24627-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Stat-Signature: 4atc1g79wx7wq1z3z8m16npqkggmu84r X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8EA2014000B X-HE-Tag: 1717806938-460748 X-HE-Meta: U2FsdGVkX1/BDDMol3zLP2lVlCIhKBiYGXFmgPbYvtQiMoFhCqnDFn3NTku6aQQBj2ZRdA+ztospECV43rMI9H2CAgbbyt6PO5GwLa4qoq3UvSOmF8kS+R0PRlOqL7IPwOhJgZXwIf+RQHp4FZmljcSA1h02c8QexKb7sBkgQW4aPwuRVsJ9j5szH9IklFyhjhkUk1vLZWVOJV3g3DB+F57AlOyONAHlT++2Q7H6VaFxDnqmE2LhxEvqOs4/D8yXH3aGr3Y9t/Ybd0RzYPD7wahAjZDNJGa+nAQvJHpu2US4eps/SWof0UtvL86bGIAa9Vk/OjnWQGMQFkH2yJbsn6MgEJIeDibmTIAM3kZnC1cyKOn2OGCWemC8bmrQcH6g93IjAlpELbQYy01q0DWTyC5HGfmuf3Zb98wDB/CTSdMFAu3jVFRw52+BJe0Y7VSzMH4OZcVgarwHxY/KVHn7xPgSmoQ3kk7k7F9XEeuUoR+VPZ5oqsH8wej75yYbEkJJ2SxhgG7YjiBOVIYdM3DUF5VTvKISc424liLjFt4cdqC/t/1ptJ8h7tVL/NC0Jb+bOOqVa2cTgtY8nUNaGz6825pwiUjI8bQDWGz8At0FkMcks7YDKGE0cp1SakX/AdVCRl8iL2FgkRZ+/oYKnp0AqGMc/wr0MOZrtGfa3yTuHqnqHNoubtJVauB44fP1f4qFz4KkguHL+hdSNMYiGxsrZDcwpf665EMl4DGz57lB6JOBijwU0XXhs71/fi1c5AyELbEfWgWKTYO+TR9SyyNhb6UlwatXgobM9zCJWtE1ZyP40827oSECnR9PhiKPVXGFftcEWgGZZAKxx19LwmqjaUSh1qmienYAnm7hRkRYiVxVCXmtkgLr7VRF7oLcKBVCjLrkBG212dr5VaW/NKDv+O5pLchX667gTRbavQUtb9sRm0grD0/85xb2ueWBv+VcaHJTpRMS+9kY1q1767R 9u8GUC2Z lK6AGvkN4SjMC260jHoaLdH2Sde+4qvsv0dIO0lSwoG5gJZnGa0U3rFpCJp4XLWnhU5TZtEJZ8PVGGPCmxEyDCNK37McStpvCNdfnuqkyT3TeLzTu16k4jW2bNzguBr88xyvoC8IVd5Z+JD+Cu/qJCTIK5MBaM+leedbv5+y7Aqgs30xMDex1x0DFtjJoiHNQQLzPnTWagqwKz75RtaryTHnQ9W6YgzZ1AnQAgC5DKCEKbR/O28cjl/iXP/n8CRansrWTWcDq0T2lvBPm6aedeQglVOEtvyfShvUn88W2MZCFy1g6339V//9YP4rRqOj/jFbI1mv2CYoQwlVPeDkWu+4mHb17WF8HVwm19zEn4oAWUaTRgFYln69L3+4xfMu6KaDPy0sFotpjiJ0Krjtu85FBYLTbzZJWyX/eDJBqI7qA+y4Ay9Y+FAaFApMcEfvhgilBht5JRcdfllAiZxWozCZV1JKDJkV7wAKktRfRwFjWmNp3dSP2BxMcO770v4MGRGqJFnHv6BpyzyJiHuL0RXytwQWVhScUvRBbqhneXcEdO9AS81ztoKbHQ4H/YlSw8HhCTyDeAecZiMuL+GwF7KxeWstPC9jPg0Fq18pxyLUV0hDc9ob+Czeb3eX1h6a7p05R4mkeI4j9jnRnQBwhvrXUxxrKUVXdt5WiB4LwgD+F41vg5p+6lyOnjRL9uDHhpiWUHTxVwqMhmgAMb1HhLtanLGN9avu/k1ZTwPoa/uy4a4ibEo1a3juTRQPb6upS8L76 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 10:33:41AM +0300, Mike Rapoport wrote: >On Wed, Jun 05, 2024 at 10:14:36PM +0000, Wei Yang wrote: >> After init_reserved_page(), we expect __init_single_page() has done its >> work to the page, which already initialize page->lru properly. > >init_reserved_page only available with CONFIG_DEFERRED_STRUCT_PAGE_INIT The common page initialize path is : memmap_init memmap_init_zone_range memmap_init_range defer_init __init_single_page If CONFIG_DEFERRED_STRUCT_PAGE_INIT set, we would skip initialization for pages after first_init_pfn. So init_reserved_page would initialize page struct before __SetPageReserved(). If CONFIG_DEFERRED_STRUCT_PAGE_INIT not set, page struct is already initialized. Is my understanding correct? > >> We don't need to do it again. >> >> Signed-off-by: Wei Yang >> --- >> mm/mm_init.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 14133a1cfc7b..30379b0e7729 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -759,9 +759,6 @@ void __meminit reserve_bootmem_region(phys_addr_t start, >> >> init_reserved_page(start_pfn, nid); >> >> - /* Avoid false-positive PageTail() */ >> - INIT_LIST_HEAD(&page->lru); >> - >> /* >> * no need for atomic set_bit because the struct >> * page is not visible yet so nobody should >> -- >> 2.34.1 >> >> > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me