From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69627C27C5F for ; Sat, 8 Jun 2024 04:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB596B009A; Sat, 8 Jun 2024 00:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B236B009B; Sat, 8 Jun 2024 00:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D31BC6B009C; Sat, 8 Jun 2024 00:27:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BAB4C6B009A for ; Sat, 8 Jun 2024 00:27:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 684F54064C for ; Sat, 8 Jun 2024 04:27:42 +0000 (UTC) X-FDA: 82206437964.23.C4919B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 5F3D44000B for ; Sat, 8 Jun 2024 04:27:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nPNnqtW2; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717820860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y+bxrfwaLeJblJYdYvLjkh6/BIFaUGcGXPL7eUr/BOI=; b=CzoeFKynddXWrswxiu748fPIlGZnspIxQ08DILUo0O3BIpuopG6siTyWLvDvfsEPLXNK+n CGVlqKXPDIcZTMayCOLq0fLLfRfLtpLPfUOsQbDiy3EZPN9+bFo4P09anh4AzwPxoHemuB WeQWqAByljP50UfJQhrbnqcg7mEgHk4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nPNnqtW2; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717820860; a=rsa-sha256; cv=none; b=R1a8jLb/ylOFbCtvs3rghzf2uWhltMJ4ho5ccrc3MlFThrMi68cteRapZoS+b3ECoduOWr 5/T8vS9oHNPJUpNJIYhpByM14yQVTLt/qW0lP+r/lHxtKMdGJCSezo7+q8Dme8KKjGwegV nGq9pielSsg4934elEQWVyDi+bibR3Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 512D960F32; Sat, 8 Jun 2024 04:27:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD24DC2BD11; Sat, 8 Jun 2024 04:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717820859; bh=G3GoFdX96mK6HyzLxQ8Jmg4Jk5/2/ZubK6p1ksrewKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nPNnqtW27pDyI8VUEojiXdVrfnbTy1h6O2KDNvm2Fr32HliedMrnEK421WhPXFbJ7 Qvk5HtbqY76xqOJ7oOLSrZk7xUqj3+99Ufwgd0BI81ehY3Wv1QIyTMCA3kwDJA86au 016UhGyaJJOjfhFBksvSRaLUUTQTtXGklk0JctvM= Date: Fri, 7 Jun 2024 21:27:38 -0700 From: Andrew Morton To: Stephen Brennan Cc: linux-mm@kvack.org, Vlastimil Babka , "Vishal Moola (Oracle)" , Omar Sandoval , David Hildenbrand , "Matthew Wilcox (Oracle)" , Hao Ge , linux-debuggers@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm: convert page type macros to enum Message-Id: <20240607212738.bf55318aebd7172fadaa11c5@linux-foundation.org> In-Reply-To: <20240607202954.1198180-1-stephen.s.brennan@oracle.com> References: <20240607202954.1198180-1-stephen.s.brennan@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5F3D44000B X-Stat-Signature: w4cajya1cisafky14r4zr1dgq14npujj X-HE-Tag: 1717820860-123044 X-HE-Meta: U2FsdGVkX1/px+L6G0NasWMo5+xix43C5jDrLrjFtLxb/ecPLyOY/PgjB2fLfiwkLy09CBFtVuCN/Lo6WxZiFl4r9GDxZUBvXcRYAn66/hh15pTXdUUe/5VWMZDH4hbEIOyA4tUEakKqQ0dEq/6I2aUiN+9ZmsAYcjrAcut12apzSMfcnDDNClCfQNOYFuvJXSMxoKNaNlDuBaHa3xjfz5kIurVmf1ntQf06wMdg2uMloE4qkFNOaW+i6vyUXu3hc9ILLwYjEBeTumJeIei0bwXKmZYj7E/H9Y65pZkf/gVFiU3qpDVYy+Io/15Y7jcPf1LINcxeCYuxmkextcPnQY+WbavV95kPF+v8W2a8onsQjLvXcEfGn5RUy6ixRRlN5fFFBBtPtMH6uqtxb3/cpfAunPW4Abl/uOQawGSZCt6mFx+Czq0smS+tkAgseBOkxOeViPliKh/R4UmjOcMj89Oo4fOuabs7iEMR1xt/qaUrtp/03F0Ccg6KQ033O0uaruKr44LZTJCqhiqz3x9U0klpZuPmEE7jR4GzkL75Dz94G3Kb56ZbEVyD6QruwFaFvax1MRWNBrHHO0sjwc3mSpjiLd2cbOicdxxqBUjdtT+B9+R8A9uhtHoaqYgKCNesHHg6iW7ldYirnjqMj7JXYP5+i4YzvleFzpWdIFdCmxTZAAfiTX4znKUqT9M18wjUvjl93bFSZkS14AovsY5Ksp7F73vPixMNthHhhnOGBicsrXD+NFRt5hjjU4EDZYtE+2wIemjIJn9zwWSiY2mcX6ToZ2PaFeCcNVmKE/X84ANxIJ2oVRjlgyHky71FScZAkjhkJa2N4pzgc0f9HmYf+cYCOhQTeDsvA+WjA9TNI2+jPT6kRXbC+EWeBNteAsqFcNmh4Ucfmft3RdDhaasc1BDCD1m2nvVSJsU8uTFCLTDAHtWnP4jLNJUTKmrloo5IyVC1FRdSsKU/KvTai59 mdcMPKUC aPz79ItcjTWuDR4Xq1auh3ZQPWkJ+HDzebf1JoJdgJK6J7lePjyWuoq0mfgHnheUM9cKvSLEy8kjVtARTfmlIVEHiW48ID2v2bOg3wVfYqjSXK4GkRs2z3u0KJjjWAl4KyvhjEh0vxS4LfJoiLPPlWWetjp7IX+9OcuTWnrI9Y6pvkQNoVHhm5tlECJLawnm9qe14I6IPPYUtPQqm7qLpkbGqueQp3mcvnFjXwEP0w5fQ5p/Conv+GIwnWUfr/wDmPNQBkifOkQ6iLW5ovplzsGFFB+DhO9d8W4MbXgGxXE/bxaaZB/RhJ9zEs6G/pW0dV9MO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Jun 2024 13:29:53 -0700 Stephen Brennan wrote: > Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3 > ("mm: free up PG_slab") in has the unintended consequence of removing > the PG_slab constant from kernel debuginfo. The commit does add the > value to the vmcoreinfo note, which allows debuggers to find the value > without hardcoding it. However it's most flexible to continue > representing the constant with an enum. To that end, convert the page > type fields into an enum. Debuggers will now be able to detect that > PG_slab's type has changed from enum pageflags to enum pagetype. > > Fixes: 46df8e73a4a3 ("mm: free up PG_slab") Should we backport this into 6.9.x?