From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Donet Tom <donettom@linux.ibm.com>, Shuah Khan <shuah@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Tony Battersby <tonyb@cybernetics.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ritesh Harjani <ritesh.list@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
David Hildenbrand <david@redhat.com>,
p.raghav@samsung.com, usama.anjum@collabora.com
Subject: Re: [PATCH v4] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()
Date: Fri, 7 Jun 2024 20:52:47 +0000 [thread overview]
Message-ID: <20240607205247.b7touyyblwcpamfm@quentin> (raw)
In-Reply-To: <20240607130623.76ba44371f8f406f5d1678b7@linux-foundation.org>
On Fri, Jun 07, 2024 at 01:06:23PM -0700, Andrew Morton wrote:
> On Fri, 7 Jun 2024 13:20:00 -0500 Donet Tom <donettom@linux.ibm.com> wrote:
>
> > V4:
> > - Added this test to run_vmtests.sh.
>
> v4 also contains this change:
I think v3 already had these changes [1]
V3:
- Fixed the build error when it is compiled with _FORTIFY_SOURCE.
[1] https://lore.kernel.org/linux-kselftest/20240607055046.138650-1-donettom@linux.ibm.com/
>
> --- a/tools/testing/selftests/mm/hugetlb_dio.c~selftest-mm-test-if-hugepage-does-not-get-leaked-during-__bio_release_pages-v4
> +++ a/tools/testing/selftests/mm/hugetlb_dio.c
> @@ -40,7 +40,7 @@ void run_dio_using_hugetlb(unsigned int
> ksft_exit_fail_msg("Unable to determine huge page size\n");
>
> /* Open the file to DIO */
> - fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT);
> + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664);
> if (fd < 0)
> ksft_exit_fail_perror("Error opening file\n");
>
>
prev parent reply other threads:[~2024-06-07 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 18:20 Donet Tom
2024-06-07 20:06 ` Andrew Morton
2024-06-07 20:52 ` Pankaj Raghav (Samsung) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607205247.b7touyyblwcpamfm@quentin \
--to=kernel@pankajraghav.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=donettom@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=p.raghav@samsung.com \
--cc=ritesh.list@gmail.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=tonyb@cybernetics.com \
--cc=usama.anjum@collabora.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox