From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835CDC27C55 for ; Fri, 7 Jun 2024 20:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C9646B0096; Fri, 7 Jun 2024 16:30:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A1566B0098; Fri, 7 Jun 2024 16:30:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0687F6B009A; Fri, 7 Jun 2024 16:30:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DCE366B0096 for ; Fri, 7 Jun 2024 16:30:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 829901216A8 for ; Fri, 7 Jun 2024 20:30:40 +0000 (UTC) X-FDA: 82205235840.21.C382240 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 4BC5F40026 for ; Fri, 7 Jun 2024 20:30:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=fByf2Gpr; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717792238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zayrHH/z5RIcd0P8fXfRYa45JHnjwR22LFwlmddRB1I=; b=s9tB3W6Pg1r+28DhHOwJuQx1HuUMmcYA99uqsFtfBWjoegejcvulTs/yQ/J0qjXPKBz0Ia mUO5IrdN7vGi77aehiLx4UB7/TrJbbO4OzsVM+6VNOvZvzkPpH+Kygq1z5Xxzu83MSaB+e ayh8YcEE2CLSXYbsC0GqaoUcqkpYA2c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=fByf2Gpr; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717792238; a=rsa-sha256; cv=none; b=2Re/xQnB5cLKBYiSWpyZx3IxaHf21/Escxl3UvLVPfMdUkm2RNWjAHp+I9mZqGnLmrzjgw 1B3pFTj3lUo3FSJ/BaJb7X7LnRvlRMiDE2K0gM4WY4M2sBW2l60QDXuBVM0+kKQNbg8RxG RoV23u9ROTAph9P8GhYqCuCNNC6KaAQ= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4VwtB06wNcz9sjn; Fri, 7 Jun 2024 22:30:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1717792233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zayrHH/z5RIcd0P8fXfRYa45JHnjwR22LFwlmddRB1I=; b=fByf2GprKvSs9RDKyKm8QidRaXMK/eMvdvXxEJgsugRtXHziRyz7h1fpXuOJF08fQFThPU VYKrDF8P/uUWJ/IkwJyGDQAPcE7I5dE/vKK6VToCwmy5gEW59Ly1setDhG6tHesTY99V+2 ZCFtAAcvM0sbIQ3GmwTuw7g+jegI+VRHhG3147VOjBsZTKWR9cQR3PffAd7M3zAhDsjrIf vXZQYhEIUx7V2foDlryJPwA2vbXkicc0z5poVHJu4pZdiHTmZC/TOicmvU/u8uoQOqQGNU xMIk0wR0n/9aXVxymhi6ixRI26bcZB9FlUCwrjn5gL5004atn+lqv6c913eFDw== Date: Fri, 7 Jun 2024 20:30:26 +0000 From: "Pankaj Raghav (Samsung)" To: Zi Yan Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 05/11] mm: split a folio in minimum folio order chunks Message-ID: <20240607203026.zj3akxdjeykchnnf@quentin> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-6-kernel@pankajraghav.com> <75CCE180-EC90-4BDC-B5D8-0ED1B710BE49@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75CCE180-EC90-4BDC-B5D8-0ED1B710BE49@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4BC5F40026 X-Stat-Signature: 4d7q88mjarrnno469nads8rtzbwsk5xo X-HE-Tag: 1717792238-647066 X-HE-Meta: U2FsdGVkX18P0Ih34okI21Fb4uvIFbaz/lE97UsMaYhCifS/qpgVOwTzOAc2MvaQNQmFHcQ0sSuX8AWCYLl7W/SCwsq5AxbkYdOg2XK7Y0yIEarX+YhRdfJJ56Ev2sbEKKtWITRC3iMlwiZXTo4okSdZJnyvQekAjdisAq2sb21cje92b2TMpGknoszQST9ksKQQwBstogN4+LntEYeyzR3lMeLTVFbpoHfn2IOaG3NNYFFQinvUMcPVAyYfiTVE1+0l4HgTMJAZTTbAlNxOq9metIm3I8QwuEKpyT4voKbjwftJNvtTJ9bF0f1/3M3pxvPHhXJK+y9YRjMrri6XvUrLyJepMZuEkMKmZwoKpGbhZqsT7f4PMQLn6lpy9WiUSM0vS9jbT6Rgs55inMfcwCBJGGtgTiHdbC9CDW35P5RQuzQIa9e+lV4ELtEU7BRA8C+mBeApQcgjH2m8mdDj0aNk2Gd/S4oW2fVYKhGXniMcI6oVOBiNfxayzQhDqdGnjDO08doqRA9r3rRUFMIK1o7UQ2YIaCyCRi824JPvr3TeoBtjPi6sTxwm9FOS4L4x5x6uT9hu//ECNOcmrCcUYyD7gpGeTcE2YLp+ypTtYEGB6XJe6IHRd2u616nRu2WtO9n3i0oOvYDE7cNB8Wp0SAD+Mn1ZRjiKRbhMgis2ouIeK4O1AacTsiMoF6Gj5lxLJ8jwL72Z2Ai0W9M5JzgZw6HL86dXbxzp+/lpuqzQ5dWLUdhyZG5+9VahbQoaSsJw8mNFP9q3GH3hL4SwAeF/Y4swe9O5+0HpiQY+xKt5CbW/CiTwRZJ/olrH9mHyugMot+KmbZeIgk1CK+8xb0ySaWSAbw97OAdHfHui7jLU7dcsJWiHrdpJykHB15KBcJ3G8z6yh9XeXfvlqPDdmo2s7pH8sF2mSENxlgmZnvLYH3IRqhAXRkzOUH7OoGyJytmRRAk38boxGp0uZ+/ZQx3 4dMpeC/e dP+C2vu6azuwjhvKNFckm7JowTliUi0keh1KosN9kTh/RZ/kdPQpRPYolVxNgCqhcvmdbgIyL9BLxdpzlFo9P7hr0exyWOKgYooBdghmAfDz66dat9xrltl2kLbOkl9niTHMlqPNcU/x5yd/IxY61gHGgGqlgYS3e+StisdhKQ4Hjbo5s+O9sHuSl3oxpctzKNj/IwwgLHDO2y6qSuOQcAtUua7CItbfFnY2ZDzIrKffjDKUO1lJhuYgFN7D8Gq5BC9DIa6ogdBITWeVz6bfXFxc8t+IJ+oIXIIreUy9qrCCL4gbASiNM8L6Kc9RseLlffW4GBLcs23/Y5w2iMCzAhzwZgJWV5/e8zKwWDJ8GwyfgPWw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 12:58:33PM -0400, Zi Yan wrote: > Hi Pankaj, > > Can you use ziy@nvidia.com instead of zi.yan@sent.com? Since I just use the latter > to send patches. Thanks. Got it! > > On 7 Jun 2024, at 10:58, Pankaj Raghav (Samsung) wrote: > > > From: Luis Chamberlain > > > > split_folio() and split_folio_to_list() assume order 0, to support > > minorder for non-anonymous folios, we must expand these to check the > > folio mapping order and use that. > > > > Set new_order to be at least minimum folio order if it is set in > > split_huge_page_to_list() so that we can maintain minimum folio order > > requirement in the page cache. > > > > Update the debugfs write files used for testing to ensure the order > > is respected as well. We simply enforce the min order when a file > > mapping is used. > > > > Signed-off-by: Luis Chamberlain > > Signed-off-by: Pankaj Raghav > > --- > > include/linux/huge_mm.h | 14 ++++++++--- > > mm/huge_memory.c | 55 ++++++++++++++++++++++++++++++++++++++--- > > 2 files changed, 61 insertions(+), 8 deletions(-) > > > > > > > > > +int split_folio_to_list(struct folio *folio, struct list_head *list) > > +{ > > + unsigned int min_order = 0; > > + > > + if (!folio_test_anon(folio)) { > > + if (!folio->mapping) { > > + count_vm_event(THP_SPLIT_PAGE_FAILED); > > You should only increase this counter when the input folio is a THP, namely > folio_test_pmd_mappable(folio) is true. For other large folios, we will > need a separate counter. Something like MTHP_STAT_FILE_SPLIT_FAILED. > See enum mthp_stat_item in include/linux/huge_mm.h. > Hmm, but we don't have mTHP support for non-anonymous memory right? In that case it won't be applicable for file backed memory? I am not an expert there so correct me if I am wrong. -- Regards, Pankaj