From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
liam.howlett@oracle.com, willy@infradead.org,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH v2 16/16] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc()
Date: Fri, 7 Jun 2024 11:52:57 -0700 [thread overview]
Message-ID: <20240607185257.963768-17-sidhartha.kumar@oracle.com> (raw)
In-Reply-To: <20240607185257.963768-1-sidhartha.kumar@oracle.com>
Users of mas_store_prealloc() enter this function with nodes already
preallocated. This means the store type must be already set. We can then
remove the call to mas_wr_store_type() and initialize the write state to
continue the partial walk that was done when determining the store type.
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
lib/maple_tree.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 3d334e7c19a5..5854f25a4ae5 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -4027,9 +4027,6 @@ static inline void mas_wr_end_piv(struct ma_wr_state *wr_mas)
wr_mas->end_piv = wr_mas->pivots[wr_mas->offset_end];
else
wr_mas->end_piv = wr_mas->mas->max;
-
- if (!wr_mas->entry)
- mas_wr_extend_null(wr_mas);
}
static inline unsigned char mas_wr_new_end(struct ma_wr_state *wr_mas)
@@ -5598,12 +5595,23 @@ void mas_store_prealloc(struct ma_state *mas, void *entry)
{
MA_WR_STATE(wr_mas, mas, entry);
- mas_wr_prealloc_setup(&wr_mas);
- mas_wr_store_type(&wr_mas);
+ if (mas->store_type == wr_store_root) {
+ mas_wr_prealloc_setup(&wr_mas);
+ goto store;
+ }
+
+ mas_wr_walk_descend(&wr_mas);
+ if (mas->store_type != wr_spanning_store) {
+ /* set wr_mas->content to current slot */
+ wr_mas.content = mas_slot_locked(mas, wr_mas.slots, mas->offset);
+ mas_wr_end_piv(&wr_mas);
+ }
+store:
trace_ma_write(__func__, mas, 0, entry);
mas_wr_store_entry(&wr_mas);
MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
mas_destroy(mas);
+
}
EXPORT_SYMBOL_GPL(mas_store_prealloc);
--
2.45.2
next prev parent reply other threads:[~2024-06-07 18:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 18:52 [PATCH v2 00/16] Introduce a store type enum for the Maple tree Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 01/16] maple_tree: introduce store_type enum Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 02/16] maple_tree: introduce mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 03/16] maple_tree: move up mas_wr_store_setup() and mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 04/16] maple_tree: introduce mas_wr_store_type() Sidhartha Kumar
2024-06-13 14:27 ` Liam R. Howlett
2024-06-07 18:52 ` [PATCH v2 05/16] maple_tree: remove mas_destroy() from mas_nomem() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 06/16] maple_tree: use mas_store_gfp() in mas_erase() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 07/16] maple_tree: use mas_store_gfp() in mtree_store_range() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 08/16] maple_tree: print store type in mas_dump() Sidhartha Kumar
2024-06-13 14:29 ` Liam R. Howlett
2024-06-07 18:52 ` [PATCH v2 09/16] maple_tree: use store type in mas_wr_store_entry() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 10/16] maple_tree: convert mas_insert() to preallocate nodes Sidhartha Kumar
2024-06-13 14:40 ` Liam R. Howlett
2024-06-07 18:52 ` [PATCH v2 11/16] maple_tree: simplify mas_commit_b_node() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 12/16] maple_tree: remove mas_wr_modify() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 13/16] maple_tree: have mas_store() allocate nodes if needed Sidhartha Kumar
2024-06-13 15:00 ` Liam R. Howlett
2024-06-17 21:18 ` Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 14/16] maple_tree: remove node allocations from various write helper functions Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 15/16] maple_tree: remove repeated sanity checks from mas_wr_append() Sidhartha Kumar
2024-06-07 18:52 ` Sidhartha Kumar [this message]
2024-06-13 15:02 ` [PATCH v2 16/16] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc() Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607185257.963768-17-sidhartha.kumar@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox