From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A571CC27C5F for ; Fri, 7 Jun 2024 12:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A79A6B0085; Fri, 7 Jun 2024 08:24:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7584E6B0095; Fri, 7 Jun 2024 08:24:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BFEE6B0098; Fri, 7 Jun 2024 08:24:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2A5D66B0085 for ; Fri, 7 Jun 2024 08:24:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FD4A1C2D01 for ; Fri, 7 Jun 2024 12:24:11 +0000 (UTC) X-FDA: 82204009902.10.9736640 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 745454000B for ; Fri, 7 Jun 2024 12:24:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R8rcyjN0; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717763049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AVo7IPc/OzMgdNcQVcdkp4iZHfQkhLNpmKtGDFarvnM=; b=vIccO8SqSu+vP2cm2E7byUNcvZzLAE/torq87ImUIPQviNNitRaa3FSn/cIhFYePykqqbZ AR5+3Jm0EUPYL/Ak+funapL+FGbvwuTIvNTy/0cLzHDGr/fmICqsQLJsLfLDIsG9ti1pgK JrkCQ+BZhTnCETUEdedo9EGNEbZmyEI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717763049; a=rsa-sha256; cv=none; b=aqwNm0042kvQjBQuWuInFQ1ZOaVoNo/uiRHR1AFZRyu6zXmON6cHCFg7Eu1sMZbB3iX7yx APnx2sAN244jtphYvr12zq7DGtNpWQRd7v9DsbRGePmKSfnX6Lfd18iLml/Pj/8/qq2rLb qEobUwQHwITKjSVgcNDvmvFJq9Mqn8M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R8rcyjN0; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717763048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AVo7IPc/OzMgdNcQVcdkp4iZHfQkhLNpmKtGDFarvnM=; b=R8rcyjN0qjcEVaabi+H7ZIy4UKLTnxs955DKUc0FQSzgg/gOIH/6KH9wCX4GkkGj0EtoKh p57LXJXm/WtpCqvxqMA1N4Rou+oao0S9TNnxdG5Eytjhgqj+60an9BU0pqkjHynEowauHZ U3AgEp6wStqU2u58bJGcf/3rWy/EHfI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-8Lw9Jl3kOiKOKhr_XOiSIg-1; Fri, 07 Jun 2024 08:24:03 -0400 X-MC-Unique: 8Lw9Jl3kOiKOKhr_XOiSIg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 322EA3C025AC; Fri, 7 Jun 2024 12:24:03 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 569D9492BCE; Fri, 7 Jun 2024 12:24:01 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , "Kirill A . Shutemov" Subject: [PATCH v1 1/6] fs/proc/task_mmu: indicate PM_FILE for PMD-mapped file THP Date: Fri, 7 Jun 2024 14:23:52 +0200 Message-ID: <20240607122357.115423-2-david@redhat.com> In-Reply-To: <20240607122357.115423-1-david@redhat.com> References: <20240607122357.115423-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Rspam-User: X-Stat-Signature: in7r758ug7dciwokmwf16uemdhfb1rio X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 745454000B X-HE-Tag: 1717763049-490781 X-HE-Meta: U2FsdGVkX1/X48x/R05f6bSP5VyJ/36JnTo1fg+mDynP0EfmEnGu7Qo+gkFvI/5Z2ZMJVyMzgj+0GZsEvYyH77dZqimrWXYsEKOhPo6E+dSeVyo0T8COMgbjQBFdnB/5OZqu9BBU/dmuoBhSm6HKMlN9PvTiAnUEURxK4GQUTa8Rsoags9QSf+lcvGONfBQee8g+rXseOxZL3u0ZCF9gCjLpGfgLfio3w0bs03yaSiXv4OO+7Frltjq9PelOvZOj9RKjkIzQI8BsXSnx3PwiCDb+8gtgVX2XbJ1Byv+3zIlkHP/IsZUgWJ0PkiklgslZqiaN9Bjn0TWv8Fh/FXMz89f4YpcZKqXd5KGgfEZpDi+XhTa58N1qdolGXeg0AtvxSriOLMx9OYYkGcuRYYkOk9iXuubwaa6Sk587nt5V4jk8Vx/QaSyj6mmm3llkS2eOjvZi/uHoQfi0r2MYJ5FPMw4CRfKh9BYFov6EfLhDLm1GFml5KXXRpucschhpa5SIMo7De8K5bBQU+8y1RcvPNoIF0PVNTR8Ud2pWaAXCnLbOvDlWcbBNXGYyb1FtmafgurCImD2Hlafi7QGXLIqu15EQZX+XewisWJs57C0u3DcryYEmYK70NSmrqBsr5UYAA0fSt2OZd9Q7Et67F5pgo+vxYifptfDsO5eskYZOSl63IS7XIOhP69YsNMgE9UnKmES9gu/OiZND/JNK5jvlREcH4cil0ch3MTzgPLSxCl7/xV6ZRqlCKm5+u73g1GOldV85XkbLEEgIvyr8DvNABtSxIl3n826C5XvKLmPbMdwu633vjQTfG0RzWdWRt1Z1to3LK5U2mjpkl+sVXH5arNwoMkkk+q1ImpdMAhg3kOIa107ErOe08TCjS0D6w+kQ31oheGTaXo4TOshFD7Vj184/In1ECjlJrB2Yn4phLN+iTWeuxYdwNCszkYkA0tO14yZ76OJ55qD1PeAUjzc WHVI9pm6 97RjS+kDaSP1lgHUtPMc/OWhuiMohFYJ3CYDr9ZD6jEwWv1SEJGUNA1IgpP7h47MPLj1W6OAPS4C/M4toxVHuRvs0TQrFJZ8SSBEXAxmUHm7CbbtsfpID6F4BFde8nC//FR+s2qunpqGU2k0v2HyuYQCfRxH09vzaawSHIVnSvQptbINu2HIWur1CZBFG0gTkgfIZRKhDKGrFOwI758YrKi0cZ6BUSxG+1w7/70FErbnf84ewRwxaOfVz0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Looks like we never taught pagemap_pmd_range() about the existence of PMD-mapped file THPs. Seems to date back to the times when we first added support for non-anon THPs in the form of shmem THP. Fixes: 800d8c63b2e9 ("shmem: add huge pages support") Cc: Kirill A. Shutemov Signed-off-by: David Hildenbrand --- fs/proc/task_mmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 5aceb3db7565e..08465b904ced5 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, } #endif + if (page && !PageAnon(page)) + flags |= PM_FILE; if (page && !migration && page_mapcount(page) == 1) flags |= PM_MMAP_EXCLUSIVE; -- 2.45.2