From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C427C27C52 for ; Thu, 6 Jun 2024 20:31:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C09386B0088; Thu, 6 Jun 2024 16:31:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB82B6B0092; Thu, 6 Jun 2024 16:31:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A589D6B008A; Thu, 6 Jun 2024 16:31:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 894406B0085 for ; Thu, 6 Jun 2024 16:31:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3220F802F5 for ; Thu, 6 Jun 2024 20:31:03 +0000 (UTC) X-FDA: 82201608006.29.42FF6C3 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf03.hostedemail.com (Postfix) with ESMTP id CF5F220010 for ; Thu, 6 Jun 2024 20:31:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=fqhVzOEv; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717705861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z5NfvXWO/90Z6j5OMVbYqZABK9/u9XXuehG4bdp4rXs=; b=cm+v/EEOOW+3qCzxUa5kgaQAR1u34yRjZJD4/FKoBWKzVblRrDcPJHyPWgHGNczKsxoa/Z TkEHAFXwgwFwqjoZ1Yu2j9g7zTEbwaJc0kVUsq3llrQPU86OXbhmVI7V4CdwJBg8qjaNjO Frkp5Leyw8StXjOjp+NM447BVp9R9VI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=fqhVzOEv; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717705861; a=rsa-sha256; cv=none; b=GWVLLggPmdpElvRX/44hojQe9puYeSjitGsORCJP1cVabZYSRmH1tIpvTMTxRd4JdEqJmx a1rT260VMxMCW1iqbm3ZRZT2LpnZygWAAD0ttASNZvsjB7C2z5pcdqafffUmrtR8Te4W9y V+CvC5kufVOFXdlV9jNrFsXcuOzzyKk= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4VwGDw5WZVz9sqx; Thu, 6 Jun 2024 22:30:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1717705856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z5NfvXWO/90Z6j5OMVbYqZABK9/u9XXuehG4bdp4rXs=; b=fqhVzOEvhXg6LmCCHh9I/eetys9d2oOHuYWpTTsAoQ4IJJQS8UdnBNKsZmqKCc69NMo/rA ggLklI9puPXPNMrL1ANJ32kpmfQgjfSKxj2rqpFdb1rt66T5EzNycVT4W56jmxOlnEUDq5 VmdQ9iDftbPydPxcECIZm0j1/fuxG38gXny7MyUWEw/TO4SZED4ROgTQozTI6oliNLJUoA YmlgxoRM7y5B/GqNhsyPcRoyTH/sSJzg+3Xmdw68U8mDjVvh9JaJ+jM2+V+856/QRoIkyk AeIX4IPm7sohwbNLPb0ZimfcLWlHx9WOYHX7iTinwE5BZo5l+6gztH1/FSApJA== Date: Thu, 6 Jun 2024 20:30:53 +0000 From: "Pankaj Raghav (Samsung)" To: David Hildenbrand Cc: Shuah Khan , Andrew Morton , willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, linux-kselftest@vger.kernel.org, Zi Yan , Pankaj Raghav Subject: Re: [PATCH] selftests/mm: use volatile keyword to not optimize mmap read variable Message-ID: <20240606203053.y5zxa54ndv53d3qj@quentin> References: <20240606135835.600022-1-kernel@pankajraghav.com> <5b4e7ef2-3ced-4d4a-989c-e99b06598d32@redhat.com> <20240606201831.ywmawi7xl6jgj3p4@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CF5F220010 X-Stat-Signature: m11isx1jths3ujiyy8tnq9a6tzanzz1w X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717705860-902678 X-HE-Meta: U2FsdGVkX19igf37RCSOfDFYFoU2l+bz0jDS0K7NN9c2iPsJI2/hPOYtvYUEYp0IFAMVNpUid8beFutG+bYEowfiJhPUvMaYrAw7ya/uX61BYzYKxx0PfGZkumGWPtGD5SgtXZlnNFc1Cg+jU/dtw8jgClarEs2m0PQYtXdd9t/yMaXo1BcITdLOqe/9Hr7rCaT8dhsglSOVTM4lUfoKU6fLXN+t8wBmFauTI052xqncYq0REB6CQvlLxzzVT9Ejn5kdtS6L5J7HPirZZSMZoFQ/YdqPFy2bKLhupSkjBUSrJwgbS5cq8piOi/OYFsePGe2jHFI7TbUCnk/3DPbooC4DY6mDPz0/TSf/ZFwu6ofZW4Ijr2F8xj1sB0hgpNpb/05J2gjAQSwjbQ4S4gLIFGrFOcMoP8boRZn7qLZ0E652pZB63robUMuh7nKc0r6PgnUQx2zUJ+5dw6Ra1VDL3TYP5UOHIK0NZlWtS9pndYYNZlVSmTaAnMu8POAuXJNOU6IAIWbss57Y8/iZHUYVBZf5+WPBiRa6NX7Jr3dN5PQtZ50sRYcPGkap86ZPeTT/fY8W/d205OxmoZrDBwuIjG2KWgW2mJndTTl459Raq96l1GRc4kAmoraiui8gW1BfAPhOiLLefQUfqq5cVhPg7j4f6gQN2s8+zEbSP5pshSZbRJ0T90nvZHLBAQzfbjjJGpCeeHTebaqyuF4CkfCIC3ATFuTeZOxj3mg4J6QMh/rSXsxL8Tk/lsdsO+4e+GA0qdH8FTyg8MT/OhC9xKVemexZ0hju9IWQplj3cHk3MB0JDQCufNQrvigmFZsNBChzAQ/hgxzP4Do8UkIQvtnq4kXXIWcF3/GJbwLIqIqfQ/hgTxi5SaeaegzvJfSuDOjYw/UmKb2o1QIuRKNw8RNITlH3kOR2LhpWVuSPk6jgQNFr+sb3zbUB+PduWVAE7ooELEhBlJJkPfAprfBBLDL 328UJ5lS BSJIzx+pSwjkk/KMrZYKCZM3n90plUXj0SUzqbYHdaindjk22oMwbPMHSpvZwi93CEqIMIVJoVjYrgXaTMnoxpz7Zy0d9nzilLwfipnM1HrkI4dR3pjM57cuo1bQLpGMxWzJ/rDeB9gVCUYgxyGfdgneyabgv1jYcHmpzzhrVZk6b1dW50NYYXVMfVRi8pYnzurgswVPqzN4Gmkz/Cm+t78SZcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 10:21:51PM +0200, David Hildenbrand wrote: > On 06.06.24 22:18, Pankaj Raghav (Samsung) wrote: > > On Thu, Jun 06, 2024 at 05:57:21PM +0200, David Hildenbrand wrote: > > > On 06.06.24 17:56, David Hildenbrand wrote: > > > > On 06.06.24 15:58, Pankaj Raghav (Samsung) wrote: > > > > > From: Pankaj Raghav > > > > > > > > > > create_pagecache_thp_and_fd() in split_huge_page_test.c used the > > > > > variable dummy to perform mmap read. > > > > > > > > > > However, this test was skipped even on XFS which has large folio > > > > > support. The issue was compiler (gcc 13.2.0) was optimizing out the > > > > > dummy variable, therefore, not creating huge page in the page cache. > > > > > > > > > > Add volatile keyword to force compiler not to optimize out the loop > > > > > where we read from the mmaped addr. > > > > > > > > > > Signed-off-by: Pankaj Raghav > > > > > --- > > > > > tools/testing/selftests/mm/split_huge_page_test.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > > > > > index d3c7f5fb3e7b..c573a58f80ab 100644 > > > > > --- a/tools/testing/selftests/mm/split_huge_page_test.c > > > > > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > > > > > @@ -300,7 +300,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd, > > > > > char **addr) > > > > > { > > > > > size_t i; > > > > > - int __attribute__((unused)) dummy = 0; > > > > > + volatile int __attribute__((unused)) dummy = 0; > > > > > srand(time(NULL)); > > > > > > > > > > base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd > > > > > > > > The rick we do in some other tests is: > > > > > > > > char *tmp; > > > > > > > > tmp = *whatever; > > > > asm volatile("" : "+r" (tmp)); > > > > > > char tmp; of course. See cow.c as an example. > > Thanks David! I remember also seeing this when I grepped for volatile in > > the selftests directory. > > > > Willy gave the idea of making it as a global variable [1]. But your > > trick also works :) > > > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > > index d3c7f5fb3e7b..9c957703c1f7 100644 > > --- a/tools/testing/selftests/mm/split_huge_page_test.c > > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > > @@ -341,6 +341,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd, > > for (size_t i = 0; i < fd_size; i++) > > dummy += *(*addr + i); > > + asm volatile("" : "+r" (dummy)); > > if (!check_huge_file(*addr, fd_size / pmd_pagesize, pmd_pagesize)) { > > ksft_print_msg("No large pagecache folio generated, please provide a filesystem supporting large folio\n"); > > > > I am fine with either solutions. But using the trick asm volatile is more > > cleaner than making it a global variable IMO and makes it more uniform > > across the other mm tests. > > You can then even the "__attribute__((unused))", because the compile must > assume that it is used inside the asm statement. Yup! I will send a new version. Thanks David. > > -- > Cheers, > > David / dhildenb >