From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D44C25B75 for ; Thu, 6 Jun 2024 13:14:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E3186B0082; Thu, 6 Jun 2024 09:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 793266B0095; Thu, 6 Jun 2024 09:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65AEE6B009C; Thu, 6 Jun 2024 09:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 452246B0082 for ; Thu, 6 Jun 2024 09:14:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD230A1615 for ; Thu, 6 Jun 2024 13:14:47 +0000 (UTC) X-FDA: 82200508614.20.78ECC15 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 97037100006 for ; Thu, 6 Jun 2024 13:14:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=samsung.com (policy=none); spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717679686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2tMmmyBbZeTTofPKQUJgEDsdwhgGJdPHd1pKgME9E4=; b=7JQpRLtSkD4Nd7bj0JeUqXDThatV8hCu+NeKYBIE9t58WzZ7TcMkKKnu1SGYrd83qucoHt ydjzapx/xkpE0kRLPUTqppuBnokKp5IJnsEi2DvGKszBsOWSEdjMB1VBEAqsqgiDAVIqdh /G4v4cfccBbyHzq5uyOFBipqGpe3D2w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=samsung.com (policy=none); spf=pass (imf05.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717679686; a=rsa-sha256; cv=none; b=OVlnQPvLiiW/PJZMc8e0zT1pq78JQ/Nw209HDY5BvuqYHC+MyTyY6HKVMK/FvAibZM1FJf 1NMUddj8O2om9kVdAQ34o0nV7VgA9N2uRxxcNRL/Umnb9J7JPfiy5Es9FcngHNiieACE3s lFMKhthKn28BxfJ+No5ic8bE2VvKxJM= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Vw4YX4BqXz9scC; Thu, 6 Jun 2024 15:14:40 +0200 (CEST) From: Pankaj Raghav To: donettom@linux.ibm.com Cc: akpm@linux-foundation.org, david@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, ritesh.list@gmail.com, rppt@kernel.org, shuah@kernel.org, songmuchun@bytedance.com, tonyb@cybernetics.com, willy@infradead.org Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() Date: Thu, 6 Jun 2024 13:14:29 +0000 Message-ID: <20240606131436.592793-1-p.raghav@samsung.com> In-Reply-To: <20240604132801.23377-1-donettom@linux.ibm.com> References: <20240604132801.23377-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 97037100006 X-Stat-Signature: 3dkk54sy7knkornx9ta611uxxsf3f7ot X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717679685-3422 X-HE-Meta: U2FsdGVkX1/Z6EqSJ+CPXnbBT5hqq4mobfx0C7BaZPDslSDPbQHYB99SJ0iV4FbxTAnC2uWErkvFz3SVC93sJls+07B8A1/tTDR5wWmsqlcJvBTXOtHJ2H0lwWOZJaKSkpa/dIF6YoY7UzCZAVwbXDnW+QOHbpf82zmBXCL82ImyhJmRUR/CJ+z0LvkGWsCW3oGnZdWpHAu233YtaA9MzC4KHcx4DTDMjFq7TcsLch5XSCSgmq8qPlM5UIQGn3GALvYBb70yGWoFnHxXKIT0KwCB5Cmp6tn38H2gD5tKoZu1GozFtzEiZCz1NQMWQBqLGjetqCphLNtqsX4LghujIUtlfPjviRissd/1VVKhlakutg7kkU7frtbMliEKNvxzTYHZXEH6fBYJbgiBAef23ZL51bJsgokk0+ThVbpT4Yy3LbrCA2WWh3Xe3u90lMq7xhaYpSgrfPqcuDamok7wxbjXNkFPf7+S9hnUYTG+N6Wg8Jq+OBI2SEmiP/Zi/BYSQosJDlyOVL68H0jlNiDKOdujrCT4/ZUCYBBtDtbzQW5nuADsHkbp2cc3e3qIin4Ta4OYJqDbNVUKDczSfjuV3gTRvIW4CexyjBty3jZjDh7nWVCdZsqqeqyxE7lwP8bQHPBUP2dElig8qoGefTcLAhO/xkCZ7QTtWbdWEAGJo60OcRYFQfcQbPxKGvKmVGfiI9jLL6znitUeZ9z8M0by8BQwOfuUaswWtyQIHtJOReRxXU0PGBjt57PiQkGcaPFAPnj6IibaORzAd26ULlXjzICE+KnaDExi4lYa2tyQDmQVO8aS+8Q2iA6mIBUIiRTtZ4w0Stc9hw7TUIcB4s51C1ur8ZKtcJ+tmoGTvn+xhlhmEiptg42r6UVySr3ykpCFdzFYpowOQFIEvTlSVCVoh64W0g4+5+u03hjZevXQrIly2bBlt610m/dH9F0QpXDmrlsVU6x6QsuvcEbuJTx VvhvXfDT ATf/ku7Gi+U5tXVhWoabJ8TjNX/m/W3wjlI0XIf1rB0nr+uAHRjTgX3ZT/gyY2J/GEwpYuSLDceZHQoRWgiU3+YmQcPE5YaQE0ZHKZCCF6jiuGWHQvDKtfQLgFTpHh51lNC8nUhRPmUItPRAAoqqvo2WUPVSbb+69QHPgzks1KA8voukv9DLR4XAl1QI5yzQFf9wvOMGrkBtLhLcWlpPMkJsDZQDlymU9B0tUGkdN2IG5Yqab3UVk0lI/S5jIwIH+sJV/ETplXkAZn/lxX/MCBojuAwriglQHCLQ4zQkkeQVRIqAk+BDnrt2+LZN4HrrmNCn3s1gJQjv3X3L9FyIjsCSk4+5YEDpGru43PhwVmTK5azsrieY8R4446/vAeJn8nJWB67/Tq80jYZfXIdBYk2PF2d7kLXssfNOFriAAOqlTYRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) > +{ > + int fd; > + char *buffer = NULL; > + char *orig_buffer = NULL; > + size_t h_pagesize = 0; > + size_t writesize; > + int free_hpage_b = 0; > + int free_hpage_a = 0; > + > + writesize = end_off - start_off; > + > + /* Get the default huge page size */ > + h_pagesize = default_huge_page_size(); > + if (!h_pagesize) > + ksft_exit_fail_msg("Unable to determine huge page size\n"); > + > + /* Open the file to DIO */ > + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT); I encountered a build error as follows in NixOS: In file included from /nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/fcntl.h:342, from hugetlb_dio.c:15: In function ‘open’, inlined from ‘run_dio_using_hugetlb’ at hugetlb_dio.c:41:7: /nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/bits/fcntl2.h:50:11: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments 50 | __open_missing_mode (); I saw a commit that fixed similar issues with open syscall before: 8b65ef5ad486 ("selftests/mm: Fix build with _FORTIFY_SOURCE") So something like this should fix the issue? - fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT); + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664); > + if (fd < 0) > + ksft_exit_fail_msg("Error opening file"); > +