From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECDBC27C52 for ; Thu, 6 Jun 2024 18:10:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86FD76B00BB; Thu, 6 Jun 2024 14:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847B86B00BC; Thu, 6 Jun 2024 14:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8BB6B00BD; Thu, 6 Jun 2024 14:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 50BDA6B00BB for ; Thu, 6 Jun 2024 14:10:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0398181722 for ; Thu, 6 Jun 2024 18:10:46 +0000 (UTC) X-FDA: 82201254534.09.750A81D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 3AB4E180009 for ; Thu, 6 Jun 2024 18:10:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UXYE+7+9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717697445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lEOCDoKj5okVkR+anLR3xaJqdVdR4eltj8yqF6VBBDY=; b=CjcsWrQMrQjiIdu1ApM9y7+SB12f5KvJh6X502kYOJdnTYto3lyLIffzLtLL/kZRxi4QPp ZAc2L8tMaRTY3GqBZ6tCXF4a14QcVKLchAR8gMHzC5cwJH+e41I1CsguDI/ATucsDTAS51 f8srkTKZ2f6NJ/Xioo88+3xqw0M8bKo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UXYE+7+9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717697445; a=rsa-sha256; cv=none; b=3gkPOZmfkGOjGekJribZixoWhKNI5vIHyHeiVY6FNDFsChYokP1n9ejsJEeDndgirHUsk1 ujmzNTgzNg4FMsShYDGztBkCWZF5IzNI1kKDmmgCjn4BC0KT/CoXA3fFxJ3SjYiJoqyyzo UgM22mFXnOdjXMxDXDpUEeLVP+fBwgs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3A9AE61E56; Thu, 6 Jun 2024 18:10:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9840C2BD10; Thu, 6 Jun 2024 18:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717697443; bh=BzBvKfRYf5H5w8Tr9gYhIFdphdps4vJOBgdCivkqei4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UXYE+7+96aKrBBGPngY+kWo816vcDRyPO2x7sjF0Ul7NhOOQ91Sy0uig2dXTgetmp HSmmBVmnyqBwXwnGAnHxIOaQligPQhL5/nSDQOJDJgdS4/IZBA8jdAdg8cRbJcA2Uf +dnO+pDdvvPRsVaxZ6FBvoJDglntiweXDs2DuZI2ohKLZT98GnYXMV5mqmiD0Qz4DD kn+zoYdZ8B4blL3iUHl7ZiT/VxV5oX2z1CLxYYZuyk3gPH72loc0CiSpqoMttU9TB7 hfEE2Hrzfu4TwK+e6U15I4dke2xuc3rzSDPQrcwmXM/sAIJKh0D2//JwlnGqHgfbha uJBUxffqiKssQ== Date: Thu, 6 Jun 2024 11:10:43 -0700 From: Kees Cook To: Andy Shevchenko Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, andy@kernel.org, akpm@linux-foundation.org, Jean-Philippe Brucker , linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/util: Swap kmemdup_array() arguments Message-ID: <202406061108.1D3E64882@keescook> References: <20240606144608.97817-2-jean-philippe@linaro.org> <171768935175.54606.14878127902164737048.b4-ty@kernel.org> <202406061046.A2137C9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 3AB4E180009 X-Stat-Signature: yj55pj4woy6nngx6j7911os7qt1gadek X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717697445-346448 X-HE-Meta: U2FsdGVkX18AbL3bF+FKapYrdHyXT197EVQXvqpuUYzfFMoF/IQCLxZc2bh9Yf4nFGtY1lYAc4fYxvBJwCacAFN5qPIH8FZCmy8f6/wrl/4fd/tUALOLM5PVdLdM/V+omKb5kemFC9qP05pAEGLLzx4lFoJ79219adguoxZ6tSuDuMdNb59A5gBT9dCLLcmUU3ZKDXu65ajYErs33zkSCoYWUoiRQUs4DdcsqYkIzCxTJXaNAwe02bzQ55+fUKLJL6T4euyINdppGHjBGE0hV2cw/lc42DdtGtCzis8hb+3A8Pg7FXUy6LsWExPwRyu6rPBDn66AKwzqYCUhJEHrzq3qJcU6pb8or4T9w9rXOT0ak0xmPbp9tuO/ohAZElY4pEnjUSHprNJ/Hd2Ba3VYH6rjV+uZgYEN+Qarljf2tGDw9txbn/ldKSf1YEl4j97H87RhKW+9TMjiNvt2Kd1VTmHDOu2ZjoFpMF4VuL/EYlxRYgMXJ25aIYg9Ev+lVGViaNaQIdChCPCMBcjB7kL73U4w56OytmMOrCFJuKWYHIE85j+hU8mj4rGExZi1tmVFUkcLse9LYqCbxefb5UTVX2wypwmpbzrKE6tD6IMdtyWxL9hWTluQGwN8eW8bnIcaFH3sYQXF1BPLjCh+skqbrdMIBlUJnLrvmnauqsV4AkBrqfihF7pcxjY/9q/4vs7mYtVqeIULipe8rZbq91wTZrxTBWr6W+Z9CvZPnZENaqTL7lAYLTqny/P05NBMp24e2HOBRLNWe6CQ0Impsr30aU4DjTCqDxJLv9l8uzQfCNBFoNuvPBC4ZgBzPck8wgUwP7h05lJm1eW/E/yz0HjuMJJ/bJ9bP8wlYLBueOLJYJuomwWdJ1R8P1PohlQtlqeLXWZcBYX8RPX2l7HO0ET1OV6T7LjmYPbSQ2Okm6LAmF9Rz0XZbbT6fMghp7MbQsXynWdezB6vZHx7UJ/f30g vXIpbyIy ESggnRU647MTh8SYCBODDzOcDQ16ZiG/OhDGK1vzFHj0H4C2N2wFjoKphLcZdVFLSHQ9QnK7C0eE0CHt/oWgTAyp48iPiMFLsXyfnHVyaxnLiMi4mFYdvKeaIzWYtof6AtpO6EVv5SQSqc2WLgvuDRUl6cewA+LCan61FQvD9dnrD2vWi0cU/Wstpc9CDerkkW9j0o5d7WD/cPf2SgwisA2vqBOsgNyuIv5nJ9GJfAcBKfdb2X1P6ixjZqFWbVNr6aM9BBv4ajjolX4WpfaYXrc1qTDct0/A4S7/ec+k0g7YhqXO7cW/ZA5Qg8+kEq8Mbw9M8/CLjZJvTwi4Uu+i5s8GmO5r9ibPsukpUHgRr+ec6t8XvlgArp4OyEisov2oK5yNqL2xwTfmmtog= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 08:48:37PM +0300, Andy Shevchenko wrote: > On Thu, Jun 6, 2024 at 8:46 PM Kees Cook wrote: > > > > On Thu, Jun 06, 2024 at 08:35:13PM +0300, Andy Shevchenko wrote: > > > On Thu, Jun 6, 2024 at 6:56 PM Kees Cook wrote: > > > > On Thu, 06 Jun 2024 15:46:09 +0100, Jean-Philippe Brucker wrote: > > > > > > [...] > > > > > > > Applied to for-next/hardening, thanks! > > > > > > Btw, is it possible to get this for v6.10, so we may start enabling it > > > for others? > > > > Which others do you mean? > > There are a lot of users of kmemdup(x*y) which I want to convert > sooner than later to kmemdup_array(x,y). Ah-ha, I see what you mean. Well, I'm not sure we can do v6.10 for this because rc2 is behind us, and that's what most subsystems merge to. I can land the patch for rc3 so there will be no warnings in Linus's tree/-next, but conversions in subsystem trees will gain warnings, I think... -- Kees Cook