linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <tony.luck@intel.com>, <bp@alien8.de>
Cc: <nao.horiguchi@gmail.com>, <linmiaohe@huawei.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linux-edac@vger.kernel.org>
Subject: [PATCH v2 03/13] mm/memory-failure: add macro GET_PAGE_MAX_RETRY_NUM
Date: Thu, 6 Jun 2024 14:32:37 +0800	[thread overview]
Message-ID: <20240606063247.712575-4-linmiaohe@huawei.com> (raw)
In-Reply-To: <20240606063247.712575-1-linmiaohe@huawei.com>

Add helper macro GET_PAGE_MAX_RETRY_NUM to replace magic number 3.
No functional change intended.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-failure.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 4b9a9298d478..958b17a4b0f5 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1417,6 +1417,8 @@ static int __get_hwpoison_page(struct page *page, unsigned long flags)
 	return 0;
 }
 
+#define GET_PAGE_MAX_RETRY_NUM 3
+
 static int get_any_page(struct page *p, unsigned long flags)
 {
 	int ret = 0, pass = 0;
@@ -1431,12 +1433,12 @@ static int get_any_page(struct page *p, unsigned long flags)
 		if (!ret) {
 			if (page_count(p)) {
 				/* We raced with an allocation, retry. */
-				if (pass++ < 3)
+				if (pass++ < GET_PAGE_MAX_RETRY_NUM)
 					goto try_again;
 				ret = -EBUSY;
 			} else if (!PageHuge(p) && !is_free_buddy_page(p)) {
 				/* We raced with put_page, retry. */
-				if (pass++ < 3)
+				if (pass++ < GET_PAGE_MAX_RETRY_NUM)
 					goto try_again;
 				ret = -EIO;
 			}
@@ -1462,7 +1464,7 @@ static int get_any_page(struct page *p, unsigned long flags)
 		 * A page we cannot handle. Check whether we can turn
 		 * it into something we can handle.
 		 */
-		if (pass++ < 3) {
+		if (pass++ < GET_PAGE_MAX_RETRY_NUM) {
 			put_page(p);
 			shake_page(p);
 			count_increased = false;
-- 
2.33.0



  parent reply	other threads:[~2024-06-06  6:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  6:32 [PATCH v2 00/13] Some cleanups for memory-failure Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page() Miaohe Lin
2024-06-06  6:46   ` Kefeng Wang
2024-06-07  3:28     ` Miaohe Lin
2024-06-07  4:38       ` Kefeng Wang
2024-06-06  6:32 ` [PATCH v2 02/13] mm/memory-failure: remove MF_MSG_SLAB Miaohe Lin
2024-06-06  6:32 ` Miaohe Lin [this message]
2024-06-06  6:32 ` [PATCH v2 04/13] mm/memory-failure: save some page_folio() calls Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 05/13] mm/memory-failure: remove unneeded empty string Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 06/13] mm/memory-failure: remove confusing initialization to count Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 07/13] mm/memory-failure: simplify unneeded hwpoison_filter() variant Miaohe Lin
2024-06-06 17:15   ` kernel test robot
2024-06-07  3:30     ` Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 08/13] mm/memory-failure: use helper macro task_pid_nr() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 09/13] mm/memory-failure: remove obsolete comment in unpoison_memory() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h Miaohe Lin
2024-06-07  3:47   ` Matthew Wilcox
2024-06-07  7:00     ` Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 11/13] mm/memory-failure: fix comment of get_hwpoison_page() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 12/13] mm/memory-failure: remove obsolete comment in kill_proc() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 13/13] mm/memory-failure: correct comment in me_swapcache_dirty Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606063247.712575-4-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nao.horiguchi@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox