linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <tony.luck@intel.com>, <bp@alien8.de>
Cc: <nao.horiguchi@gmail.com>, <linmiaohe@huawei.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linux-edac@vger.kernel.org>
Subject: [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page()
Date: Thu, 6 Jun 2024 14:32:35 +0800	[thread overview]
Message-ID: <20240606063247.712575-2-linmiaohe@huawei.com> (raw)
In-Reply-To: <20240606063247.712575-1-linmiaohe@huawei.com>

Remove unneeded page != NULL check. pfn_to_page() won't return NULL.
No functional change intended.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-failure.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index f679b579d45d..2e6038c73119 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2120,14 +2120,10 @@ static inline unsigned long folio_free_raw_hwp(struct folio *folio, bool flag)
 /* Drop the extra refcount in case we come from madvise() */
 static void put_ref_page(unsigned long pfn, int flags)
 {
-	struct page *page;
-
 	if (!(flags & MF_COUNT_INCREASED))
 		return;
 
-	page = pfn_to_page(pfn);
-	if (page)
-		put_page(page);
+	put_page(pfn_to_page(pfn));
 }
 
 static int memory_failure_dev_pagemap(unsigned long pfn, int flags,
-- 
2.33.0



  reply	other threads:[~2024-06-06  6:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  6:32 [PATCH v2 00/13] Some cleanups for memory-failure Miaohe Lin
2024-06-06  6:32 ` Miaohe Lin [this message]
2024-06-06  6:46   ` [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page() Kefeng Wang
2024-06-07  3:28     ` Miaohe Lin
2024-06-07  4:38       ` Kefeng Wang
2024-06-06  6:32 ` [PATCH v2 02/13] mm/memory-failure: remove MF_MSG_SLAB Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 03/13] mm/memory-failure: add macro GET_PAGE_MAX_RETRY_NUM Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 04/13] mm/memory-failure: save some page_folio() calls Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 05/13] mm/memory-failure: remove unneeded empty string Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 06/13] mm/memory-failure: remove confusing initialization to count Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 07/13] mm/memory-failure: simplify unneeded hwpoison_filter() variant Miaohe Lin
2024-06-06 17:15   ` kernel test robot
2024-06-07  3:30     ` Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 08/13] mm/memory-failure: use helper macro task_pid_nr() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 09/13] mm/memory-failure: remove obsolete comment in unpoison_memory() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h Miaohe Lin
2024-06-07  3:47   ` Matthew Wilcox
2024-06-07  7:00     ` Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 11/13] mm/memory-failure: fix comment of get_hwpoison_page() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 12/13] mm/memory-failure: remove obsolete comment in kill_proc() Miaohe Lin
2024-06-06  6:32 ` [PATCH v2 13/13] mm/memory-failure: correct comment in me_swapcache_dirty Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606063247.712575-2-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nao.horiguchi@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox