From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27984C27C5E for ; Thu, 6 Jun 2024 01:56:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D2E6B00A0; Wed, 5 Jun 2024 21:56:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B9336B00A2; Wed, 5 Jun 2024 21:56:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833516B00A4; Wed, 5 Jun 2024 21:56:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 61EF56B00A0 for ; Wed, 5 Jun 2024 21:56:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD5588056B for ; Thu, 6 Jun 2024 01:56:51 +0000 (UTC) X-FDA: 82198800222.26.324C96B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 8D4851C0013 for ; Thu, 6 Jun 2024 01:56:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of "SRS0=WH+2=NI=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=WH+2=NI=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717639010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kM3H6qjHjtqDa6QRDjHXroOjmdbP867jiPB/MUHoLOk=; b=gxAiTdH79ROHZMKIPG401i3Dfa/fPXzAMtxf+YaB9Krk2ARJDEM2lknii0fr1najn3Wso3 +cQyRJtdqDIrtZ46HnjLXaYjccsnqLJqEtbldpywyL9PyJ8DlQIzrUxTe1ak2g86g04nyO JcSjgqXDpeONb1slSikPpJKdsavOOPA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of "SRS0=WH+2=NI=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=WH+2=NI=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717639010; a=rsa-sha256; cv=none; b=j2UjBfQ+aBaJHRIsjqPDley6JEt2Fs8sWm4GfSswa/9Kyuu4uCD5aBrLYhLq1nE9qrlqUP pUkyip102dB0jZH7IvxoVfWQG8qj/1SMSRLqaBipjaU7f68GT02JFJG+xnqQuQdBIK0uuY DvoaccbVSQA+nvmiY3COmdta9ODbGds= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E950CCE1A1D; Thu, 6 Jun 2024 01:50:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8074FC32786; Thu, 6 Jun 2024 01:48:34 +0000 (UTC) Date: Wed, 5 Jun 2024 21:48:37 -0400 From: Steven Rostedt To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH net-next v10 06/14] page_pool: convert to use netmem Message-ID: <20240605214837.44efcc6f@gandalf.local.home> In-Reply-To: <20240530201616.1316526-7-almasrymina@google.com> References: <20240530201616.1316526-1-almasrymina@google.com> <20240530201616.1316526-7-almasrymina@google.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8D4851C0013 X-Stat-Signature: znmmmekfjdxqkm9qwwfg9iysurr5uopw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717639009-717111 X-HE-Meta: U2FsdGVkX1+CYURVbjFYDw3TNzAyn/A6bUFCx1lhXNjjHYT0cs7PxS4FqhZ83pggFO95HiIrjGnqY9AjnZUvgMpvoAn3Pz66UgWVpEw5wAlsArZG9qK/LIchwEkANynzfvkONnPxNI++JuaDMDcDhmdN+sO4G4x15PMUgz3ujDSHjwIZRwRO0zjXVMWRzR0aHmBvQTVxL/KJSCquPpg2cvAqJ0SQuw85p3vZewhTIslXjYPpcttTf/FeK+i1R80PY7wFHCvYRvKUW1kOL+lGjbFMpxngCGM1Od1MTpLspijvjUuehUt2YfQ1Aefml3gtPESqkpigi+3IBWO5ZP8TM0znAEi3zWLYjZ7a+EnmlRtB2+bTGzEQQwN2aJImUm85nXZNvTfRBiHgslaBBjt8fwOofjJ9PG9vKtM1pqAyFG2OW1TMCSrQl2FTOxVJim5u8wMD5Hy9YlOzSMeXgib6eCiu0DCQTaY7MASlqGwwF5Y/5pLbc8EB67Xsm0thDhO/bF8PlsB4g09sEXnj5gVDfHRH5lnE1xp0Bmofcl6KaqTETPklQ6mnEmfiP2ihpGY0vMKfGeSVZ4pKmrzYRC+MKjVA5c8sUbcF33K4EGCG6kuv+DZxsS7icQZBefUCkPuJXO7FzfMp+Iu8cN9pga/fB2FPBMFgLW4pLQF7KfV1Fo2Gt6MjnSysFIPIWmRFBCco5FNJl7KqIMlYo0/hkclPM7eqG6iqlRKtm5ta6W5B/nsf+IIV/Dx9ctszoU7Z7ANUfws85Atl0rub5acDAlUk2Siym2DMizw/ty5RJXSxzIEKighAxByM5Bl6XvssMbZUkjaVLtre5cVALW7i7hgwyhh51huwstRlnQm9XpBe4AXUc+3WI8lpZqjhCwADUzpgq+I/3E9CvaOCSNXdKb6/BaVXFKayO9Manthl4aehMeeG/jR5X657vpnnkXbeHCU+gmIZEm8r2My1Ku9427Y K4+VMvNl 7+QEiZkb6iuoKrbDALyt2m9zPRsuXCQ8+M4nJ1obfI9EMyFO70yAUiw45JBEGA68vuHNnpS08RAZRaNvV2cISpRwBJ6vm0ixr0K/uIV0mSdBYK4bALVVeJgQEpqjGHabHam3WCFyFzxnxj3xQmgNraAmUrbL8wSGbPyib97GIaBr/mjN9LkCP+33yC/5cKPATpplD5aP8xJhUuR79aPS4wjUAEjOm18QY9bhEZ88b94gWw873MXRQ033iDMTm59Xq08jx0K+6Vw7exta7hGVCNIPYq3shalLtEwiea+upI64OCPREpnQgfZDfY4YjjxcIF0sry17+knDNBvpVYrfTJ2wODG1inAcBl1vcK6uJFSJZne9r19hE0a1RZOMBJ5Zndwu4WYan6h8P8Do= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 May 2024 20:16:05 +0000 Mina Almasry wrote: > @@ -42,51 +42,52 @@ TRACE_EVENT(page_pool_release, > TRACE_EVENT(page_pool_state_release, > > TP_PROTO(const struct page_pool *pool, > - const struct page *page, u32 release), > + netmem_ref netmem, u32 release), > > - TP_ARGS(pool, page, release), > + TP_ARGS(pool, netmem, release), > > TP_STRUCT__entry( > __field(const struct page_pool *, pool) > - __field(const struct page *, page) > + __field(netmem_ref, netmem) Why make this of type "netmem_ref" and not just "unsigned long"? > __field(u32, release) > __field(unsigned long, pfn) > ), > > TP_fast_assign( > __entry->pool = pool; > - __entry->page = page; > + __entry->netmem = netmem; You could have this be: __entry->netmem = (__force unsigned long)netmem; > __entry->release = release; > - __entry->pfn = page_to_pfn(page); > + __entry->pfn = netmem_to_pfn(netmem); > ), > > - TP_printk("page_pool=%p page=%p pfn=0x%lx release=%u", > - __entry->pool, __entry->page, __entry->pfn, __entry->release) > + TP_printk("page_pool=%p netmem=%lu pfn=0x%lx release=%u", > + __entry->pool, (__force unsigned long)__entry->netmem, And not have to expose the above text to user space (look at the format file it produces). It being of type "netmem_ref" in the ring buffer is useless. -- Steve > + __entry->pfn, __entry->release) > ); >