From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FEDDC27C52 for ; Wed, 5 Jun 2024 21:45:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2438A6B00A7; Wed, 5 Jun 2024 17:45:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F2EA6B00A9; Wed, 5 Jun 2024 17:45:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EBF76B00A7; Wed, 5 Jun 2024 17:45:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E607F6B00A7 for ; Wed, 5 Jun 2024 17:45:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 96271A0533 for ; Wed, 5 Jun 2024 21:45:09 +0000 (UTC) X-FDA: 82198165938.04.7C1A918 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id A78EE8000A for ; Wed, 5 Jun 2024 21:45:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FT8g+35C; spf=pass (imf30.hostedemail.com: domain of helgaas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717623907; a=rsa-sha256; cv=none; b=hhPJMvTPK64PPaWZgvjgbDwND+o8eYNKcfAAFwProUdtc9EgaW96nI9ozL/2JhhMXVvHr3 T/dHHxI29sstpZVoSC64sLIh2wdzA9RGYhuJVLuZCis+nMOYlH4fViPn/N+Wu+GNLJMmTJ /+XkgniRf5TVZ98tb9khO09GBPTn+PU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FT8g+35C; spf=pass (imf30.hostedemail.com: domain of helgaas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717623907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=h6rg02rGlOpqzn27ESrDineaZ/HZFC69Mfmm/QIdUZo=; b=29MvKztKhZ7BzEjA0tXWLqqlZQXSJqq8lQFVADh1iHryrVNIpqa9Vo69mUJ5ymMX+y/Zei JcrNS/IrYtBRbZbAYxIpruAmgB7lyZ8mvBbLvtqNjMT/Slwg7n0LG7PEk1u1WzRxX8aww4 ToYC8Qed4noZqWDpkeKgxqaOWuKuQnE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CE345CE19B9; Wed, 5 Jun 2024 21:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD9E4C2BD11; Wed, 5 Jun 2024 21:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717623902; bh=CVFMj08n3jx14fA4p4rVO8oNP2YJkFvLHwp+4lE/nJk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FT8g+35CiFMlqdW45S1xvzcyh6rKx+CgS1WwjYzIADHjLKkvfngN74AXw7nrcOHNp W/jTuM7rBD2tO/ss+up8NPfPp1AZQpaG6whs2KMNyRsFLFZoMjqPTlGQ8t4hrwJeZS E3EtLD1WTLPWUouYrWzY9FwX38uX5LzwsPYcp/IX8m8T3Iq98c2VnukCiS/L/hYZu0 v2nuSygn69PZ4lUFigqffS3vhHrMngjxVJ2n5iSti6Z547E4IC7e5FBpyPYiW6XEFn 7jEBrGrhmjFYUkOwaoHkYJ1FLJD67eL3hatO1/UBa1dmULLixBRhE9em/5wFOtPZ4f ocIB2a3M5WPmw== Date: Wed, 5 Jun 2024 16:45:00 -0500 From: Bjorn Helgaas To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Greg Kroah-Hartman , Tejun Heo , "Rafael J. Wysocki" , Andrew Morton , Mike Marciniszyn , Michael Guralnik , Dan Williams , Ard Biesheuvel , Valentine Sinitsyn , Lukas Wunner Subject: Re: [PATCH 3/6] PCI/P2PDMA: create VMA without page_mkwrite() operator Message-ID: <20240605214500.GA781636@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605192934.742369-4-martin.oliveira@eideticom.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A78EE8000A X-Stat-Signature: mf968iaw7k4dhhgwchps7i369t1xsz1i X-HE-Tag: 1717623906-639185 X-HE-Meta: U2FsdGVkX1/4Vsd+TZjsny6rN0t2J/JmDUYmUd3A72uZEWz95lNKeVhqiNUqWfBW2c4Xv8XwuGHgEJQp4UVP69SlHplB6hyQRlDT2euacjHT98NNl2yb9JUMG6ij4OgllGeCerwk0hA9QvO9Dm+aA3Nq+9KCMUazmBFpRJSuDdKIrH/C/NMuatqhToT9Jv2Jnv9fIrLW83qK/45K/LGQioMVSeSgY4+U+ElbEDbZZxIUuAnekrUoI1s/vTx9cjgez0yN66fTtXhS1LD00XGo9ZiSvksw60h7PzbwOpkuL2iX0uP3mzsiOQbETfeNiMXvXBIa98rxf6/I1TskD+QkI59jJtMF5L9WRSeSXeohK3+oaNJ5P05EdLDXAdV1BglkHzvKHsK5BnZtHsx5PoqAG/0O5OB1n40s2A/W53ZEquFDpRmkTGkO1A/neclKU2r8la9V1KTXltD92WD1EhI4Xu9FNChKd4rPoTe+LSv7CbrrIV9v1d8WRUAmMZqCIu/ZlmY3PPno+v975/3Q6ovXwEXARaYBF1iBosodF7XxqYJG+giCeP/DGj9YSLS8kFO+Y5j6X90cyj9x4phbTw7twRQ6zWufefAUiZOuxO0rxifK1daW7hTKPZGq+qK291qexQt+ki2vQ0IXWJkcmypWDlyssMZb8oPTE1K2//HOSV8Fg5rZWcyBx937W0+eIYar2Xx8ZADI+cB/BCqm5oUzQPqzPD5OhFFuisT/1EJ5oPTl3OwqYaU8PoDOAz0wxadFAR9ujZMG4w1emjU9SBkQofmr9USBTc79ZXAXoYxGXxv1Bl2QwZHiAwVV2cr/hedONfsIF/m+lzfyCUr498YGyO9r2MpDt5JXv4GEcyp6EcW7XFfC1ynCUewOzsYKE6W+vLHo0UdepMcvGdahAiYWd0DTsBU4DstGF+xvRsYxygwjSiwbjkdrxb3faVShnfb9ANKJvZOd2Ikhyk42Vgy BO1QX+iF DXleTI05gNWNdY3Ts9MmLPxANT8klVp9CimTbdchh2pJ5g1B7PWwJGea55yHeVU9qpDDpzS/wWmnRGWXiqrCM3odaI6jxoc6LCKiAPg86tFoEDUeaRaG1OTeH87mYtfs90UmBUIdGyS4Cpjq5nyZUsX9XO4kMGkq5M8l+HH3eCqD9+9Kkk3m+hojjXDlXswdxzdanyufzXoHMX3ODH1rRWXxpV06V7guhn8dJDuteG5Pjvkl0PeVLFm+7uR7ND8BGoilOYVXH/rAZzXbVqbBLkdg5C5ehzIVUh6CL1fP7HXLyqfYMBFmy0DdUKOtHwAQjKsy9PczyCHM8SsXiA+mdxh6VICUPSeJxOl+S03+PNcgpET3Ge61FypTA/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 01:29:31PM -0600, Martin Oliveira wrote: > The P2PDMA code does not need (or want) a page_mkwrite() operator on its > VMA. > > Furthermore, having the page_mkwrite() operator causes > writable_file_mapping_allowed() to fail due to > vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for > enabling P2PDMA with FOLL_LONGTERM use cases. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira Fine with me, but please s/create/Create/ in the subject to match history of the file. Acked-by: Bjorn Helgaas > --- > drivers/pci/p2pdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index 4f47a13cb500..ac07053abfea 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -171,6 +171,7 @@ static struct bin_attribute p2pmem_alloc_attr = { > * to be very large. > */ > .size = SZ_1T, > + .mmap_allocates = true, > }; > > static struct attribute *p2pmem_attrs[] = { > -- > 2.34.1 >