From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126DAC25B76 for ; Wed, 5 Jun 2024 13:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38AE76B0082; Wed, 5 Jun 2024 09:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33AC46B0083; Wed, 5 Jun 2024 09:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DB176B0085; Wed, 5 Jun 2024 09:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 026EA6B0082 for ; Wed, 5 Jun 2024 09:25:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8C7B9121397 for ; Wed, 5 Jun 2024 13:25:00 +0000 (UTC) X-FDA: 82196905560.26.7BB1504 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf13.hostedemail.com (Postfix) with ESMTP id 778CD2001B for ; Wed, 5 Jun 2024 13:24:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=Hiv5ietR; spf=pass (imf13.hostedemail.com: domain of qyousef@layalina.io designates 209.85.221.50 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717593898; a=rsa-sha256; cv=none; b=fZilt5nwV7hVXWlpb9OZnECKYG0RP2U0UpaA1jeCw/kPMtHZlNBV4qHYfbMzV6Awwh12RO ANTF65BMp5R92DKMYuu1HdTkKahQCbJGbR5xSRMDlO3HrC+dKk/o5KNhwN+uKui3RIhiYc IsMFQ9qDY09rSRI8q42tJo8JLNYzZV8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=Hiv5ietR; spf=pass (imf13.hostedemail.com: domain of qyousef@layalina.io designates 209.85.221.50 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717593898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xq9gIboeIP0lLm6D7yyfMwZHyoZ/EmvE2lx3bVnUJH8=; b=L1xuCAZE7Js8G7bxis8uip8wZVPTWRig7AQRTuGIswraJL5WglMUtP9ebVnd7CCCO5p+3T xASHMRQgfk2MEkkc6G6yeCr4R0tauaqmZJ3uhD0loz6MyoG9saehipRE2Aj4DMCgUpHKLN hKnfINYLKh0k2CQA9vjkzf+tmq+RAbU= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-35e5c6600f0so3049270f8f.3 for ; Wed, 05 Jun 2024 06:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1717593897; x=1718198697; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xq9gIboeIP0lLm6D7yyfMwZHyoZ/EmvE2lx3bVnUJH8=; b=Hiv5ietRZNkHMAumPqsxozu0xfMznc8FyJN2GU8I19Hb63JEd9PSpYcWOx9WFAvqi/ TedcjqH+fCCo2KIRgBLrS3XUWDaVRUy5ITOjBP0QjclMq0BEEcuOVNiQc6gQl4hun2fo HtLx1jd+cxHn/ibtN1l4NVu/NDfZO1xfVssUPKJfUNkJo9PuLDTYAtYdbJrD4uPUTLQK aynyZhdFsqS2G/gs2xNorNREOk/cQu6L93hPUkXkZ0zgpz40rLXMYF9ellunAJjOC4l5 DbPUerL8MacGHZXETQVTnUTeI98fGbFSQf+UpCL4hGoq+LjFPMMS36BSNKtAHSmehFqt pyKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717593897; x=1718198697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xq9gIboeIP0lLm6D7yyfMwZHyoZ/EmvE2lx3bVnUJH8=; b=HnH420QaA+si3Yg5Oe2aFjWVaQTY1N87uHMpMQvWtme3AlUAKRB33+cuR1svHVa7fj UKzQvUzAEXuxiXL5O9jyP0lSleBdBwHMe6V+JW+YWq7fvFvK1SYHj/UNxf2TkRGl8Nlp iQJxreq8wMxBpZA2QDzJhQWuoEX/Iub+kZ787eg2MWSs2V8rwAXJ6oO61h2Fb8va/Xro AYyDi3VUJoJhy/U92kiAdm+paaKeLAstpm+P+dE0o51jzzA6Yw8QHuXatn5RDoKx2deu G8yOwFErqjRQ4XV5o5vodggBORubvvrdeOZJI9Envo00yyttgKh8xkB2/LALmU46n2vN kVuQ== X-Forwarded-Encrypted: i=1; AJvYcCUBZPRxAwWaUX4O/imxDpNtKlkmcGupMOkigxSWGbcXom0yTFdE8NnC3J1JA9EGNdVFiRhS0PQb6cWulTwyYQosZvc= X-Gm-Message-State: AOJu0YwDNgBPh6LAioZ5NJWv2kjRspOLBeQRGms6zRv+CU685PZ/ehE1 erfaeESbqxt4vPb08xucThkHBFiws3WRfDkraAsxPn+reKFUb/yVvNTHCyks6ek= X-Google-Smtp-Source: AGHT+IEDSLWBHNvCjuH/hvXgGFQjAPtCtaPrhm+JcG8FGeW9Ms1o+F8Qs/onHstEDi9CUXB1JupgJg== X-Received: by 2002:a05:6000:1f8c:b0:35e:5b61:23b8 with SMTP id ffacd0b85a97d-35e85feecf2mr2435818f8f.34.1717593896475; Wed, 05 Jun 2024 06:24:56 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c0f7esm14621490f8f.22.2024.06.05.06.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 06:24:56 -0700 (PDT) Date: Wed, 5 Jun 2024 14:24:54 +0100 From: Qais Yousef To: Sebastian Andrzej Siewior Cc: Daniel Bristot de Oliveira , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240605132454.cjo4sjtybaeyeuze@airbuntu> References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240605093246.4h0kCR67@linutronix.de> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 778CD2001B X-Stat-Signature: xojuoi6iycgtz5qbr4ngb4taswztbu66 X-HE-Tag: 1717593898-602578 X-HE-Meta: U2FsdGVkX1/YWoEd/Ekudz6JK3WQVTuId62162iKaTaOhwADyh0IordofF0wMtnsf10LjdLulAQltjMDbLKJagf17Tl5DLfCc3/tfeHj1FF0TSjjKsZE3T2K8EPzuehpv5TpBNRj2pNxQhuVUnsEwvFrt0aiEPvRyFJU3vyXWICdshzhrtMPEp8pryNhDk85N1QJU66PPMmKosztLmw1W4L8yF611FeVWPEWSo9F3Glmad+o08DnMcZWNSVNBar7HJ/UvXN4jG1ip/CNUozvJDPLG3IiwxD3wnzv2c4PlGUdYiYFW4D0H2zrhku+a7VF0rWrFRhgigAYUlAPIIj0hUcp6+r1QGadmFH7sK1X+Nn7SKp4pPBmygcdQ/YOdjzNu7BhRHFHWe1Xfpp83MywP96eph3S38SuD43flpfBoCjG0l+fBU9sbRP2i471d8DNchXhSWNKzP2QJO9dvAkxUKsDVN3McPHlhDXRMZmnKO/p/5UNmdpvUrt/bdYTTnmU/teaIbW7CVzi8egulcOq9o2DXph+KU2Zkud18PXrudYHHtEXkvpRJuIgYC8EnJQMRc+cUyk7tpaLr7jb2NPBwmZYIH0hpBDTLD3km9b2yXLs7AUzFvSIG3G2nyi/OpG2NpfFsApM2rIp3zioOA/0Ua/HtQ0z5wjKGhMgfh0gpgLlFDNWdAQFUfe+OG0QGUQthVRei9geBz8GrYiaYiHgq7idVHGtM/irRMUNx4XQsIWKqwcmIxDE+eleLl7vgWCNW8uGfiWd46JgIQm/fY/CXZJ0mNyUX6SfsAKn8DMD7PmRaJbdAhSD5D1dMhmxoomZ8Hd+dB0L7rH0VFffHPtgOjHZZJYMYTAtqYxUFW9paeBr8JyFslPB3d7w3+ZhqJyrPrgBzy0XIo+mdRzsS9U2IBNDzXqgTrxR/eenAjv+DRYZ0hAUA4JO1QTVY+nbCfUBkrum9brXrbo24Eyw/ak AXz4hQi4 HnxW4SSRcqvOSLW/7WpMIzUZE5OA63XL8cNyMTJsC7CL/mjnsrbMIR763r4R/PkL4A5n7pAA6msC+LfanhZMmf9f2ZhhR44s3s5hhxiSLmJOccRuHEi+rvLQX1tJWLox/pm4/aJI9xhYnd/XjMZbMJTPGl798mo157l0Dy4eh6s0UFdeU+ey9zYIutRdBjxs53OOHEhHj2e2NEICUnEcF2urix6EA2Kz4++eMu0bZgDljUCXDEclo59OCWHHQ6uWlNCy9blZ24KMKndn9N7QFZzu89FyUo4Nbl1hwKGDCjAAEI7q1EVrvsTBOxD1JHqHlr2QczBenkrdmu6yi/FjiLhdajfBCE+1obf+OOAuN+At/+GN5LFybZGQyPhudw1E4ERPubjpQFRiEkR5RpSQplBAr01rdO0x5cBlIdsO1brq+4v0Gf4RMs6XKRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000146, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/05/24 11:32, Sebastian Andrzej Siewior wrote: > On 2024-06-04 17:57:46 [+0200], Daniel Bristot de Oliveira wrote: > > On 6/4/24 16:42, Qais Yousef wrote: > > > - (wakeup_rt && !dl_task(p) && !rt_task(p)) || > > > + (wakeup_rt && !realtime_task(p)) || > > > > I do not like bikeshedding, and no hard feelings... No hard feelings :-) > > > > But rt is a shortened version of realtime, and so it is making *it less* > > clear that we also have DL here. > > Can SCHED_DL be considered a real-time scheduling class as in opposite > to SCHED_BATCH for instance? Due to its requirements it fits for a real > time scheduling class, right? > And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. Yeah I think the usage of realtime to cover both makes sense. I followed your precedence with task_is_realtime(). Anyway. If people really find this confusing, what would make sense is to split them and ask users to call rt_task() and dl_task() explicitly without this wrapper. I personally like it better with the wrapper. But happy to follow the crowd.