From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F6DC27C50 for ; Tue, 4 Jun 2024 22:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 936B26B0092; Tue, 4 Jun 2024 18:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917256B0095; Tue, 4 Jun 2024 18:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FCA16B0098; Tue, 4 Jun 2024 18:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 638EF6B0092 for ; Tue, 4 Jun 2024 18:45:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0D6671C1470 for ; Tue, 4 Jun 2024 22:45:32 +0000 (UTC) X-FDA: 82194689304.14.C17EA96 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf24.hostedemail.com (Postfix) with ESMTP id B8222180003 for ; Tue, 4 Jun 2024 22:45:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GmpPpHt+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717541129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RB+1RX7GycBUS8wBJJvf/2snWUy4IzCI14XzKhbN+Ak=; b=UL2W3Szw+a+THIX2ihUkf0e8g12scEB+CMadPDXT0pf0uDuT/fs+9LLLT2LLimLGRF5lK4 ASJpJEc6Bh/JUoPylr1mGxRPF+wLC2zRWGxOobTdBzP69TtDboLKe7zFuRpQvltSpU/bJJ 7shvRI48HGFm5OavezDywYrI6AMSY1c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GmpPpHt+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717541129; a=rsa-sha256; cv=none; b=jkI/Qg9EP1A0cu4MuvxdQ/If7GLDL5/vfz3cqEgtlZc7exNSb+CzG+ONugNv809F1nMeYs L1PmTkdmpAwW13BWlZJ+2i9abzEGkMiEcOmtwrO726TnIanUB9QB4UwyZHfJZeEXEUjhc/ ImpB066WkfvaOrdglDRsVAXYfbObTHk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717541129; x=1749077129; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mXAGe3YINODB6h+MbBkIPYf536ptCXDV0Tp3NMe+dO8=; b=GmpPpHt++Vzi+YtM4BVjd/+/fxiJ0o7Dj8EggLEGmDM+2fEias/ZSH2l yFq5osGhyF27SV/FJowszRhtaj2kt3YXwuWVXTs/SpwoY3z68mU5vwzKC wHKan7G20Auq6BO0XMiLojGsaeLBTLWVuy5tbzvGKf1XNHjUzCusLPYoZ 8BNTl0lGliI4IsBy9+sGDNAzNik/truuzeXGPvxbg4qjGo+RaAUs84diG l2SYjkbAV/4ruG/DWHPg9RvP6XoYy6WZgXv39WHBDdrCNfweo2MrvY4BD v5Moj914ckA46OGcPHRzGnh2ES80D991ls2UeUEtRF4XvhxsXjZpiLx2q g==; X-CSE-ConnectionGUID: U6d5X+shQhKlxe10U6kIhg== X-CSE-MsgGUID: YhC+RidmRXOoHd2OC5O3YQ== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="14253160" X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="14253160" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 15:45:27 -0700 X-CSE-ConnectionGUID: 31zVMKuHSCKIFD6pq35g3A== X-CSE-MsgGUID: cYrlB2C1T329o8h4VgUFIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="60576089" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by fmviesa002.fm.intel.com with ESMTP; 04 Jun 2024 15:45:24 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sEcuA-0000dH-12; Tue, 04 Jun 2024 22:45:22 +0000 Date: Wed, 5 Jun 2024 06:44:54 +0800 From: kernel test robot To: Sidhartha Kumar , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, zhangpeng.00@bytedance.com, willy@infradead.org, Sidhartha Kumar Subject: Re: [PATCH 12/18] maple_tree: convert mas_insert() to preallocate nodes Message-ID: <202406050614.NwHTjXFD-lkp@intel.com> References: <20240604174145.563900-13-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604174145.563900-13-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: B8222180003 X-Stat-Signature: r8m4angzxw61fd49orph5ftbwnrmza4j X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717541128-873215 X-HE-Meta: U2FsdGVkX18y+Aw5K+8GLwv1E8MBq5bP7QUqG2Ze2ByLpjlUrhd5vekGiB9gn+17d0+stKVNi6F3cVeu7Yi3J7rW0io5ztchlQaeNN0KtNnYJfg7Q7I6BUC75lFsg86x3ABslPZ/kym6pCNa/CUNmH/2fRCp8SKHDshEjJ59Gedi5p2j+ELsgWQk3IaZtC2+ovqwiczLvJMTfKffPHJw43WahsbYCHLhmSg0LwvZQ2WaISAxeNbAm338jYCKpqWok5UuyLJwCaOD++X7X4gl++PzoyTea/pkfS78INzfR2T8oCLCIzw7p49z5ijPtJjtC+XHcxlfu09tco95KIfNj7axsXwQLVWQIPLX8iFaiH/Ujk/SrUBBjIQ8EYRYS3z1vVUqc+S/83jgE8c9pte+c7q+dg5MXJZ1HzPvFC/6fUj6njqznQQwpRFYYrFIMnF8KyMrnDaOa7ysTKFdHQ2Fy2pymPkZ1V/0QNR2WKypD9TU+x1LwfY/JFCE74TIWpj+AuKajz/pTYyjj5j+4RtabsYUrW/Po0Io5EeUrN5liRzTKkL5/4J4dybeQd+fZizkOTJCs0guMFUx98yK7Smyy/YjM0mMHyOC5w87Qn0mm57b9CxmiY/7YqWumzcC9QybpxESCMlZa7Gbz2BGV5yaczr1u/248h8mV0cAjkxMB3JKDhKp03P5/AaiOgiui6ZUm4CBVuE+DPeNtWLoZpGcDhPnOnfnvJVd4//GNjJuMS0BnQZ9hFmqhWTtv7/PXJ/YE6uM0Vis5jCoRhemZ87GZAavZ0d07Pt6eP/0VQtfPs80BaYM3p2TBGkoNdeQnKCcxlYMmYtuuKmfLvurWb5uar/ByJ7DMVF9DdA8gmgr2z10ykK9M5yGXgpfRHCmF46TKHEpoOjcPtCKDAA0FeFwSfJqIWLtXdhTaA7drQZ3RvSclhPtTEQK8FHRNCVs+vnzcYKB8Oj3uYrDlFRZ4eW ChyNQFmf 8gRILNrxGi7ZRcZEpfXku7Cm68DaPfegItsV4yV6jzCDkskDloXLqRHo2l4Z4eWx7ui96DMOqtAHFGF9TbDCETza0qUp9nAJobPmziQsTxS6VzLvYaioFGhbN8sDJsavOA9I7YiuDsQePMysBTREQcP6tcRLw84aOLa727qVRpxjKeP0WJq1UHmafXCBfjEt1rmbu1JA+ohRlyJKeVcC7z7Ev6zW8Oi4WX7C9lDw7aBijB82Ml5xGUp/kWfKFI2PKjFzMIJqAlhipv9sqqb0L8/YVQlPpZgp6CwQjQujNifGWsxP7+GQTTDhNt3L+lVkAPErMk/Wuc9u/NXjIEO3mrY/KF1MsV/exerCEOBFMPpwDx8R6deo8fgN7xdwJhYCiyaVWJSd/DGt62PLjBtOz5sniN7kg/WonskV9yRfKntd8KcB4I1MoyAnNJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Sidhartha, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on linus/master v6.10-rc2 next-20240604] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sidhartha-Kumar/maple_tree-introduce-store_type-enum/20240605-014633 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20240604174145.563900-13-sidhartha.kumar%40oracle.com patch subject: [PATCH 12/18] maple_tree: convert mas_insert() to preallocate nodes config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240605/202406050614.NwHTjXFD-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050614.NwHTjXFD-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202406050614.NwHTjXFD-lkp@intel.com/ All warnings (new ones prefixed by >>): lib/maple_tree.c:4304: warning: Function parameter or struct member 'entry' not described in 'mas_prealloc_calc' >> lib/maple_tree.c:4449: warning: Function parameter or struct member 'gfp' not described in 'mas_insert' vim +4449 lib/maple_tree.c e0c5446b52f6a9 Sidhartha Kumar 2024-06-04 4439 54a611b605901c Liam R. Howlett 2022-09-06 4440 /** 54a611b605901c Liam R. Howlett 2022-09-06 4441 * mas_insert() - Internal call to insert a value 54a611b605901c Liam R. Howlett 2022-09-06 4442 * @mas: The maple state 54a611b605901c Liam R. Howlett 2022-09-06 4443 * @entry: The entry to store 54a611b605901c Liam R. Howlett 2022-09-06 4444 * 54a611b605901c Liam R. Howlett 2022-09-06 4445 * Return: %NULL or the contents that already exists at the requested index 54a611b605901c Liam R. Howlett 2022-09-06 4446 * otherwise. The maple state needs to be checked for error conditions. 54a611b605901c Liam R. Howlett 2022-09-06 4447 */ 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4448 static inline void *mas_insert(struct ma_state *mas, void *entry, gfp_t gfp) 54a611b605901c Liam R. Howlett 2022-09-06 @4449 { 54a611b605901c Liam R. Howlett 2022-09-06 4450 MA_WR_STATE(wr_mas, mas, entry); 54a611b605901c Liam R. Howlett 2022-09-06 4451 54a611b605901c Liam R. Howlett 2022-09-06 4452 /* 54a611b605901c Liam R. Howlett 2022-09-06 4453 * Inserting a new range inserts either 0, 1, or 2 pivots within the 54a611b605901c Liam R. Howlett 2022-09-06 4454 * tree. If the insert fits exactly into an existing gap with a value 54a611b605901c Liam R. Howlett 2022-09-06 4455 * of NULL, then the slot only needs to be written with the new value. 54a611b605901c Liam R. Howlett 2022-09-06 4456 * If the range being inserted is adjacent to another range, then only a 54a611b605901c Liam R. Howlett 2022-09-06 4457 * single pivot needs to be inserted (as well as writing the entry). If 54a611b605901c Liam R. Howlett 2022-09-06 4458 * the new range is within a gap but does not touch any other ranges, 54a611b605901c Liam R. Howlett 2022-09-06 4459 * then two pivots need to be inserted: the start - 1, and the end. As 54a611b605901c Liam R. Howlett 2022-09-06 4460 * usual, the entry must be written. Most operations require a new node 54a611b605901c Liam R. Howlett 2022-09-06 4461 * to be allocated and replace an existing node to ensure RCU safety, 54a611b605901c Liam R. Howlett 2022-09-06 4462 * when in RCU mode. The exception to requiring a newly allocated node 54a611b605901c Liam R. Howlett 2022-09-06 4463 * is when inserting at the end of a node (appending). When done 54a611b605901c Liam R. Howlett 2022-09-06 4464 * carefully, appending can reuse the node in place. 54a611b605901c Liam R. Howlett 2022-09-06 4465 */ 54a611b605901c Liam R. Howlett 2022-09-06 4466 wr_mas.content = mas_start(mas); 54a611b605901c Liam R. Howlett 2022-09-06 4467 if (wr_mas.content) 54a611b605901c Liam R. Howlett 2022-09-06 4468 goto exists; 54a611b605901c Liam R. Howlett 2022-09-06 4469 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4470 mas_wr_preallocate(&wr_mas, entry, gfp); 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4471 if (mas_is_err(mas)) 54a611b605901c Liam R. Howlett 2022-09-06 4472 return NULL; 54a611b605901c Liam R. Howlett 2022-09-06 4473 54a611b605901c Liam R. Howlett 2022-09-06 4474 /* spanning writes always overwrite something */ 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4475 if (mas->store_type == wr_spanning_store) 54a611b605901c Liam R. Howlett 2022-09-06 4476 goto exists; 54a611b605901c Liam R. Howlett 2022-09-06 4477 54a611b605901c Liam R. Howlett 2022-09-06 4478 /* At this point, we are at the leaf node that needs to be altered. */ 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4479 if (mas->store_type != wr_new_root && mas->store_type != wr_store_root) { 54a611b605901c Liam R. Howlett 2022-09-06 4480 wr_mas.offset_end = mas->offset; 54a611b605901c Liam R. Howlett 2022-09-06 4481 wr_mas.end_piv = wr_mas.r_max; 54a611b605901c Liam R. Howlett 2022-09-06 4482 54a611b605901c Liam R. Howlett 2022-09-06 4483 if (wr_mas.content || (mas->last > wr_mas.r_max)) 54a611b605901c Liam R. Howlett 2022-09-06 4484 goto exists; 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4485 } 54a611b605901c Liam R. Howlett 2022-09-06 4486 9d36d13535c7c8 Sidhartha Kumar 2024-06-04 4487 mas_wr_store_entry(&wr_mas); 54a611b605901c Liam R. Howlett 2022-09-06 4488 return wr_mas.content; 54a611b605901c Liam R. Howlett 2022-09-06 4489 54a611b605901c Liam R. Howlett 2022-09-06 4490 exists: 54a611b605901c Liam R. Howlett 2022-09-06 4491 mas_set_err(mas, -EEXIST); 54a611b605901c Liam R. Howlett 2022-09-06 4492 return wr_mas.content; 54a611b605901c Liam R. Howlett 2022-09-06 4493 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki