From: kernel test robot <lkp@intel.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-mm@kvack.org, akpm@linux-foundation.org,
liam.howlett@oracle.com, zhangpeng.00@bytedance.com,
willy@infradead.org, Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH 11/18] maple_tree: use store type in mas_wr_store_entry()
Date: Wed, 5 Jun 2024 06:02:33 +0800 [thread overview]
Message-ID: <202406050515.BP3o0Meg-lkp@intel.com> (raw)
In-Reply-To: <20240604174145.563900-12-sidhartha.kumar@oracle.com>
Hi Sidhartha,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-nonmm-unstable]
[also build test WARNING on linus/master v6.10-rc2 next-20240604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sidhartha-Kumar/maple_tree-introduce-store_type-enum/20240605-014633
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
patch link: https://lore.kernel.org/r/20240604174145.563900-12-sidhartha.kumar%40oracle.com
patch subject: [PATCH 11/18] maple_tree: use store type in mas_wr_store_entry()
config: um-allnoconfig (https://download.01.org/0day-ci/archive/20240605/202406050515.BP3o0Meg-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050515.BP3o0Meg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406050515.BP3o0Meg-lkp@intel.com/
All warnings (new ones prefixed by >>):
lib/maple_tree.c:351:21: warning: unused function 'mte_set_full' [-Wunused-function]
351 | static inline void *mte_set_full(const struct maple_enode *node)
| ^~~~~~~~~~~~
lib/maple_tree.c:356:21: warning: unused function 'mte_clear_full' [-Wunused-function]
356 | static inline void *mte_clear_full(const struct maple_enode *node)
| ^~~~~~~~~~~~~~
lib/maple_tree.c:361:20: warning: unused function 'mte_has_null' [-Wunused-function]
361 | static inline bool mte_has_null(const struct maple_enode *node)
| ^~~~~~~~~~~~
>> lib/maple_tree.c:4206:21: warning: stack frame size (1032) exceeds limit (1024) in 'mas_wr_store_entry' [-Wframe-larger-than]
4206 | static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas)
| ^
lib/maple_tree.c:4151:13: warning: stack frame size (1048) exceeds limit (1024) in 'mas_wr_bnode' [-Wframe-larger-than]
4151 | static void mas_wr_bnode(struct ma_wr_state *wr_mas)
| ^
5 warnings generated.
vim +/mas_wr_store_entry +4206 lib/maple_tree.c
54a611b605901c Liam R. Howlett 2022-09-06 4198
54a611b605901c Liam R. Howlett 2022-09-06 4199 /*
54a611b605901c Liam R. Howlett 2022-09-06 4200 * mas_wr_store_entry() - Internal call to store a value
54a611b605901c Liam R. Howlett 2022-09-06 4201 * @mas: The maple state
54a611b605901c Liam R. Howlett 2022-09-06 4202 * @entry: The entry to store.
54a611b605901c Liam R. Howlett 2022-09-06 4203 *
54a611b605901c Liam R. Howlett 2022-09-06 4204 * Return: The contents that was stored at the index.
54a611b605901c Liam R. Howlett 2022-09-06 4205 */
54a611b605901c Liam R. Howlett 2022-09-06 @4206 static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas)
54a611b605901c Liam R. Howlett 2022-09-06 4207 {
54a611b605901c Liam R. Howlett 2022-09-06 4208 struct ma_state *mas = wr_mas->mas;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4209 unsigned char new_end = mas_wr_new_end(wr_mas);
54a611b605901c Liam R. Howlett 2022-09-06 4210
7ad45cca258711 Sidhartha Kumar 2024-06-04 4211 switch (mas->store_type) {
7ad45cca258711 Sidhartha Kumar 2024-06-04 4212 case wr_invalid:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4213 MT_BUG_ON(mas->tree, 1);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4214 return NULL;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4215 case wr_new_root:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4216 mas_new_root(mas, wr_mas->entry);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4217 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4218 case wr_store_root:
54a611b605901c Liam R. Howlett 2022-09-06 4219 mas_store_root(mas, wr_mas->entry);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4220 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4221 case wr_exact_fit:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4222 rcu_assign_pointer(wr_mas->slots[mas->offset], wr_mas->entry);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4223 if (!!wr_mas->entry ^ !!wr_mas->content)
7ad45cca258711 Sidhartha Kumar 2024-06-04 4224 mas_update_gap(mas);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4225 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4226 case wr_append:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4227 mas_wr_append(wr_mas, new_end);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4228 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4229 case wr_slot_store:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4230 mas_wr_slot_store(wr_mas);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4231 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4232 case wr_node_store:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4233 mas_wr_node_store(wr_mas, new_end);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4234 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4235 case wr_spanning_store:
54a611b605901c Liam R. Howlett 2022-09-06 4236 mas_wr_spanning_store(wr_mas);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4237 break;
7ad45cca258711 Sidhartha Kumar 2024-06-04 4238 case wr_split_store:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4239 case wr_rebalance:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4240 case wr_bnode:
7ad45cca258711 Sidhartha Kumar 2024-06-04 4241 mas_wr_bnode(wr_mas);
7ad45cca258711 Sidhartha Kumar 2024-06-04 4242 break;
54a611b605901c Liam R. Howlett 2022-09-06 4243 }
54a611b605901c Liam R. Howlett 2022-09-06 4244
54a611b605901c Liam R. Howlett 2022-09-06 4245 return wr_mas->content;
54a611b605901c Liam R. Howlett 2022-09-06 4246 }
54a611b605901c Liam R. Howlett 2022-09-06 4247
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-04 22:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 17:41 [PATCH 00/18] Introduce a store type enum for the Maple tree Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 01/18] maple_tree: introduce store_type enum Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 02/18] maple_tree: introduce mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 03/18] maple_tree: move up mas_wr_store_setup() and mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 04/18] maple_tree: introduce mas_wr_store_type() Sidhartha Kumar
2024-06-04 19:07 ` Liam R. Howlett
2024-06-06 2:15 ` Sidhartha Kumar
2024-06-04 21:09 ` kernel test robot
2024-06-04 17:41 ` [PATCH 05/18] maple_tree: set store type in mas_store_prealloc() Sidhartha Kumar
2024-06-04 19:27 ` Liam R. Howlett
2024-06-04 17:41 ` [PATCH 06/18] maple_tree: remove mas_destroy() from mas_nomem() Sidhartha Kumar
2024-06-04 19:21 ` Liam R. Howlett
2024-06-04 17:41 ` [PATCH 07/18] maple_tree: use mas_store_gfp() in mas_erase() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 08/18] maple_tree: set write store type in mas_store() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 09/18] maple_tree: use mas_store_gfp() in mtree_store_range() Sidhartha Kumar
2024-06-04 19:24 ` Liam R. Howlett
2024-06-04 17:41 ` [PATCH 10/18] maple_tree: print store type in mas_dump() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 11/18] maple_tree: use store type in mas_wr_store_entry() Sidhartha Kumar
2024-06-04 22:02 ` kernel test robot [this message]
2024-06-04 17:41 ` [PATCH 12/18] maple_tree: convert mas_insert() to preallocate nodes Sidhartha Kumar
2024-06-04 22:44 ` kernel test robot
2024-06-04 17:41 ` [PATCH 13/18] maple_tree: simplify mas_commit_b_node() Sidhartha Kumar
2024-06-04 19:34 ` Liam R. Howlett
2024-06-26 10:40 ` Mateusz Guzik
2024-06-26 17:28 ` Andrew Morton
2024-06-26 17:45 ` Sidhartha Kumar
2024-06-26 18:29 ` Mateusz Guzik
2024-06-04 17:41 ` [PATCH 14/18] maple_tree: remove mas_wr_modify() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 15/18] maple_tree: have mas_store() allocate nodes if needed Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 16/18] maple_tree: remove node allocations from various write helper functions Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 17/18] maple_tree: remove repeated sanity checks from mas_wr_append() Sidhartha Kumar
2024-06-04 17:41 ` [PATCH 18/18] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc() Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406050515.BP3o0Meg-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=maple-tree@lists.infradead.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox