From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58810C25B78 for ; Tue, 4 Jun 2024 14:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6ACC6B0083; Tue, 4 Jun 2024 10:59:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF1236B0088; Tue, 4 Jun 2024 10:59:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6AF16B008C; Tue, 4 Jun 2024 10:59:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 844736B0083 for ; Tue, 4 Jun 2024 10:59:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E942E140696 for ; Tue, 4 Jun 2024 14:59:29 +0000 (UTC) X-FDA: 82193514858.27.6AA394F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf30.hostedemail.com (Postfix) with ESMTP id 910AB8000E for ; Tue, 4 Jun 2024 14:59:26 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="fo/BX+VV"; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717513167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hzMDgEj5qnxrkoXZDnEqxK0R3USK24v12P3Il+7VXDw=; b=zdQYgmenbetfADlaWZ4yeKozsu/JwDyQ8/TpxUcpIiMlret0z8BVG9InmjgyiYieq27Q23 XADaCQcYk9UmUiqlSIsXdknJewHkYQm8RCPRQmz8VhpWtIKN3OdT8FcYhcPLNuRZMVtMbg gmyOAEhZemdFppghSO8rQVeyLxvS8Do= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="fo/BX+VV"; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717513167; a=rsa-sha256; cv=none; b=OgFAVI374LbaJ8hIdMf00B9JbLem8/NEj3bMQqdr8IzxQWtz5/6KOyz5SKo/gZlMyHqx5u 8MLPw1Ro/D8rh/hdrggun09SvTv/Fx8hkNmUwlSQafbQ95Js8vOw1qX1ooebwKDBMp3Kuc afRS1POMGJ6yN81R2qqzL9ylzOJcmaA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717513167; x=1749049167; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=i1Mw6KgpcsjR+lCb2lbnWjfFdwskGTmzn+yGj18OkOE=; b=fo/BX+VV1YPK3Qls56YmwJy18yhaYnI5v0AnIOfmaKQhD3Lmt81y5KWb mFtIkRT3xJCRchILYNXlbYW9VT+7FGJf2xfDmZ+3aEknIXqe7v5adgcQr G6b5MJVr3rtm2b9ShBcdbc3fYNx7g2s8SK8w+Fg6czm4uyb2V0wwltpsD VJuMBEXsVIYi6MMRjvFUPMUVgTeh2J73ae85TFZR0DrIjnUtZXKguSHYH FYLRdI/lYJSv5+46P3rMT48aIo+tC61H7NZLoWZfpk1PSh6rLzcE3MRld WZiDdUq1HywLKfE+JuaD/287I4ZdDXe25pFqyPYJL+6urH9swCFy9JP3v w==; X-CSE-ConnectionGUID: u4zvsi6oTfSwGXvkMlJfhg== X-CSE-MsgGUID: fx6UsiH2RgGiftjRO6MZkg== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="36584961" X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="36584961" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 07:59:25 -0700 X-CSE-ConnectionGUID: HEI6MhllQf2dJHfdcSaHQQ== X-CSE-MsgGUID: UnPHK4ksSv+ICmkEhfAVLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="37341622" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by fmviesa010.fm.intel.com with ESMTP; 04 Jun 2024 07:59:20 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sEVd8-000NOD-1T; Tue, 04 Jun 2024 14:59:18 +0000 Date: Tue, 4 Jun 2024 22:58:46 +0800 From: kernel test robot To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: oe-kbuild-all@lists.linux.dev, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/6] mm: memory: extend finish_fault() to support large folio Message-ID: <202406042210.20LfqwNd-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 910AB8000E X-Stat-Signature: gcfmne5p4og3meidxf9cdnxfq7jcs5od X-Rspam-User: X-HE-Tag: 1717513166-399439 X-HE-Meta: U2FsdGVkX1/X5Ug8mSi0nzQj9HYjz7lrqs9His5M+tAglZtfJ5yTsJNmZnPZ+OoSvk73sqYminqn8gLaTS5NmfEoOAXa+YtO0Wnfe/huGPaKn0TbkbMaXyVnfqOQMJ/AyQiVjBjyWh3G69frnZdmSlJhCrGZkAKhY9AMnWaHxpOHvL60emH3TQsPzLcr92f4dmji5/OLpyecKvyB38hsTzo70L43Ui7hQCwm2vIN70XUMAsuE1IHEZ7ngZpSx80+FEQlVnMQ91SSxX6qVduGi9gVgsBeje03FyqeA2X1ygtpHW7wp1S+LQ2qgqGohs8fu/MeyN4n/K9n62oHVas9EGFqOiTxWBdRjusOVDMNp4ALuqDPufgesRaxYMc8XK78eMSXoYF1FBHCQpteN+JE2O6trMimuv7QHqA2uxnsmflc/eAu7lhq86/7cZO8Zl2zCsCmhBrXP6892aIhuX+9Wrn9z1SzVUxxHgKQylBpJGkNionUic5GONonVqd4jodU2+m1TmHtOPvxTwsbBX977k0LdlIvjSCPgFASUnOpH1GF5hTzGYJydzguigz8zd3KIQJvKOee0q9Ws2sZ/BRMANBmjXM2NOEj2h9Hx/IU4fqu6hQU5rV/kkNR7npmXtdRDRBsOTzXLiRt37S5+4hgFBDofbg64yCVr47Is8KVEq7AOXFpM+t/+xmDlxtbQQkYglWFn3UL5GbBEGJMeK7/fzXE7Oj2oreZ+0/0MboFWbsWEehyh45vBXdk5HNDjgC6XYflhNElMB9O+CXSRfGt/GrvKDAJu4RLYjCxqRzavtfaMFGleWo+wheJbmU17K8TEUjkXXaVEeOr/73XMbDgaZEVi3HTuXCY24mTnFWWgDNvVzVd4kQs57hqGFvcO52OylQoeHV+E4b4pSZjZ5C3pAjkRcM7cSx/rI8nhAKg86L3LfhZUyyD+WaaRax7t1ou6N1G9Et/gRIvH+tm1h2 Z7sBIpZZ Xun6wklpfLYiclG3yALQi5ZlD7vcDYLSQWYmO0+wK7TOnd01Ou2yRKL0xX5KpffjNahl8+psQcZeQY27j1uaTGQKEUyPv3Ez+/aVO/z/bMNWoTInDv795Xi5RYb6Ff6vCJCqZ3/YR7j1bwUZrYAjumkho2TVS1Y7+QXxHrzmdtys6WShhyfDob6pg/uLU+sp8XWonMD5PEMM9pEzQQFuAeJBwS0kAGTdH5H17/kUuLVsRj8r/HKIghr4Mh6htSHjaJ9glo/YmFxbGAuoa1X2VWQvX+3MvHpxoctZyKGERNqABl/KG+4cW2l/mxAtXaI4MPTK3PJwTnFazOoaFnmJndCEhNYYmU83sONzv9y5zYdPuIRCK17vXVTbLkDjz8yOXBk0WLfEpJ5EYFMlWiY2BkYWP9vTyx0Fco6M7bLgvqLKzE7WscBc9v81usg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baolin, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master v6.10-rc2 next-20240604] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/mm-memory-extend-finish_fault-to-support-large-folio/20240604-182028 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/bee11bfd9157e60aaea6db033a4af7c13c982c82.1717495894.git.baolin.wang%40linux.alibaba.com patch subject: [PATCH v4 1/6] mm: memory: extend finish_fault() to support large folio config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240604/202406042210.20LfqwNd-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406042210.20LfqwNd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202406042210.20LfqwNd-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/memory.c: In function 'finish_fault': >> mm/memory.c:4838:29: warning: unused variable 'i' [-Wunused-variable] 4838 | int type, nr_pages, i; | ^ vim +/i +4838 mm/memory.c 4814 4815 /** 4816 * finish_fault - finish page fault once we have prepared the page to fault 4817 * 4818 * @vmf: structure describing the fault 4819 * 4820 * This function handles all that is needed to finish a page fault once the 4821 * page to fault in is prepared. It handles locking of PTEs, inserts PTE for 4822 * given page, adds reverse page mapping, handles memcg charges and LRU 4823 * addition. 4824 * 4825 * The function expects the page to be locked and on success it consumes a 4826 * reference of a page being mapped (for the PTE which maps it). 4827 * 4828 * Return: %0 on success, %VM_FAULT_ code in case of error. 4829 */ 4830 vm_fault_t finish_fault(struct vm_fault *vmf) 4831 { 4832 struct vm_area_struct *vma = vmf->vma; 4833 struct page *page; 4834 struct folio *folio; 4835 vm_fault_t ret; 4836 bool is_cow = (vmf->flags & FAULT_FLAG_WRITE) && 4837 !(vma->vm_flags & VM_SHARED); > 4838 int type, nr_pages, i; 4839 unsigned long addr = vmf->address; 4840 4841 /* Did we COW the page? */ 4842 if (is_cow) 4843 page = vmf->cow_page; 4844 else 4845 page = vmf->page; 4846 4847 /* 4848 * check even for read faults because we might have lost our CoWed 4849 * page 4850 */ 4851 if (!(vma->vm_flags & VM_SHARED)) { 4852 ret = check_stable_address_space(vma->vm_mm); 4853 if (ret) 4854 return ret; 4855 } 4856 4857 if (pmd_none(*vmf->pmd)) { 4858 if (PageTransCompound(page)) { 4859 ret = do_set_pmd(vmf, page); 4860 if (ret != VM_FAULT_FALLBACK) 4861 return ret; 4862 } 4863 4864 if (vmf->prealloc_pte) 4865 pmd_install(vma->vm_mm, vmf->pmd, &vmf->prealloc_pte); 4866 else if (unlikely(pte_alloc(vma->vm_mm, vmf->pmd))) 4867 return VM_FAULT_OOM; 4868 } 4869 4870 folio = page_folio(page); 4871 nr_pages = folio_nr_pages(folio); 4872 4873 /* 4874 * Using per-page fault to maintain the uffd semantics, and same 4875 * approach also applies to non-anonymous-shmem faults to avoid 4876 * inflating the RSS of the process. 4877 */ 4878 if (!vma_is_anon_shmem(vma) || unlikely(userfaultfd_armed(vma))) { 4879 nr_pages = 1; 4880 } else if (nr_pages > 1) { 4881 pgoff_t idx = folio_page_idx(folio, page); 4882 /* The page offset of vmf->address within the VMA. */ 4883 pgoff_t vma_off = vmf->pgoff - vmf->vma->vm_pgoff; 4884 4885 /* 4886 * Fallback to per-page fault in case the folio size in page 4887 * cache beyond the VMA limits. 4888 */ 4889 if (unlikely(vma_off < idx || 4890 vma_off + (nr_pages - idx) > vma_pages(vma))) { 4891 nr_pages = 1; 4892 } else { 4893 /* Now we can set mappings for the whole large folio. */ 4894 addr = vmf->address - idx * PAGE_SIZE; 4895 page = &folio->page; 4896 } 4897 } 4898 4899 vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, 4900 addr, &vmf->ptl); 4901 if (!vmf->pte) 4902 return VM_FAULT_NOPAGE; 4903 4904 /* Re-check under ptl */ 4905 if (nr_pages == 1 && unlikely(vmf_pte_changed(vmf))) { 4906 update_mmu_tlb(vma, addr, vmf->pte); 4907 ret = VM_FAULT_NOPAGE; 4908 goto unlock; 4909 } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) { 4910 update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages); 4911 ret = VM_FAULT_NOPAGE; 4912 goto unlock; 4913 } 4914 4915 folio_ref_add(folio, nr_pages - 1); 4916 set_pte_range(vmf, folio, page, nr_pages, addr); 4917 type = is_cow ? MM_ANONPAGES : mm_counter_file(folio); 4918 add_mm_counter(vma->vm_mm, type, nr_pages); 4919 ret = 0; 4920 4921 unlock: 4922 pte_unmap_unlock(vmf->pte, vmf->ptl); 4923 return ret; 4924 } 4925 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki