From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21883C25B78 for ; Tue, 4 Jun 2024 16:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8448C6B0082; Tue, 4 Jun 2024 12:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F40B6B0085; Tue, 4 Jun 2024 12:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3266B0088; Tue, 4 Jun 2024 12:37:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E6AF6B0082 for ; Tue, 4 Jun 2024 12:37:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB0E9140B41 for ; Tue, 4 Jun 2024 16:37:58 +0000 (UTC) X-FDA: 82193763036.23.00AF3AD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id D652740009 for ; Tue, 4 Jun 2024 16:37:56 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717519077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4BVSSTjoKWXgCiqhPCnIVI8ewzRJIRXr4CIJCfDOwas=; b=UrhFxOQxVl8vj/f9OPWqw6NVX/sNxdQ3n2z6ldzPvtBEaTNcNRyFZCPkChSMh3ZbV2yfrL +crtvkg4uZTzEz51Ra+IDIB6ivZBFmZs98qv1zEaA/PVSbIOlyR6eA6feLbi+7FLCNX1PZ C11F519ZHzY5/U43wT6LnvfpR7T+AMo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717519077; a=rsa-sha256; cv=none; b=unMJMZt4LAiSs9O2e6NxDJqlhnuaq2Q3Lh+R47mEtfVN8bQ/tjNcdhZqI/etUVvD9oQMXP 8lvJXqDE+r/XUvToWbZRw+dUGPddpScbZfpmPRD+PbuvNSPzbINwl1y/tj4xZRyVxFBEdc Hkq11/DxN4KMTpSO+K207F5V26Lpvgw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C1FB1CE1260; Tue, 4 Jun 2024 16:37:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 335BFC2BBFC; Tue, 4 Jun 2024 16:37:47 +0000 (UTC) Date: Tue, 4 Jun 2024 12:37:45 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240604123745.71921f39@gandalf.local.home> In-Reply-To: References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D652740009 X-Stat-Signature: wsq6mcpucqcb1ofww481y8x1hae1th6d X-HE-Tag: 1717519076-812007 X-HE-Meta: U2FsdGVkX19XDLhxaj23CQ+kNGU2mBfrzR/qCttXCVmKPeWm0vt/OOK6HRTMhbtS1iKLhafQTtLnRrq6TFS/mrE1O5uuHSDAKPfW+Vay0+IgJ1JGiM5JD4u31szRlXUNp0KzbN+/wUGqSzIGoB+gKOQJCU++jk4pgP15YbCw+toENKyHIA3IB6TYq6j9Rdwf7gmseNRVFdjoIn64uT3kj0epsugA8yIA6wzXUqLB/X+217obECtXlC9lCjjzt0ZELTivgnoh/+8/OABmtY2TQ2Vz7RbhRXNk4mSCxAuWZfPqv/E0tgY818pbM7jtV8UhoYLFLHzf9Ke6sSUBMBwv52GUPqTeo2VQzRLB5qDQ8zY9ILuKOQqEtF9JlNFGvHrsCfz3nnCfgyogJteHaFVPZb6LVub0cH/lDfg/OSFGF60BcW1KFBvab830G1oY6VhX1kzgLY600Bs8ThAWgoRjTSfGWr2rFpbTRoOObBeErJRJIefgzCbqBMNq20e8qIbNf6rVL9r6YFrymj+/SKdow99Wrj8RrshKfLIzAYlDeHlrgMhWL+FNuYZ16KcBrQn4EQ6oS2SmCXBXfNECP98JOkxBKge5iKkru3XRnLyHyqe2PA/hSxWdXnOruAZ8pORjtfSIvWCRmALwEgLuyZtCHlMFmO6yqqX3i52Ca8ZVgyZ+aD7nKlldkrQoyQ8+KPZ+L6f4100qNoXoN4MH8ZV02lCS8xVKTV3slG4iVDOdtRNuOnAWdFHScyiAlf2ISy5xMlqCH7XSq9eHxnHSHNr64k7XZeX+v7tgpUbQQW9/hhGRAZI/pplGoHPPeIHrf5didebF1B5iU1eKIkZwYgzzTq53FmKvejj0d4Lx7RoPZ0TnKE8pcStoXsp8IlU/BoBKF2wOSiibK52KAphemiC9CXfV3dPsPr2ytnBerobbPq5WDS1zhYzNrjuG23MvCmxt8jdCJWTRzvW/cLnMhdw OWDrWYOO ZeIN+oIemEhCcew43KXACPb7ZI4Vt6oTqLFOO+rhRclzFihEGl9HlAP+cSHb6TnFe4ginNrrChfMBojOPGTYMA+Opw9jb9rQ7M7ji/cZMJ3oeRMcuCg8tYOsM/LBHdnTf31M1yMuSksjjQOe0u8bLnJ0iOjYBcZbZc4N8i91ZQiHfEaB63/nLRGg5e6SEVlWhWJ8UK7QHHTOIBU4G9XkqV1DqM79BTGUHUsNR1pEV+5mvmvynNKp7n1kboFYCSsHkORq/Gi5TTRZeNd0av6uKmpp8yerWre8GA7M/4nMM67axNzU6QzHbUCkpT1KP7Swginlw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 4 Jun 2024 17:57:46 +0200 Daniel Bristot de Oliveira wrote: > On 6/4/24 16:42, Qais Yousef wrote: > > - (wakeup_rt && !dl_task(p) && !rt_task(p)) || > > + (wakeup_rt && !realtime_task(p)) || > > I do not like bikeshedding, and no hard feelings... > > But rt is a shortened version of realtime, and so it is making *it less* > clear that we also have DL here. > > I know we can always read the comments, but we can do without changes > as well... > > I would suggest finding the plural version for realtime_task()... so > we know it is not about the "rt" scheduler, but rt and dl schedulers. priority_task() ? Or should we go with royal purple and call it "royalty_task()" ? ;-) -- Steve