From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Qais Yousef <qyousef@layalina.io>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Metin Kaya <metin.kaya@arm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task()
Date: Tue, 4 Jun 2024 12:37:45 -0400 [thread overview]
Message-ID: <20240604123745.71921f39@gandalf.local.home> (raw)
In-Reply-To: <b298bca1-190f-48a2-8d2c-58d54b879c72@redhat.com>
On Tue, 4 Jun 2024 17:57:46 +0200
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> On 6/4/24 16:42, Qais Yousef wrote:
> > - (wakeup_rt && !dl_task(p) && !rt_task(p)) ||
> > + (wakeup_rt && !realtime_task(p)) ||
>
> I do not like bikeshedding, and no hard feelings...
>
> But rt is a shortened version of realtime, and so it is making *it less*
> clear that we also have DL here.
>
> I know we can always read the comments, but we can do without changes
> as well...
>
> I would suggest finding the plural version for realtime_task()... so
> we know it is not about the "rt" scheduler, but rt and dl schedulers.
priority_task() ?
Or should we go with royal purple and call it "royalty_task()" ? ;-)
-- Steve
next prev parent reply other threads:[~2024-06-04 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 14:42 [PATCH v5 0/2] " Qais Yousef
2024-06-04 14:42 ` [PATCH v5 1/2] sched/rt: " Qais Yousef
[not found] ` <b298bca1-190f-48a2-8d2c-58d54b879c72@redhat.com>
2024-06-04 16:37 ` Steven Rostedt [this message]
2024-06-05 9:32 ` Sebastian Andrzej Siewior
2024-06-05 13:24 ` Qais Yousef
2024-06-05 14:07 ` Daniel Bristot de Oliveira
2024-06-10 19:21 ` Qais Yousef
2024-06-05 14:05 ` Daniel Bristot de Oliveira
2024-06-04 14:42 ` [PATCH v5 2/2] sched/rt, dl: Convert functions to return bool Qais Yousef
2024-06-04 16:28 ` Steven Rostedt
2024-06-05 6:54 ` Metin Kaya
2024-06-05 9:33 ` [PATCH v5 0/2] Clean up usage of rt_task() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604123745.71921f39@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=brauner@kernel.org \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=metin.kaya@arm.com \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox