From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3790C25B78 for ; Tue, 4 Jun 2024 12:26:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A55D6B00BC; Tue, 4 Jun 2024 08:26:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255696B00BD; Tue, 4 Jun 2024 08:26:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F67D6B00BE; Tue, 4 Jun 2024 08:26:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E58226B00BC for ; Tue, 4 Jun 2024 08:26:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A085AC0617 for ; Tue, 4 Jun 2024 12:26:39 +0000 (UTC) X-FDA: 82193129718.28.B6D0460 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf02.hostedemail.com (Postfix) with ESMTP id B5A8280004 for ; Tue, 4 Jun 2024 12:26:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=b02Dn0l2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.48 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717503997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wirbdRLWKxynbDeQYlgqnwEHsv5grhz29Os93lpSf5Q=; b=DIvCXMPqmTNXDax3VHYFxS1cDP+c62oiq3qcdxcsKyX/QV4cYmqt55dnSN/KrHvv2nkN1y DoZdznQKQaSsBL5qHGjIc3nRShgwHr0429hRuN53ZcMPcUoohJ/T4htPJjWSfDlPoxi33g Eon9tnrW2V+BcHzKiMSkHCqkm8Hru8E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=b02Dn0l2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.48 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717503997; a=rsa-sha256; cv=none; b=HdkwmOZuwNjkw+7IAXibHlitreD5mwv25KpLMdoOtzfnC//nQHZ/6vVy/L5sXVBFRFpeXQ HNiSHp0wBSP7O2/yV4zTETwVf8KaaOpa64/I3qRp1fClQhcZXlJVVTtnUwJ2uKxHdiWlcd XdKK5PiJAPFUKGTNyjeTcigoqVxPcps= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-42133f8432aso22852155e9.3 for ; Tue, 04 Jun 2024 05:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1717503995; x=1718108795; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wirbdRLWKxynbDeQYlgqnwEHsv5grhz29Os93lpSf5Q=; b=b02Dn0l2tdTsUYRiE7yxlFlmLbEn8mINPqz43PtrJhXkgGXwpmTW3UzKerp7SoJG5x jRSdKhr2wB1G9y0qZEs9r8tiaN1eGxZb+moC9T7NoD9HV4QdrlcOFYDxaWq4KbuUnubI 7RH1AKOEhGjHtpPgjugSbkhAL+7oaouoVrmck4bNPym+RjjlX7T0snwm4TUznyUL+y7X VP6FDmztXzTEFi9hxefhLpC4XGb/LfhwXym7oIif+Y5vPgKuQSQdDO5SvC91RRFXfQvd MvDlrc7pggT8o4AQn5QWcl1Sl41S1NwfDSV99rF4P0Xhun6JWPypVt5Pnc+oCmRF6EI9 UYpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717503995; x=1718108795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wirbdRLWKxynbDeQYlgqnwEHsv5grhz29Os93lpSf5Q=; b=E0FAbmEyMbOJup3qjDKEcwYS25ok7J0FpjaxnXQ8wjveau+MFXJHLYNqmRRBOLg+oF I1Th8T4QCJzxTvgCpxdoPPj203kXySOfitTAgLs+0OV9/H2KmrcOdH5JgjWMpDs0Z05q LIjSxXV9i5AeYdroiqlEaKkqq/X5wmSGPSbHCYZ/8vinyIGw5PHYh82PYq+nmkYUorN8 dX80MECPhryzQF2IHd1wQ2pSPiRPXJRARkobNq0UhTgu+lM+NOOKT4wa0Dw2oabuCbTz TSpSINru+zOsXBDeQiVsFedjN//FPU3DS0gExhdBojOpTebx95WyGpmrtrF6YTB6D29B Ey2w== X-Forwarded-Encrypted: i=1; AJvYcCXbg0zt62+2h8PzLisU/X/713g2dJ2/WLYaGjnDEaW23I6GYUIYGEci2ErXu5LzWP572nJQU7HWBcK07q4dB5wgJns= X-Gm-Message-State: AOJu0Yy7RI2OQrPD8gNmJAK/VotrbFclpW2N0VtQTYAjEZ14iyU0dIYu S9Hwz8snNJBO9czNYuVRawLpWp/A1Yjwsk1Y72VckLtsyPkWu31UEP2nNTNKppA= X-Google-Smtp-Source: AGHT+IGIZgGSS/PWE54q5X7JbJs712JoGI7T0PbD52fooF8vEqAkQLTKVUVAxk3tEHmCbhFHMtXxaw== X-Received: by 2002:a05:600c:350b:b0:421:5329:20b with SMTP id 5b1f17b1804b1-421532906b0mr9899205e9.33.1717503995116; Tue, 04 Jun 2024 05:26:35 -0700 (PDT) Received: from airbuntu ([87.127.96.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42132d5308csm137660745e9.35.2024.06.04.05.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 05:26:34 -0700 (PDT) Date: Tue, 4 Jun 2024 13:26:33 +0100 From: Qais Yousef To: Metin Kaya Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/2] sched/rt, dl: Convert functions to return bool Message-ID: <20240604122633.ais2zq6kytfcvj6a@airbuntu> References: <20240601213309.1262206-1-qyousef@layalina.io> <20240601213309.1262206-3-qyousef@layalina.io> <417b39d1-8de8-4234-92dc-f1ef5fd95da7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <417b39d1-8de8-4234-92dc-f1ef5fd95da7@arm.com> X-Rspamd-Queue-Id: B5A8280004 X-Stat-Signature: kedfckk1m4iouizx1yjgkshgz7z7ejjz X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717503996-573923 X-HE-Meta: U2FsdGVkX1/ZnyHIX0MGfjvMV4lSE3wvbOvENN639i9XmKyHQJm2FM1pZfBVN3JRzyYYq1uVT/d0JbowE+/2mztLzJdUD0GvxPXxQ6+e0A1+W9FWls5QTiBHoZkHYdpDEX6HQD8Jy235RjIHcEPuRtOsrSM0xpHOEp+kyAK5FOMtIMX+qeSPAst8AdtSyvoJc4BQFGd1T6bvQsHgX9hn3VTjoSfzBRMwNCRthGt53BPVzm9xWX1El567kik4qjklz9usyuqojK6mctEOdMsWH2Wz0lvF1WK95tHnCy5hZIFVVheZHWYhVTiosPdFlTkLtbsxGrWF4tFX75WZTkUH9OJMddBzCnlEaDSa9YPQa82pIFfhb3x0RncL9CYIAm/svM3IiziQZblqcA36HEIsYNiHeWUl7W8szdGwiJXL/3UORPWE6b+Dpuwh72b2ic9Fi/yQ8V7Y8TwrpZyV7QnInwtk8G4ptOP8Hgbz7M67y4zHQuf7bca0VYS1VfcpKQ67wpT4T9UUIhj7DXG6LKvmeD45c20VC5iLCktbGJCdJabCJY3dOindL14QuNXLsod75yp3I/Q5n/wttDQL+MdE4UlQbxaP7L1TZMyMtskEIq0OL/hBwwIGTzvtRLDW0s+KmYlLy9HQRwZUY5aPmwLwwbSKeg6smmPl6mmc8n5J02aR3IMdureUnGhBEEej6N4twELPF5iuYhuw8OrDnN2px7e2ty+eSB1DGA1etL47KNOB9XdGOv0hjjULOn8D7zhAPlIwRWYPfbMUwa5Y7ZoEBNQ2g1rkkW70Hsoypm9mTBVJ+RWdMxNVK9zSwfFE4zbkTecl+WYkCe7nVmg+I/F5HblUW37pr5m7mI/dGxFIKuwJJ9KrXZGCfyneM0VqImTBPkj6JTO/R+scS+I66vQkGWqFfQtLE7oBmir5Rt9I65YOn+9mdP3yiTONoML5DrMiSGF6/fn4cY+QIYMK0vz H2Ovi9L8 aK4BI46V7wOdni4lQ00SEjL3HeqemYJhqIB1yhWl4yw5FGaErmI7vBHf2DmIs/fxfFJESaUxGdr4Oi84BkHrupGaubH8MjFizK7cCtHbmF3NDXPoKuAWY4Zb8K3V04i50rEYSIDwFHVZnyk5K1M5YVqGKEpp9YukI0c9Kw//BM5EEgUY2IN4L5fXMizfkdBHdCyTRLm5ycgJYGuYZjLOvAx12EWtFCNN/6NqAxaFDkzKiACsaLec4WGKPxAC1B5ucPrtHir1nqA08pcINWLSeRLpr/ZpnoeX7MB2Gyro2kjaVYIXdwLbkckdLykvOU/cFEzgH47HeDOwvN9md8VIu+WdpBIpvU0AtQwaW4icZKusfGpPbJSPQZSxjVqFzaZ229x8PGN2AYQKJ6Mlo76uGPzBrfB5bbs3ZGNMKV527OLrZkFXHbNqm2ZL/V0S4Y7rgG4fuukeKfyLVVW6d+jwTpwMwblDHF1CxwLH98prxPdcS/8M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/03/24 08:33, Metin Kaya wrote: > On 01/06/2024 10:33 pm, Qais Yousef wrote: > > {rt, realtime, dl}_{task, prio}() functions return value is actually > > a bool. Convert their return type to reflect that. > > > > Suggested-by: Steven Rostedt (Google) > > Signed-off-by: Qais Yousef > > --- > > include/linux/sched/deadline.h | 8 ++++---- > > include/linux/sched/rt.h | 16 ++++++++-------- > > 2 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h > > index 5cb88b748ad6..f2053f46f1d5 100644 > > --- a/include/linux/sched/deadline.h > > +++ b/include/linux/sched/deadline.h > > @@ -10,18 +10,18 @@ > > #include > > -static inline int dl_prio(int prio) > > +static inline bool dl_prio(int prio) > > { > > if (unlikely(prio < MAX_DL_PRIO)) > > - return 1; > > - return 0; > > + return true; > > + return false; > > Nit: `return unlikely(prio < MAX_DL_PRIO)` would be simpler. > The same can be applied to rt_prio() and realtime_prio(). This would make > {dl, rt, realtime}_task() single-liner. Maybe further simplification can be > done. Fair. Thanks. > > > } > > /* > > * Returns true if a task has a priority that belongs to DL class. PI-boosted > > * tasks will return true. Use dl_policy() to ignore PI-boosted tasks. > > */ > > -static inline int dl_task(struct task_struct *p) > > +static inline bool dl_task(struct task_struct *p) > > { > > return dl_prio(p->prio); > > } > > diff --git a/include/linux/sched/rt.h b/include/linux/sched/rt.h > > index a055dd68a77c..efbdd2e57765 100644 > > --- a/include/linux/sched/rt.h > > +++ b/include/linux/sched/rt.h > > @@ -6,25 +6,25 @@ > > struct task_struct; > > -static inline int rt_prio(int prio) > > +static inline bool rt_prio(int prio) > > { > > if (unlikely(prio < MAX_RT_PRIO && prio >= MAX_DL_PRIO)) > > - return 1; > > - return 0; > > + return true; > > + return false; > > } > > -static inline int realtime_prio(int prio) > > +static inline bool realtime_prio(int prio) > > { > > if (unlikely(prio < MAX_RT_PRIO)) > > - return 1; > > - return 0; > > + return true; > > + return false; > > } > > /* > > * Returns true if a task has a priority that belongs to RT class. PI-boosted > > * tasks will return true. Use rt_policy() to ignore PI-boosted tasks. > > */ > > -static inline int rt_task(struct task_struct *p) > > +static inline bool rt_task(struct task_struct *p) > > { > > return rt_prio(p->prio); > > } > > @@ -34,7 +34,7 @@ static inline int rt_task(struct task_struct *p) > > * PI-boosted tasks will return true. Use realtime_task_policy() to ignore > > * PI-boosted tasks. > > */ > > -static inline int realtime_task(struct task_struct *p) > > +static inline bool realtime_task(struct task_struct *p) > > { > > return realtime_prio(p->prio); > > } >