From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755B2C25B78 for ; Tue, 4 Jun 2024 15:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6AE16B0096; Tue, 4 Jun 2024 11:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1A626B0098; Tue, 4 Jun 2024 11:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2D06B0099; Tue, 4 Jun 2024 11:28:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0C126B0096 for ; Tue, 4 Jun 2024 11:28:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1553E160E3D for ; Tue, 4 Jun 2024 15:28:10 +0000 (UTC) X-FDA: 82193587140.14.1F4CAE8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 0D11440008 for ; Tue, 4 Jun 2024 15:28:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717514887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4CMTw8e/CZuzZa1zxczlUO7dYi2zP8A0pIKwzELVD7A=; b=YWRJAcPd4YA8LxOi0nl+3ra+QTVgpWJmp06ooszrDLGXj0Oru0C3QiREwUqCQSpt1KVyw9 Sn/naGkvCRdrUFkO3EGcBsKYkigJ+x3MpvdiG+q15/1goftMvYFFW+zfHZsJp0KawCew5n F7OY9n1gs2uhZYP8Q5HYrhpknWD1QWI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dfpp=NG=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717514887; a=rsa-sha256; cv=none; b=X5oiDXF/ZGQIcZj6oCwjIdaUSLgDfMIwqRVnYynJ/kZUOVZhaecmNMvEvM6mA6D9tAJDO1 tD+Mkf0o7ZH3/QoBmlYL0mJc0BtOJvCRGJ7PntzGRHJRErgc0FI5buQBJYbjDhSWndfPSF x4PI3edS2vVs9bz60c8o8mZ3rnIrQlM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5A0F3CE11E6; Tue, 4 Jun 2024 15:28:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30859C4AF07; Tue, 4 Jun 2024 15:28:00 +0000 (UTC) Date: Tue, 4 Jun 2024 11:27:59 -0400 From: Steven Rostedt To: Metin Kaya Cc: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/2] sched/rt, dl: Convert functions to return bool Message-ID: <20240604112759.56b9394c@gandalf.local.home> In-Reply-To: <417b39d1-8de8-4234-92dc-f1ef5fd95da7@arm.com> References: <20240601213309.1262206-1-qyousef@layalina.io> <20240601213309.1262206-3-qyousef@layalina.io> <417b39d1-8de8-4234-92dc-f1ef5fd95da7@arm.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0D11440008 X-Stat-Signature: 5wtxr1w67sqz1aeedobt7haah43g68yy X-Rspam-User: X-HE-Tag: 1717514886-113864 X-HE-Meta: U2FsdGVkX19tlK0uP4vjLa9iueSBNEhOJaASoULHgRwEdpgLGr/BOECDC0ROqpr88pqr/94Rada/AhY6r5WhoLILCXqg8Yyq5qqPyubzFIb/+JINeb6g/Eop12qn0l3dg/IzpnIplb11B8ZHm565JNPZJOZKgM8E0MnlGe3Kr5sowe1mRckazSanABATALV1sZMFkm/HbEHl9H6wOudkn3Dgy+PV9OkUQmfc2TS8DYOIsnG1lCC3N6Cawu/b+ar+PAqcHer07OQVHKtk71kPmMg97fwMyGi+cSZFsvFo3imd+B5IIwcp3VjzO2AebFAZiuoyL0znnrTNkSowdkxhDyYykp+RGJnSIeIcWVS0ohdPmT9gtQDFObEK1KJP9Qedj8ueqQAvAhEBlEdmJZBLmKBiKo5S/V2rnmH0jpJWJOIA30BySuh0bSSANC0qx1aB6lzt+8mrXoPL4NJemOnTxemC1bzW9VOmZ90n42QsmhnD2xAx2HVZcrl+1wORsI8BVPpqpkDK6n9BISSzyIw0sSN+quv58AlU67PcImsLDtiMHsCZ0WMh75tLUIfbulA8/Edig5wClQYRqJBYCKUmJRrolj/EL/Cx50YfagwPf+1TyTfz6eDS0UZQzmvENlROCKucBugdHGms69PEy4KRZf2FGxQmZEjwCfejmRqNX8jiAPMtk8f1MFDJxCW+G5KoDRwN+sWMaz8xaLvYt83endcXJUyoPxsWSqe7oKXc630ZaF9nMNNnR5fryyAKKcqnYO5e56p6qjoyVkfQLjHPs15UTBqchcdR64UFk8DnAPtbzTKCbsR9LMNWtSJ5UOBtZBqWiWYC7QFzC0g9rqpU5kYkZ1zTOetdgpiErmU87ebqCyVc01k9AjENIez3uhNhReDzj+HSZ3Z4UujcQtc/CFSLUHRLXlvYwmj+CrpUr+tCv94M4CamTEKTcJzRWuPa2zWFJtzQf1GU73NQE3U 7fcqwjmn lHkEkVzTd4cea0rU1UUrujHaprAHgMp6jg5nWNOoZET1TpOTxthVcm2JO6L566x+rPWHwL69xD2CMwZH47LcmX8UPYYYKQ/W+5wj+UpVUTyy5qlgoJx/psP5ilkjX9B4QpGMFswm+0WckUlVVZOS7DKAvMDGOXsVBzLbGBfdgIh4NnLkf54gYCZkoR5N1Xuh+erCfomD/Z5WvqWb9GfmqaxcpZEufin2ziHhuCmOmw+DMe+19w49UJisvxwfAw6qHPcAsooWGnNOCFYQAvhURQfQlfHYCRwOt77RVEkIgW3bly8ZX9qONVxwl6o3/1aglq8gUwSSANSKIwYMoO7iY1iMC7KtOAlczHyjDcfkYQcjJkLYMWgkNDki9eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Jun 2024 08:33:53 +0100 Metin Kaya wrote: > On 01/06/2024 10:33 pm, Qais Yousef wrote: > > {rt, realtime, dl}_{task, prio}() functions return value is actually > > a bool. Convert their return type to reflect that. > > > > Suggested-by: Steven Rostedt (Google) > > Signed-off-by: Qais Yousef > > --- > > include/linux/sched/deadline.h | 8 ++++---- > > include/linux/sched/rt.h | 16 ++++++++-------- > > 2 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h > > index 5cb88b748ad6..f2053f46f1d5 100644 > > --- a/include/linux/sched/deadline.h > > +++ b/include/linux/sched/deadline.h > > @@ -10,18 +10,18 @@ > > > > #include > > > > -static inline int dl_prio(int prio) > > +static inline bool dl_prio(int prio) > > { > > if (unlikely(prio < MAX_DL_PRIO)) > > - return 1; > > - return 0; > > + return true; > > + return false; > > Nit: `return unlikely(prio < MAX_DL_PRIO)` would be simpler. > The same can be applied to rt_prio() and realtime_prio(). This would > make {dl, rt, realtime}_task() single-liner. Maybe further > simplification can be done. Agreed. -- Steve