From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 179E3C25B78 for ; Tue, 4 Jun 2024 09:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A99D6B00AF; Tue, 4 Jun 2024 05:43:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8330C6B00B8; Tue, 4 Jun 2024 05:43:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3976B00B9; Tue, 4 Jun 2024 05:43:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4EA016B00AF for ; Tue, 4 Jun 2024 05:43:40 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9105120BE2 for ; Tue, 4 Jun 2024 09:43:39 +0000 (UTC) X-FDA: 82192718958.26.C4F0D25 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf27.hostedemail.com (Postfix) with ESMTP id 33A6540018 for ; Tue, 4 Jun 2024 09:43:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=YtAkYBgi; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717494218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/wyixPQKPllzlkQ6nP0MNk7Q+TX9oe0qPOvgtCB3QtA=; b=aXGskavdY1o61+/a+3gsTeX63ksnaXxWHK27XJAmPMLnBdozh/2UKhORzFc5+ZQelgsGDM qx9jKR1SS2qGYrbKkGeOcBhD0OKi91X1nwVmxWtjyEOSSYQnRj1zDOxspNEltTaAMS9hPy p49UdPSV/7p+310lQzPdfzJGktvewgg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=YtAkYBgi; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717494218; a=rsa-sha256; cv=none; b=hm0d0MoZR6qu/XqZxY+tZ1sbHXBaqpg+Pd9Lj/x/Z98vvHM3E3g1mE7c3kAHf/Ecq62Qhk aUNrUhmI9RqPEvr1CV8Bjq+sD7IH/vNIrK+vvcrsCDgGhmJLD8bzmoOx/8EWJMZ7evESf8 16ZPAVkDMT2KIvCXfJ7dXNWgzi8ZC3U= Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Vtlyt3kv8z9sqF; Tue, 4 Jun 2024 11:43:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1717494214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/wyixPQKPllzlkQ6nP0MNk7Q+TX9oe0qPOvgtCB3QtA=; b=YtAkYBgiDiiLTrSB1xXRBsq9S9oVQd4+fGLl114XZLZfFLqEjmSRSi3OD/ewx2b4xsFrin b31N9SmU65EekOzDKNDv/0VOdTQC76P9QfvlKf2AMY5TZpbIK/XI8ojK3aSFwdx+DAE6j5 TUrzR5fJsAaKzjhai6vLP5SOdNCd31xk0yfdOo3EPOJGxACiklOpHTpNuPSoQSkjXee9V+ bfUAHw5Bx49k5i6dyWfpCfn8RpXkeCERgAjUoxIKsiaVISFqz3t1aeX8py5FO6HZnWBB+i j5epziGzDMKCXz/rHreSnRbSe6R5xg7SFo73vhNBVNNuRmT53/F2MZP0GtcEEA== Date: Tue, 4 Jun 2024 09:43:31 +0000 From: "Pankaj Raghav (Samsung)" To: Dave Chinner Cc: chandan.babu@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, willy@infradead.org, djwong@kernel.org, linux-kernel@vger.kernel.org, hare@suse.de, john.g.garry@oracle.com, gost.dev@samsung.com, yang@os.amperecomputing.com, p.raghav@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, mcgrof@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240604094331.gybm6la3xdunpcin@quentin> References: <20240529134509.120826-1-kernel@pankajraghav.com> <20240529134509.120826-8-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 33A6540018 X-Stat-Signature: zzqr3w896xxjch4eseq9y56w5cmt1tfh X-HE-Tag: 1717494217-83773 X-HE-Meta: U2FsdGVkX1+votmELBFV3+RSftpStgn/6dKZ/h6Ma8GRHbdSqnjmS2cDKMehm6ph/b0w4b76Z3vRdl2TWQsIC15HqOaRAScYeEFmfeTLBKKFvY0jOel1Q11aHPxqI6FgCQ2HR6e09io3lLjathqNslZR04UFHlMgXoZoWAoFRpeOcOsJ7323P8f79eMlSi5KZm3dQiMBu7eEJOz+hd/nm9bAS5gJMcXZ48yZb1YP2yIri9Ag5oAJEf3DFUorbonve9gFrbEUKDZfwLZ8p72+F96/b219hu/XV2EYZOuOvZjEJWF81rzA3/1NPpZL0tA/Zb9lSE7x0fXzC1ZksWI5Xc389Ajf8ako5Anx3bBTNhsmvYQf03BsSp/mVjYnMQKUPn2sU8ujUJSAUDn7dSLcHUkW+MO6SmpIHTynnwU3aEPxKPJIQ2GAYwror39qQAnbCpfYPxs8ZcjEZq5F3ojCoAULwzONn4U2xsl1//13c59TUL6/CI2FaImkywwFjysvuaXOZmbXytp4dbKiNbuCOKncGEWBGIKXlIsafisaIDG/gI4m0FBULLuSEIHpuPrYiTP8qDwezq98w9PMxuePKVHnWK/FOZ2ywWB+lhtB1r+z0N1zmd0b9yCxD7QPb/usghzmp+aOFyAKJKl4I+BGmgfhOH8wSz4Wfdvu0zb3Z48Td35rlY9h8bDS2J/7BYC34ag+1o43ixiJKSH914+FhgAQ5y6vaLoPfzOATi+I5AfaWmeR+Nqi0DKFq1cj+0hLrRcnjbTkKk7irwacJMQ+q7k+5mG9t5lwAOlRBuu+iytbMFkxDFsTUIgXzYRUFCwHtgl0MDsazuoz+lu1Ldnw9Ds9+m8YVN3ik4NJN1Oj/JcPqYQuL2YMpArzNufMLdR9Ze52rU5AGt0cNMSpw4LLDcjrN12k1xG+UFvHT1zJZfdByVFA2yxMgf6YI0TQTl126+z7/mUcteeSWGU8QEJ r4tjwssb 9Dzs/dadYoLd8sZvbU3tJ4aCqw+IaokZq6jl4Kb7xfOcf4y5T8As/yCJ+6Qck7bL0wqnjNJsDGH5X3Hphis7mGqurrWQbQwWji6JJ+ZcJLMQrvlt+GoEXB47AmpIeXOs4nfU2z/FOguaKPOIhGLoYnS7WWrItzNHpKJ6XEXeWrqAPZEKUQCkh05+QyIY5qxzFHHmNNS8s2Wr4ouRTIiiiiZXZGK4pJhKTMC9sfq22LWyNIqBqvnSZkipEQMdTHrmVt+n9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > static int __init iomap_init(void) > > { > > + zero_fs_block = alloc_pages(GFP_KERNEL | __GFP_ZERO, ZERO_FSB_ORDER); > > + if (!zero_fs_block) > > + return -ENOMEM; > > + > > return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > offsetof(struct iomap_ioend, io_bio), > > BIOSET_NEED_BVECS); > > just create an iomap_dio_init() function in iomap/direct-io.c > and call that from here. Then everything can be private to > iomap/direct-io.c... Sounds good :)