From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 954E5C25B78 for ; Tue, 4 Jun 2024 09:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14626B00B6; Tue, 4 Jun 2024 05:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9B366B00B8; Tue, 4 Jun 2024 05:42:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13B46B00B9; Tue, 4 Jun 2024 05:42:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ADE326B00B6 for ; Tue, 4 Jun 2024 05:42:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 52B341A0A5D for ; Tue, 4 Jun 2024 09:42:57 +0000 (UTC) X-FDA: 82192717194.30.2E79163 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf18.hostedemail.com (Postfix) with ESMTP id 655241C000A for ; Tue, 4 Jun 2024 09:42:55 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=BhxBAtgY; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717494175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BwfviVSUVjyzK7z0Oz8qcwUlgiOXWr8u7z2/yepDw0E=; b=sl2KVxpDE1wQHX4RtUzZ1TXe0PRKtOUQfCHTneU8ajTmRDwCJiRaSBk6ZPCGf06hKiQRSU rK5HsFOJgvjdtHEH9cXUy0OILVvIaDuZBuDNEzmS+0v4LrK8+5a1kU6IcBZGmPEOw9/hGU 3Z+ltiUYhs/mn4VEtU6iw0WNfpv77cE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=BhxBAtgY; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717494175; a=rsa-sha256; cv=none; b=jpZjS37hpf+kPevyLbT18aJxaJgEYZw9Wvz47vcUqv+0yGp0RxSFaaKKxkCg4ouy0FuCgL OJHTguA44nEhtmjbkjtVWmBVG6TR+QFBR0WzVIWwDap3gR3WWQEa6Mg+LpDMHFpocvy4UN siR9hJHpdMlUh6CBBCpvbV7kWvjmVME= Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Vtly2399bz9swF; Tue, 4 Jun 2024 11:42:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1717494170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BwfviVSUVjyzK7z0Oz8qcwUlgiOXWr8u7z2/yepDw0E=; b=BhxBAtgYhyhzPeOgmDqd34ZmUeefBR+MfK7CU65OVl+qKZoeSu7FVj9jW2Yr2xBqz9f+r9 3ex9Ri1OiQGpL1UkdDImUVZUWHGVarixU1UKzZU9mfn2DHPiB6XHxoeeFKXEe/a40KTUxg sNFnRK149QKjw64Sa1vXgM2HIWt1zD9v+cxhjKCXMDBY+d3Q5/0wmj8vA5AbtfSoVDThLp igxWkSSOnahjECeHmWBYZFdIQxY8Ks1o1YVDyoVau8Hs8SyOKqbOT4t6IrIfgBW/9wYKet 5BV2x1wNgCjnHAXATAQjCl4SiKrI+C+rBAuScByIpi7TjNNMCFQJMEya2imJaA== Date: Tue, 4 Jun 2024 09:42:45 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, linux-kernel@vger.kernel.org, hare@suse.de, john.g.garry@oracle.com, gost.dev@samsung.com, yang@os.amperecomputing.com, p.raghav@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, mcgrof@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: <20240604094245.zn5hqezd5q5eoehv@quentin> References: <20240529134509.120826-1-kernel@pankajraghav.com> <20240529134509.120826-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 655241C000A X-Stat-Signature: i4xcxkb9fo5jdynedew3gjsidno8enzp X-Rspam-User: X-HE-Tag: 1717494175-858918 X-HE-Meta: U2FsdGVkX19Nrn4Nq3LZz6KfvEvfkAQEZLDCtvFe6v5Vk7dD+VHhe4e3eAu4m+RoTvIvyfFpOvPAxSKRUE8SmHkIWHne1YPhmgAS+8Wk4H5waevYTCMnJj7o/Ed2bVW77ySECOTW/5IujXUCdqaV52SMwblPohZr0muDX5rahWfQW0dpjCHgo51QaWiYttOQwbatzlTj+GzU+AZ2L9ZCTXya759Jm4oE7FmNg3EIGJtLCYSoKNTs4evlGVpkB559IyItrI0O5k7IY6yH0I4bKraTtXV/JT6579k4i18Z7N1/4hC1g58jyN4Nfz+cSQcprfNcsiPJhRZQIZbWaH0fQR6zGThlgl1+Yd+j2bSCfKhNYhHoRYSJYiESbE1jZ75KUms2GWUs96QsbUjlfz/69tNRV7uaGdsFgeNeSHIKl4QnU48fdO9WW3TW/9UJFSoi6YiZK1/s0MRNxRoCRqSIkszRF6ZynDHSi7+EnrnH65w0mw0Ms/nHHUkdG2QFSIcTmiaGCyR9qtwjDC6iNt5XaIGu2vV+zeVJ0ZZqjeKsrGYib82v/hOj4tKRsCu5W0iEgSWa60rRVyjMtt9+hlAbj2PLC/xdmjFsB6R7yLWWW6SM824eZkILg6ecFgHU9OO+V40tKmFIYv8c3Qo8MNX4AtQTPd8Spn3r0uwcYFcI9PFWpOESdUnUsMVmRmhsD0CXQBQLdeuYYxFOHAb7+d2gDVGmtt00i44RQbOzHapjKacullIrsHPMrvWRwnthGTUaP3/5fKaEvC7pvQcBN/oa+h7OhaCBquBHpA/O99VOHo9x8Sgu+eZvG4gC/e87M3v5JDk50hKHz1FmIF7v09hEDZPSpMGTMElO9kqHcGHVS0Zp9kGxjswmxYjRwDxqEks9Pr7g4RLcc8qONxqRH2iedA311fQ6fF/m5yWn/ci0F7zaEDmp+AlQ6EttjrLAJYj4+ITEZk+/b/e6f4Bz3Cx qJykId8n MrOK0NghaYeYomjQKkPwcZZMk9xJE4+og+Z1zxUxKrbeQtgDFEcxAmKQHbkAuzVWbV6f/xsQz4kvEiuAZ04MCF3xDWXLMU5QvlFi7EdPDUNApDofpOw8CuPerPvbHKVnIlto1CbiaclV6E+ikfdHqCRW2NHFD5tCjaYoe8i8JykiMhgnuiwfR3Kq6SMLHZMeu+/7lP5jDOXb8mcnt8VkvCZzXpzzdLKrLLKqODLXpaY8xwF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 01:18:45PM +0100, Matthew Wilcox wrote: > On Wed, May 29, 2024 at 03:45:01PM +0200, Pankaj Raghav (Samsung) wrote: > > @@ -1919,8 +1921,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > > folio_wait_stable(folio); > > no_page: > > if (!folio && (fgp_flags & FGP_CREAT)) { > > - unsigned order = FGF_GET_ORDER(fgp_flags); > > + unsigned int min_order = mapping_min_folio_order(mapping); > > + unsigned int order = max(min_order, FGF_GET_ORDER(fgp_flags)); > > int err; > > + index = mapping_align_start_index(mapping, index); > > > > if ((fgp_flags & FGP_WRITE) && mapping_can_writeback(mapping)) > > gfp |= __GFP_WRITE; > > @@ -1958,7 +1962,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > > break; > > folio_put(folio); > > folio = NULL; > > - } while (order-- > 0); > > + } while (order-- > min_order); > > I'd argue you also need to change: > > - if (order > 0) > + if (order > min_order) > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > > since that is the last point at which we can fall back. If we can't > immediately allocate a min_order folio, we want to retry, and we > want to warn if we can't get it. That is a good point. It is also a feedback to the admin if they start using LBS and assess the memory requirement based on memory alloc warning? -- Pankaj