From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC48EC25B7E for ; Tue, 4 Jun 2024 06:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B4316B009B; Tue, 4 Jun 2024 02:49:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4648F6B009C; Tue, 4 Jun 2024 02:49:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 305686B00A0; Tue, 4 Jun 2024 02:49:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 123406B009B for ; Tue, 4 Jun 2024 02:49:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B9A2180DB6 for ; Tue, 4 Jun 2024 06:48:59 +0000 (UTC) X-FDA: 82192278798.13.D4CB0FC Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf07.hostedemail.com (Postfix) with ESMTP id B670440009 for ; Tue, 4 Jun 2024 06:48:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KiJcuOEp; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf07.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717483736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QbTrIPhFImjlKnd/ohqIcW3b/iR9Pfpr+J0VPVe1xtU=; b=LlG8/bnpnhVrjMbAbSb+ZGAiwYLxU0mQOX120vRo+3NTIfaHVVtbRWmK+1BviFYECFK9wW VHY2ozJfzByWnmsvCmLZUUBomAH3C1b2hfdupGdrYu6XFun3noIiK6HJGXhkFjKWPE/Uqb KAI7jZPoOza48uzlPQ0vdhZtbneQqnA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KiJcuOEp; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf07.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717483736; a=rsa-sha256; cv=none; b=oixmhDm9KAQ5Wd4Y12Wi/vQlvwWzSC3CKQyUVtn3HYgWeGUmYPwei4GjnG7DrYBQ3PLb8a WnDgAIA7aTuib093jIkoRazMtQjGL/FN4bkBiHN2QHG391QPS7echtZXQgJyh9AeUE1cC6 HWzLHo99FfEvgdhmgGPca9o/IHgUno4= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240604064853euoutp028747f27278b2aac26702e57bedca3915~VulsQwNx21152111521euoutp02i for ; Tue, 4 Jun 2024 06:48:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240604064853euoutp028747f27278b2aac26702e57bedca3915~VulsQwNx21152111521euoutp02i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1717483733; bh=QbTrIPhFImjlKnd/ohqIcW3b/iR9Pfpr+J0VPVe1xtU=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=KiJcuOEp0bmxzmLWz26L/CKL9Uy1Jrkh2EThm1VuZfJKp/W5MYRnq8MC6Y4QqDQz4 S+gBnPR7KqdRUcFuAx1RehG0Ue2fsvKxjMnA62wYwIBPE8cyDwnzyjP4IHKZGYEdaw 9Vxmz12NHonqKK0YOlJz2FwJOYsBbPEknfqGyC5U= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20240604064852eucas1p1d00075de5770a5fa8593c734aef9db91~Vulr3Drz81683916839eucas1p1C; Tue, 4 Jun 2024 06:48:52 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id F8.C4.09875.4D8BE566; Tue, 4 Jun 2024 07:48:52 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240604064852eucas1p2db69f8d2d13b82887fbb3a4dd535c024~Vulra1_of1670216702eucas1p2K; Tue, 4 Jun 2024 06:48:52 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240604064852eusmtrp1071da7d58997076776fcc54baf4f28c8~VulrZuwRy1417014170eusmtrp1I; Tue, 4 Jun 2024 06:48:52 +0000 (GMT) X-AuditID: cbfec7f4-131ff70000002693-87-665eb8d42702 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7E.87.08810.4D8BE566; Tue, 4 Jun 2024 07:48:52 +0100 (BST) Received: from CAMSVWEXC01.scsc.local (unknown [106.1.227.71]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240604064852eusmtip1d292ba451e2cc73f72b5fe4a618458fc~VulrNK7321516115161eusmtip1R; Tue, 4 Jun 2024 06:48:52 +0000 (GMT) Received: from localhost (106.210.248.71) by CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 Jun 2024 07:48:51 +0100 Date: Tue, 4 Jun 2024 08:48:47 +0200 From: Joel Granados To: Jakub Kicinski , Paolo Abeni , Eric Dumazet , "David S. Miller" CC: Luis Chamberlain , Kees Cook , , , , Subject: Re: [PATCH 3/8] sysctl: Remove check for sentinel element in ctl_table arrays Message-ID: <20240604064847.4os2h42bj3cg6ptl@joelS2.panther.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240604-jag-sysctl_remset-v1-3-2df7ecdba0bd@samsung.com> X-Originating-IP: [106.210.248.71] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUwTURSF8zoz7VAtmRa0N6AgdYuoKEpw4orGZaJiNMbdII0MSwQ0U4u7 4o6tEqAgSpVUolbLEjMS4oq2xDaIYdEacWviGlQUShVxSbV0cPn33XfPefeel0diigoihEzL 3Mxymep0lViK19i/NY11XklIHu/yjqJPNR3A6Tf2lxL6nj6Dbq7JJegbN+tx+sG1U2LaVfGL oFvz3iDabhpIdze0ozgpY8xuwZnqi49FjInXMrzliJjhuwokTEftQzHj4cMWS1ZLpyax6WlZ LDdueqI0lbfUiTd5pFu7PDlYNmogdSiABCoGeMtxiQ5JSQV1AUFpURESis8IblV1E0LhQbDv V4/oj8Ww14gLDTMCy7sq9Ff1pPasWCguI2gzvyB6LTg1DD7xd/12MTUGmtqfYb2iYKoQgfN5 qX8IRt1GcMLl8quCqJVgtRr8LKPiQFdhxASWQ/3J13gvY76bTNe7fONIH4eC2euPFEDNgzNf jH27qsDa0oELvAsq7ff8UYE6HACFukpCaMyGvOzDmMBB8N5RLRF4EDQYjuKCweB7Dm9nn7sc wfm9X/pGTIEDztd9jplwOqdO1LsRUIHQ+lEuLBoIBTXFmHAsg5xDCkE9Aspd7XgeGlryX7SS /6KV/ItmQpgFKVmtJiOF1UzIZLdEadQZGm1mStT6jRk88n2oBq/j8xVkfu+OsiERiWwISEwV LMvdvSZZIUtSb9vOchvXcdp0VmNDoSSuUsqGJ4WzCipFvZndwLKbWO5PV0QGhGSLipWdr/Al nZfSTEvpujTP4MZIjyQ2CVIjrOvuFC6zL3iI5kdY7Q+S14Zt6dBONoSX6XpWrl44qYy7vqGt bH+WLObqKvdH5dvmOSXh7mnnh14Ywti+ypVUTv9jcSmDSiOseqs9/pFeHhSSoMdD5/ItH3aw gd9mO9OZ78Oejpwc614UzfFzTtcb3iUYssZNit41a3kzufO4jagcHq8vXkDcGB07NtFBjvnR r6dt2Yx25ytiYePTi2tES/fg536aHR0f3EXBYXeDqu6Y8w2OajLfCO7y2rfXqgcv6n7RvD8x XhYjP6sZ0Dg+knsWPOI5mft1yLHdqfcfH5zoWlHgNaHWQhWuSVVHR2KcRv0b5vVlPL8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t/xu7pXdsSlGcw/wW0x53wLi8XTY4/Y Lc5051pc2NbHarFn70kWi8u75rBZ3Fvzn9XixoSnjBbHFohZfDv9htGBy2N2w0UWjy0rbzJ5 LNhU6rFpVSebx6ZPk9g93u+7yubxeZNcAHuUnk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6RiaWe obF5rJWRqZK+nU1Kak5mWWqRvl2CXsamVYfZCj5zVXz63MHcwHiao4uRk0NCwERicuNsli5G Lg4hgaWMEq8+PmaBSMhIbPxylRXCFpb4c62LDaLoI6PEqVtNUB2bGSXOPHsFVsUioCLxbtMp JhCbTUBH4vybO8wgRSICUxglXrxZwg7iMAscYJSYce8eWJWwQITEwYOTwWxeAQeJrjWzmSHG XmeU2PZ1BlRCUOLkzCdgRzEDjV2w+xPQIRxAtrTE8n9gT3AKuEss/DqbCeJWJYmDF99D/VAr 8er+bsYJjMKzkEyahWTSLIRJCxiZVzGKpJYW56bnFhvqFSfmFpfmpesl5+duYgRG6bZjPzfv YJz36qPeIUYmDsZDjBIczEoivH110WlCvCmJlVWpRfnxRaU5qcWHGE2BgTGRWUo0OR+YJvJK 4g3NDEwNTcwsDUwtzYyVxHk9CzoShQTSE0tSs1NTC1KLYPqYODilGpiSmxraVvFr3flXfCSr zH26gLjZvjaTNV5LrppqPDy/5H/k8YNsQSWTnUTmLy1PivznfGAH8wNGG2b5PxN493l8Lgo9 +9K0zGZx31UV6wchCoHrJ/2VEOTyerjs55k5C2IXXe892Ro9Z+NyppU3th2b4ij++4HYpDkz omNexexbeibkl6RIwXHOefdYlxR72J6crzzxdqXFld0TmXSbYzfyHV74K9vslIHJu8Cqz0Xz libnrRDv2i0t+OzUulPJGTeOXeEoNeB2S6+fXqF0Iz5tluWdSQ4vWIVcL7tYl/w/XtgitK/p +rqjYV5fZhz65tG/7qnZ11gHBpbfL7RLWCJapXpdN7Htj3T4tOzkcsbtSizFGYmGWsxFxYkA DqYi+FsDAAA= X-CMS-MailID: 20240604064852eucas1p2db69f8d2d13b82887fbb3a4dd535c024 X-Msg-Generator: CA X-RootMTR: 20240604063005eucas1p2a0ea8cbe2d925b1e63f0854f719d0b01 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240604063005eucas1p2a0ea8cbe2d925b1e63f0854f719d0b01 References: <20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@samsung.com> <20240604-jag-sysctl_remset-v1-3-2df7ecdba0bd@samsung.com> X-Rspamd-Queue-Id: B670440009 X-Stat-Signature: caoreioixntiyq36yri46rfezd63996t X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717483735-161143 X-HE-Meta: U2FsdGVkX19DO7sHqT1NKxffbmjQWNJNaAXzEudEtxktf0XwTiom/qbU+qixE/6veb6tRlsVeX1ylOvsLVeo4wwcCNId+IrzMC0cZ2bJHkHrBCVBqZlm1CAZItlHGnK6ytFoQ+R+hbKtgsduxJyTFzlPovw0zqZmGE3J3iyFLJF1ORVFxOEVFkDCvbkfKdyTUL2ny4+BMyh2hbPCzS8HiHJUJoGSLCSaTMtJ5dYW1QwPtlew6mTb2gnzx7n16ze5xq+q3zkHYCtTsUI/9EGARYJk1nVYQE6r4CfjJETTRHnh5FecSmbVsvWsrw7svZidhTi8jX24R33RY8A6EtTg47HwSXZ1e0u7F+3ke5kbjHTTu+dkNpJ8JrL2albQf4t+ZuZ1luJHrb+kZ1s1aCuMWriNOqXXP7Ckxt0kQD4mpK7URS86nNfzMjvShR+2aLXWGdzb5Ztxbkf/ScPZMWptizINvhpYkH/gbBnrQ4doYk/qi2zuiI+FfGO0C0WHuNaHAZcnkRy9lCcbYdDB39OXjAYGtnJ+GWjs/tH39AyTmW+akgNTk0gABPq4u61Nc1B2gKbpdqFeX06SeAmdvqzGhDubfDQC+mCTkvrms5t8zAKSJRqn1U0ygQeDg4JHKZR2DffmbXNHsKPWmmQAwasvCseuW/tJMDYvFBcwOsrUPMV4p4iETnFtmP4Fj+sdT0IYZ5amV88ukXfrjHUYV1qD9I2hJ2F5QAW/STasmN84DLJsfkks5Ynw9plAZbtO92+XOpzhpDvObM1lpGodu9weFrizgMOjLt0uyfChQroUTtmQTQS9NjL5kebehN8djD+qhX9uMnVbkr7FePEmZ3r1R2F8FX6ciqBwxYxRQ5bvYLW96pjgrvUITuWOvc+1qzqpNhvyNLxTSqlB7oc07YIIFvdR3NSISPqhUFOBVTTe4eUu7UUG1gJYBNZChSsWMEkuVZD+ronBBPDSYdF07Pd MN2dunq6 xrq7u9nrgf0v8hq0ZJ2gVqDhkPY24grJ+7DbKZYHOUNSNpia0wrFNeKFej51YF46qEV5QVpN1gQobgDu782VgOaU6ZYTUg7gvW7myMeAPiN2cZWKlO1ut12nK/m8n/Mj/hBrXw37fHS5SudOwcOpz0vGPgCMu+ujdaRagIb5BdihW7ZE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 04, 2024 at 08:29:21AM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > --- a/net/sysctl_net.c > +++ b/net/sysctl_net.c > @@ -127,7 +127,7 @@ static void ensure_safe_net_sysctl(struct net *net, const char *path, > > pr_debug("Registering net sysctl (net %p): %s\n", net, path); > ent = table; > - for (size_t i = 0; i < table_size && ent->procname; ent++, i++) { > + for (size_t i = 0; i < table_size; ent++, i++) { > unsigned long addr; > const char *where; > > @@ -165,17 +165,10 @@ struct ctl_table_header *register_net_sysctl_sz(struct net *net, > struct ctl_table *table, > size_t table_size) > { > - int count; > - struct ctl_table *entry; > - > if (!net_eq(net, &init_net)) > ensure_safe_net_sysctl(net, path, table, table_size); > > - entry = table; > - for (count = 0 ; count < table_size && entry->procname; entry++, count++) > - ; > - > - return __register_sysctl_table(&net->sysctls, path, table, count); > + return __register_sysctl_table(&net->sysctls, path, table, table_size); > } > EXPORT_SYMBOL_GPL(register_net_sysctl_sz); > Given that this is a very small network related patch, I'm queueing this in through the sysctl-next branch. Please let me know if you would rather take it through the networking workflow. Best -- Joel Granados