From: alexs@kernel.org
To: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
izik.eidus@ravellosystems.com, willy@infradead.org,
aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com,
david@redhat.com
Cc: "Alex Shi (tencent)" <alexs@kernel.org>
Subject: [PATCH 04/10] mm/ksm: add identical_folio func
Date: Tue, 4 Jun 2024 12:24:46 +0800 [thread overview]
Message-ID: <20240604042454.2012091-5-alexs@kernel.org> (raw)
In-Reply-To: <20240604042454.2012091-1-alexs@kernel.org>
From: "Alex Shi (tencent)" <alexs@kernel.org>
To replace pages_identical() func and further reduce the 'page' using in
try_to_merge_one_page function.
Signed-off-by: Alex Shi (tencent) <alexs@kernel.org>
---
include/linux/mm.h | 17 +++++++++++++++++
mm/ksm.c | 2 +-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 9849dfda44d4..2d1f16ffc6ac 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -4164,6 +4164,23 @@ static inline void setup_nr_node_ids(void) {}
extern int memcmp_pages(struct page *page1, struct page *page2);
+static inline int identical_folio(struct folio *folio1, struct folio *folio2)
+{
+ int i, nr1, nr2, ret = 0;
+
+ nr1 = folio_nr_pages(folio1);
+ nr2 = folio_nr_pages(folio2);
+ if (nr1 != nr2)
+ return 0;
+
+ for (i = 0; i < nr1; i++) {
+ ret = memcmp_pages(folio_page(folio1, i), folio_page(folio2, i));
+ if (ret)
+ break;
+ }
+
+ return !ret;
+}
static inline int pages_identical(struct page *page1, struct page *page2)
{
return !memcmp_pages(page1, page2);
diff --git a/mm/ksm.c b/mm/ksm.c
index 21bfa9bfb210..2e4790842515 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -1527,7 +1527,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, struct folio *folio
if (!folio_test_dirty(folio))
folio_set_dirty(folio);
err = 0;
- } else if (pages_identical(page, kpage))
+ } else if (identical_folio(folio, kfolio))
err = replace_page(vma, page, kpage, orig_pte);
}
--
2.43.0
next prev parent reply other threads:[~2024-06-04 4:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 4:24 [PATCH 00/10] use folio in ksm alexs
2024-06-04 4:24 ` [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page alexs
2024-06-04 8:07 ` David Hildenbrand
2024-06-04 10:26 ` Alex Shi
2024-06-04 10:45 ` David Hildenbrand
2024-06-04 13:02 ` Alex Shi
2024-06-05 7:26 ` David Hildenbrand
2024-06-05 9:10 ` Alex Shi
2024-06-05 9:14 ` David Hildenbrand
2024-06-05 9:49 ` Alex Shi
2024-06-05 10:00 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 02/10] mm/ksm: skip subpages of compound pages alexs
2024-06-04 8:12 ` David Hildenbrand
2024-06-04 10:31 ` Alex Shi
2024-06-04 10:43 ` David Hildenbrand
2024-06-04 13:10 ` Alex Shi
2024-06-04 13:14 ` David Hildenbrand
2024-06-05 3:58 ` Alex Shi
2024-06-05 7:40 ` David Hildenbrand
2024-06-05 3:52 ` Matthew Wilcox
2024-06-05 6:14 ` Alex Shi
2024-06-05 7:47 ` David Hildenbrand
2024-06-05 21:12 ` Matthew Wilcox
2024-06-06 7:11 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 03/10] mm/ksm: use folio in try_to_merge_one_page alexs
2024-06-04 8:19 ` David Hildenbrand
2024-06-05 3:38 ` Alex Shi
2024-06-04 4:24 ` alexs [this message]
2024-06-04 8:25 ` [PATCH 04/10] mm/ksm: add identical_folio func David Hildenbrand
2024-06-04 4:24 ` [PATCH 05/10] mm/ksm: use folio in stable_tree_search alexs
2024-06-04 4:24 ` [PATCH 06/10] mm/ksm: remove page_stable_node alexs
2024-06-04 4:24 ` [PATCH 07/10] mm/ksm: use folio in unstable_tree_search_insert alexs
2024-06-04 4:24 ` [PATCH 08/10] mm/ksm: use folio in try_to_merge_xx serie funcs alexs
2024-06-04 4:24 ` [PATCH 09/10] mm/ksm: calc_checksum for folio alexs
2024-06-04 13:18 ` David Hildenbrand
2024-06-05 3:44 ` Alex Shi
2024-06-05 7:53 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 10/10] m/ksm: use folio in ksm scan path alexs
2024-06-04 13:28 ` [PATCH 00/10] use folio in ksm David Hildenbrand
2024-06-05 3:46 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604042454.2012091-5-alexs@kernel.org \
--to=alexs@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox