From: alexs@kernel.org
To: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
izik.eidus@ravellosystems.com, willy@infradead.org,
aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com,
david@redhat.com
Cc: "Alex Shi (tencent)" <alexs@kernel.org>
Subject: [PATCH 02/10] mm/ksm: skip subpages of compound pages
Date: Tue, 4 Jun 2024 12:24:44 +0800 [thread overview]
Message-ID: <20240604042454.2012091-3-alexs@kernel.org> (raw)
In-Reply-To: <20240604042454.2012091-1-alexs@kernel.org>
From: "Alex Shi (tencent)" <alexs@kernel.org>
When a folio isn't fit for KSM, the subpages are unlikely to be good,
So let's skip the rest page checking to save some actions.
Signed-off-by: Alex Shi (tencent) <alexs@kernel.org>
---
mm/ksm.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/mm/ksm.c b/mm/ksm.c
index 97e5b41f8c4b..e2fdb9dd98e2 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -2644,6 +2644,8 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page)
goto no_vmas;
for_each_vma(vmi, vma) {
+ int nr = 1;
+
if (!(vma->vm_flags & VM_MERGEABLE))
continue;
if (ksm_scan.address < vma->vm_start)
@@ -2660,6 +2662,9 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page)
cond_resched();
continue;
}
+
+ VM_WARN_ON(PageTail(*page));
+ nr = compound_nr(*page);
if (is_zone_device_page(*page))
goto next_page;
if (PageAnon(*page)) {
@@ -2672,7 +2677,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page)
if (should_skip_rmap_item(*page, rmap_item))
goto next_page;
- ksm_scan.address += PAGE_SIZE;
+ ksm_scan.address += nr * PAGE_SIZE;
} else
put_page(*page);
mmap_read_unlock(mm);
@@ -2680,7 +2685,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page)
}
next_page:
put_page(*page);
- ksm_scan.address += PAGE_SIZE;
+ ksm_scan.address += nr * PAGE_SIZE;
cond_resched();
}
}
--
2.43.0
next prev parent reply other threads:[~2024-06-04 4:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 4:24 [PATCH 00/10] use folio in ksm alexs
2024-06-04 4:24 ` [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page alexs
2024-06-04 8:07 ` David Hildenbrand
2024-06-04 10:26 ` Alex Shi
2024-06-04 10:45 ` David Hildenbrand
2024-06-04 13:02 ` Alex Shi
2024-06-05 7:26 ` David Hildenbrand
2024-06-05 9:10 ` Alex Shi
2024-06-05 9:14 ` David Hildenbrand
2024-06-05 9:49 ` Alex Shi
2024-06-05 10:00 ` David Hildenbrand
2024-06-04 4:24 ` alexs [this message]
2024-06-04 8:12 ` [PATCH 02/10] mm/ksm: skip subpages of compound pages David Hildenbrand
2024-06-04 10:31 ` Alex Shi
2024-06-04 10:43 ` David Hildenbrand
2024-06-04 13:10 ` Alex Shi
2024-06-04 13:14 ` David Hildenbrand
2024-06-05 3:58 ` Alex Shi
2024-06-05 7:40 ` David Hildenbrand
2024-06-05 3:52 ` Matthew Wilcox
2024-06-05 6:14 ` Alex Shi
2024-06-05 7:47 ` David Hildenbrand
2024-06-05 21:12 ` Matthew Wilcox
2024-06-06 7:11 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 03/10] mm/ksm: use folio in try_to_merge_one_page alexs
2024-06-04 8:19 ` David Hildenbrand
2024-06-05 3:38 ` Alex Shi
2024-06-04 4:24 ` [PATCH 04/10] mm/ksm: add identical_folio func alexs
2024-06-04 8:25 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 05/10] mm/ksm: use folio in stable_tree_search alexs
2024-06-04 4:24 ` [PATCH 06/10] mm/ksm: remove page_stable_node alexs
2024-06-04 4:24 ` [PATCH 07/10] mm/ksm: use folio in unstable_tree_search_insert alexs
2024-06-04 4:24 ` [PATCH 08/10] mm/ksm: use folio in try_to_merge_xx serie funcs alexs
2024-06-04 4:24 ` [PATCH 09/10] mm/ksm: calc_checksum for folio alexs
2024-06-04 13:18 ` David Hildenbrand
2024-06-05 3:44 ` Alex Shi
2024-06-05 7:53 ` David Hildenbrand
2024-06-04 4:24 ` [PATCH 10/10] m/ksm: use folio in ksm scan path alexs
2024-06-04 13:28 ` [PATCH 00/10] use folio in ksm David Hildenbrand
2024-06-05 3:46 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604042454.2012091-3-alexs@kernel.org \
--to=alexs@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox