From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16804C25B75 for ; Mon, 3 Jun 2024 22:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665C46B008A; Mon, 3 Jun 2024 18:00:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 616276B0092; Mon, 3 Jun 2024 18:00:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 467E96B0093; Mon, 3 Jun 2024 18:00:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 22B3F6B008A for ; Mon, 3 Jun 2024 18:00:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55BD81209C9 for ; Mon, 3 Jun 2024 22:00:38 +0000 (UTC) X-FDA: 82190947356.19.032BA82 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 986A7A000E for ; Mon, 3 Jun 2024 22:00:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JWil5/qF"; spf=pass (imf25.hostedemail.com: domain of helgaas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717452036; a=rsa-sha256; cv=none; b=a1umXtUoHcv9sYxoFGdaxhcMpx7EAN9blEsN7xcLHP9Yf8vw1H7fb078u68m+ejJ4zyw8a /YptjaE7/k2GXn9V4cHhU6CMS/Jb20os/SYI62CKoqoyoSf7qTUrejoHxBWeyiIMzFWWWy yvvpYZvBQTdJJ+7CzBJo4sc0Mg3v45c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JWil5/qF"; spf=pass (imf25.hostedemail.com: domain of helgaas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717452036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=8KkjefmtEin39SqnU6sUi3qVDiir10Z9IsOx4lfUUgs=; b=KO8iz9d2UqkERM3RHKeH3fNt+O8A4amYAJMMjHTOHfizZREjby0yfzw8Oh0P6Z2fHIrDuv N9sNyyH2ZXyAiZTwwV8w62YUIrDcLmLkPXhWoxvOjuRhVc5S74reCF8cYAFTSIRu0k1rdF 7QQ9iFO7p7vKNwc4rkJEej/vgSruoQ0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8C50D60ED0; Mon, 3 Jun 2024 22:00:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54BDEC2BD10; Mon, 3 Jun 2024 22:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717452035; bh=ZMS/4Gp6hXyd9fPwx/y5x+q7VhsaGgJvMHFGFXB2aCI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JWil5/qFuymosoPDATfZqx6FJDnMlkeS59q6fSB+oGtZnzLWlZsOYK17IUuX1oHS1 +ZGbOlO5XGTxStebKzleLLdP/ku6ByksYgWD6+z1Mv7KGjnwR3GMzWiuZo1J++YQBe YnonzpNdWoLK+5fnowMqG8M5MeJ10EV/gsKGvDpIY4wVIBC1HO+F/kfe8gBd+/QboZ BrnDQ+EAlvw7Yi4J9eZ6M1GbDt3y6+iqhqMKYxUzNtAOVfJ3SN/iHY1B0HdRGk77/Z OryQ3BNvB0McYwdX86nz7FOZKP/BNHRMgHpGVTqXr+aaBtJCcPNM0ORUNnE3rDopfE 4lfytT5yAufhQ== Date: Mon, 3 Jun 2024 17:00:32 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Linus Walleij , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, qat-linux@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Howells , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Sergey Shtylyov , Damien Le Moal , Niklas Cassel , Daniel Scally , Sakari Ailus , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Heiko Stuebner , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Viresh Kumar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Karol Herbst , Lyude Paul , Danilo Krummrich , Jean Delvare , Alexander Shishkin , Pavel Machek , Chen-Yu Tsai , Jernej Skrabec , Tony Lindgren , Adrian Hunter , Hu Ziji , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Potnuri Bharat Teja , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miri Korenblit , Kalle Valo , Mahesh J Salgaonkar , Oliver O'Halloran , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , JC Kuo , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Sebastian Reichel , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thinh Nguyen , Helge Deller , Brian Foster , Zhihao Cheng , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Masami Hiramatsu , Mathieu Desnoyers , Jason Baron , Jim Cromie , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Linus Torvalds Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() Message-ID: <20240603220032.GA701908@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 986A7A000E X-Stat-Signature: 713s648h66gen5c1ptbons6m1mqjrjud X-HE-Tag: 1717452036-103620 X-HE-Meta: U2FsdGVkX1/fyGJniJxCexvPQ06ay/YAGDav8cckO6Jt7EYEn+DZgqaVrojham1TMPAqCkqCR1PymIzAAZVEkKPIfTaDfjEdi+6gRCDnrokSzgNO3rTSFWwvJx13ZGEiU1Sl93/7admOD+CmA/P3Qsc84ont37wzGDj7rM31L/+GIRZvb+4Ou/VSBjRcSWPRkh0HcVoSxR6E7Xla5nMqYqlSe3Ii7JF/8HFQ8KavJoiYE/hVnOxtY0895QgsuyNZtpSSX4L5QtLRsOF0RdxqVmsYAktHgcMrYzGOEVuPL1GXov6rXxdNaUO8YOtEFrAOPGkc071fLf/Nj3zc8Rf5/JubW117PqlbuVZCFI57+aOy9uQUcrSV9MovNsDXMAArK1aihNcVrbd5v8O6vvdC2aVcUIfR/dRixRsILplELrUDigj/VUc5C/cNz9MzStozseZ+x+P2Y/mudWhSzwCDkHcFuJ2YzxqeHOQAYQoHNBy4T18WrJu7PnBOYh8kCgwzEzfapeY9P0VlF62EdbAsH4XgJ0+dCPeKOPNZEJvjHgHZNdp9Ii0gI3+6mLO8n8hsk4A7sCocereKchUiDq5AVdoh4+jAtFbY/rBEAS5PzrGa1pujwuzSoPV659HOPQaRCSca3ofR4n6vhxsUwHqjqZak0XVLwFAqyphQmh/V4zsYPPJQuO6i3BHk7E4+Co1grl8Aynkf+LYh23oBAL3YX7A3YJKN1pkJ7E5egG5ufH2tLJcEQxYoMlk8SE3DjIgiFv/OUPPz6nSvcphuQkPK8mXNdJkS0+zYNLNjKf23DIv5XLfU0JrgqnuaJbuoeO48EOvzbTDs//sHoTmX44nT4uxas0xpMqf983OXk8FzOBHJcrPUwkPV5fHCeC2BbS0KV8KR5uowkrqnL/0FQHP/++h/Lmi6M2Wk9g28rQdXTj+dN7zdGsN7DE73ANBYf392CBJEZ40x1sQ2/VDu0Bd Whiy5Gwu wSY0b1MZM/adTyRVVhej49NnnTmtY+Kepd/x8e5eSaJH7yN1S4Oeklp6M9vlYqZbBNmztAOU+IOkS1sWrIv85v1DRBd3I3fVL7170+CA/4KJVwEgbDq8JcK7KJEdSQuKuhsft5pPpzrLToZwc2jh6eYbgmojSznSFeHH6rUWKENPz3j6P3nuTzEU50V1slXk8yD+io0bk/dHpqQU35kE70AC5R7J/m4AWEUlw7ArBYQzd2LhqyMqnF9ecgfxpY/wFWUENJsXlJJhVrXCQ+WgLolHDvimFsnUJvxu7kqNf7KMzkDKkmTjoqdJSUnpFXPGTfta99f03m3VcHB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. Looks nice, thanks for doing this. > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index ac6293c24976..2d317c7e1cea 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -210,7 +210,7 @@ void pcie_ecrc_get_policy(char *str) > { > int i; > > - i = match_string(ecrc_policy_str, ARRAY_SIZE(ecrc_policy_str), str); > + i = match_string(ecrc_policy_str, str); > if (i < 0) > return; > Acked-by: Bjorn Helgaas # drivers/pci/ > +++ b/mm/vmpressure.c > @@ -388,7 +388,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg, > > /* Find required level */ > token = strsep(&spec, ","); > - ret = match_string(vmpressure_str_levels, VMPRESSURE_NUM_LEVELS, token); > + ret = match_string(vmpressure_str_levels, token); VMPRESSURE_NUM_LEVELS looks like it's no longer used? > if (ret < 0) > goto out; > level = ret; > @@ -396,7 +396,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg, > /* Find optional mode */ > token = strsep(&spec, ","); > if (token) { > - ret = match_string(vmpressure_str_modes, VMPRESSURE_NUM_MODES, token); > + ret = match_string(vmpressure_str_modes, token); Ditto. > if (ret < 0) > goto out; > mode = ret;