From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D68C25B74 for ; Sun, 2 Jun 2024 16:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1646B00AB; Sun, 2 Jun 2024 12:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 671656B00AC; Sun, 2 Jun 2024 12:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 587776B00AD; Sun, 2 Jun 2024 12:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3BA3D6B00AB for ; Sun, 2 Jun 2024 12:46:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B0904C0166 for ; Sun, 2 Jun 2024 16:46:41 +0000 (UTC) X-FDA: 82186527402.30.FDBA853 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf02.hostedemail.com (Postfix) with ESMTP id EE8EF80008 for ; Sun, 2 Jun 2024 16:46:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="jot/jPjy"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717346799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2dCtbnnfQWclfkwRSPQuobTTd4YMUEiBxYzzT835GQ0=; b=A7pDogqZyFEnBgYmv32H7qbVQhWAEZSyosWw6CNKkITnV9t1bc8TgbypHP/f5uN4ZIWCTp tGV7F8E4Uu31iY3FJjTyZFAsi+1CaRFDYgtf5GjTFqp/DFGPEh0YNfkO62hon6vZ0h4zMC 3cOBsanq4Juvh9pqWzbq2spUBvHDqeM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717346799; a=rsa-sha256; cv=none; b=ZRMV9Z8RZ1fRqDynsR/gET1VSll4no6QxQqkARBSh7JeFLJnEN3+XumuFuCEyC58vuHJrq ouHqyD3pN+4v1D7Roih8+4NDQtDhcR2CQN4NlYHRfBy4cE2Pu/qm+NKjkcV8QbrK2bH45H siPKzRkYDypUToZg2UuQ0NzvIK6TJkQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="jot/jPjy"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717346799; x=1748882799; h=date:from:to:cc:subject:message-id:mime-version; bh=bC+HnFGaIzp5PtVweCl5HmtZJ0zXKg7XamEODVzoPh4=; b=jot/jPjySBjqj7G5IQwetbzcv/wbPITPk7+/RopK4zqCOL4fiUF2JXCC bbSWT3fDu+c5Ro0HrDT9WKnofadJ23LfLnAV63e++CMHAum6PFBYMv/iK O5KpKcSyEyRky7HjCss4uqrx5A/iAac4+4QgOCNi2DmnRbBPtgAdblMzE j7lO+873C9HAGXZDhTvuI6ds12B2qauvZD60VGHT3dCTW8qr4o5IKAZq5 /U/4W+VZjiJgY5RcP+3RT13U5ERAwNXoR9yicqUoAvrOU1Fljneorb/0I iRf+jLGt+THoj66/BLgxSSfGMfo3n8XM4JECVfrIPC7rHzoK4E1rtttnE w==; X-CSE-ConnectionGUID: 76e1uC3jSfeFKbsvlEkAXA== X-CSE-MsgGUID: l3TGmTgLRlS7+JDZEKxxJQ== X-IronPort-AV: E=McAfee;i="6600,9927,11091"; a="17664603" X-IronPort-AV: E=Sophos;i="6.08,209,1712646000"; d="scan'208";a="17664603" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2024 09:46:38 -0700 X-CSE-ConnectionGUID: XJ9Lw5bqScy61K7NHaLGZg== X-CSE-MsgGUID: KUPrfC47SsCkan2xbgnS8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,209,1712646000"; d="scan'208";a="36558456" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by fmviesa007.fm.intel.com with ESMTP; 02 Jun 2024 09:46:36 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sDoLp-000KB3-1g; Sun, 02 Jun 2024 16:46:33 +0000 Date: Mon, 3 Jun 2024 00:46:08 +0800 From: kernel test robot To: Kuan-Wei Chiu Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Ian Rogers Subject: [akpm-mm:mm-nonmm-unstable 38/65] fs/bcachefs/clock.c:150:18-21: Unneeded variable: "ret". Return "NULL" on line 164 Message-ID: <202406030001.jwsq6DZp-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: ie1jfy43hnitqqxq5uwceocnjafqw7st X-Rspamd-Queue-Id: EE8EF80008 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717346798-92560 X-HE-Meta: U2FsdGVkX1+YadMXH1IxTaF4K4BqypQB5JCULERWG0P9jgmu8XpHKPdV0aco8vRkyhQiXGnOaBmL53y+fdorf9eKgUgmG6sASi0YONb1TJr2D4yQrL9NwvNnS7R+l/IQs3KVXCKmYvmz82OOy1S1bbLLLroOR33H/O587+hFH+dDLURlKiwTfH+MMJl6trcuRO2D5jvtXlmp1VszKwsAy9fD2rBXyYePsWiwZy0bmi5PrObOJJC6UAJBSpzlh2eggMKUlQsCsL3GGtoWjrfCxdleMaLT5REBAHwE2g2u5OwkgfdYp27uVtsik+NOES4cX1NFvy0Lne5hvJBBAC1RPWlcSJzRwNilo6pwO/vup8RKQEs+H+6kVcOVd96vhMlrd7lWc4nhCJN3Jw26648yWtwVl2iKzQEu/ono7Ql2WsD9oXnboiiiNxrDHtGB7u3wcSeuvlD/a0gY9ZCo2uOs6dFXRpVYuYDJg13MMNHA0dxi/mqaghJnn+1Ab8lj2zPdmCimz3L5vTariwvqGlBig6A35r3Y2Hdtdlv2A3ujwkeYdI/KWXvcVDwX5dA74+E97+GSpV6Sxjmk6/ek3+9lSZzr/a00WdGJm2sS+OeOi7JKQwnMZ/7JYWUahDJ2hiVHBjviDBz3H+ddxfYdYmTn0tI/iUIcDwHxYn5CTVG4JBdrn5CIjeWbvzPojpUbPs2uI/ERlQNRHsNteb/u/ZNzjZtLFuNKlm5tbPJOOEpt1X3yJD9GCGcDB1mebojNCF3tIPyfCrllrKLN5vBVlLH6jyj6kYrUAwug7qkwaz7VKusBbr7xTM3xzSxR1QTBuaeIam/gefAfd9SKHYDHtcmIXp2phhnXwrvqNBgVwG0ympfe4iPaDMIoKmbaleT3WHYFt4vAbrO4zEuR8FPcIcJuLN2q9ihhiTICOH6HWb3NZxLwq51TG/sFWY0vwaTW6T2yynu3amaSPwSLpIrY++s OZih9xBC wlA9an0gILaLVrAwbRUnunNinVlxWVdqeCtsxX3jhEQ5CgBCfHZ6sjw9dpJYNiWV1WFo1NouxIj7vEMi022O9rXW1K+8M69pJVlW6yEmb/zoUodC5CFfNNRQkeWCu6HwbryEUC+m0noQC391faBYbboLdUcnJP204JhbBPVqtBkgFpHwE6CBkyeJWsv7t7vhfSW0MHlxTjdY1VDr1g+nL47hEEMIYO5JmIlglFCabN2VpcVX/68Rz21ZQN6XMM0LU2bQAhTThelweJ/JwY9W+5yFptFLMe0DYmQEd9A4DabivjfEDZwE06q+FWsOBaeuOkhxj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable head: 54524b845fbe070c5401141bc4ff2ec3f01f1e72 commit: cf66e6c3b24c5aaf365c54bb7dc8b9cb01f47f4d [38/65] bcachefs: remove heap-related macros and switch to generic min_heap config: x86_64-randconfig-102-20240602 (https://download.01.org/0day-ci/archive/20240603/202406030001.jwsq6DZp-lkp@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202406030001.jwsq6DZp-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> fs/bcachefs/clock.c:150:18-21: Unneeded variable: "ret". Return "NULL" on line 164 vim +150 fs/bcachefs/clock.c 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 146 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 147 static struct io_timer *get_expired_timer(struct io_clock *clock, 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 148 unsigned long now) 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 149 { 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 @150 struct io_timer *ret = NULL; cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 151 const struct min_heap_callbacks callbacks = { cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 152 .less = io_timer_cmp, cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 153 .swp = io_timer_swp, cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 154 }; 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 155 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 156 spin_lock(&clock->timer_lock); 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 157 cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 158 if (clock->timers.nr && 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 159 time_after_eq(now, clock->timers.data[0]->expire)) cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 160 min_heap_pop(&clock->timers, &callbacks, NULL); 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 161 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 162 spin_unlock(&clock->timer_lock); 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 163 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 @164 return ret; 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 165 } 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 166 :::::: The code at line 150 was first introduced by commit :::::: 1c6fdbd8f2465ddfb73a01ec620cbf3d14044e1a bcachefs: Initial commit :::::: TO: Kent Overstreet :::::: CC: Kent Overstreet -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki