From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4014C25B75 for ; Mon, 3 Jun 2024 14:35:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5EAC6B008A; Mon, 3 Jun 2024 10:35:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F1B6B008C; Mon, 3 Jun 2024 10:35:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFDC26B0092; Mon, 3 Jun 2024 10:35:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B3B356B008A for ; Mon, 3 Jun 2024 10:35:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 36598A1279 for ; Mon, 3 Jun 2024 14:35:46 +0000 (UTC) X-FDA: 82189826292.20.EE579C2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 7285E1C0018 for ; Mon, 3 Jun 2024 14:35:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p2B4CV+M; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717425343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fTAhiUT3l5zwhDHkCcxTM5kJ0Q6iueNIMEi7kP9IeUw=; b=lbC3CgUHHS5DGiGierL52h0lwuAsxRzq4k8d7Dmr2Y7iQ9kegV26Bufri0jBBPa1KjcvY0 IEOfiPOCsTCGvpPgPRwBQuAKOWAakke5CliPm21ioFK7Knl1vW61XkysDBKjZ87HhUhCMP w0cxTdS6aQIx7dlNmfcDXrt2/JHMtYA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p2B4CV+M; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717425343; a=rsa-sha256; cv=none; b=gdrJL2HejFEoRD7SP4/sxTXvag9+GlVnJ7OZFT+KnjVCOnl3eAwFCeuj/szsxvfL8CmRtA /zj9bYjamKtrL59kOf+ZBQrURb1RnyRkkFxL7eDp572trPXHEIAvULCntu3opmezfp6LI1 EFlMw+eSboIC8e1nXs+M/wJsZlTPPX8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7218C60EAA; Mon, 3 Jun 2024 14:35:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7866C32781; Mon, 3 Jun 2024 14:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717425342; bh=gXDxGgjsqZPij10gds5fIA4zMBd03zCzjfopUpR6A9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p2B4CV+M/UAZb8IY71evyjcLfpRcAydjClLqgG4S5Bh4jlhQUpqeH4eibFp8umofE PEIZUfDFfQwdz9wgNmSSuymFdo9XkP5xTzBdCCPjcU0DkCVADyGMwTKCg3HoleiFW/ y9zhlEMOVfHXqlCj7Y3j4Yt886xTjgNa18/Up6VaFpWuKTVBFP9r+Z4XjwDRa+0BDm tHQoI5Wae5FCKm5CbvAUxFFYNZviCPSYgJHdsSXksYQPO3oUi33kHzk5hQPFuEXD9T JC47CEd4IQoVkI0KOIesbnOLH+5IO88+imiNyPJPvC+zv1ZQS1NW+0By9nsxhKX2rw RFkfQI78RhZYw== From: Christian Brauner To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Hugh Dickins , linux-mm@kvack.org, Mikulas Patocka Subject: Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR Date: Mon, 3 Jun 2024 16:35:33 +0200 Message-ID: <20240603-fixkosten-ansehen-af907fa0a056@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240515221044.590-1-jack@suse.cz> References: <20240515221044.590-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1564; i=brauner@kernel.org; h=from:subject:message-id; bh=gXDxGgjsqZPij10gds5fIA4zMBd03zCzjfopUpR6A9A=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTFXtm+9VCbwJRPzV/damfpn2aYb37ulRfDLoHrF8Lj8 za99Zv7qKOUhUGMi0FWTJHFod0kXG45T8Vmo0wNmDmsTCBDGLg4BWAiJsoM/4ybFawfeLX9e8Cj 3LPgiMbk1Ox1+wqCfe/67mZU8BYXb2Nk+Fq4+ecWgx1GGxKvsxYUb2Q4NMFF7hL/GXErp4oj25X ZmAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Stat-Signature: p3nmf77pzix3uzqy5bn3rm8r8am8ggxs X-Rspamd-Queue-Id: 7285E1C0018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717425343-177150 X-HE-Meta: U2FsdGVkX1+ocfr6f4PjaajvMQf9nBv7cxSA3hnn0YOfOGAQpGT89kIEwvs5f53u3UbYYfilzaL4dhuRzpAXXD4f3wOl+W+wEwvMIGJzGGiyPVRh2RrJtc25y1m7j0Bi/bVSVMmlrf20QDbC8RQ9jGyVLAO21fF5XHgGMW/peFhE0PNEIXaecLAJqPpCnAgaP09nAR/3YSs+tgC/oy6gYDuruJKXUu5eRGNKU2DnhFBnYFCWtF0jU/JBng7eqLOiw45fYArGyuGdAAUWGTWLQ85663CdHmiszGxbzSXRQo0Ftln/HDFU810c/eKAs59sfaZ2QIjGjivLLGJqmhwEZhK8elte8fOP4C+yJ+0mYXm0F0gc80Z81N7Xst8om9sDTNItr9xg9lBTQqxmi4U1u+Tc1Y6jwM5nQ6nFu6YDi2ZueF2zkKvCZ/PlCTj42itzrqWPyycLkDEKNaEjuvqnr2YLXXBrYcMC8Mq6xtNY8O2yoWeA98VfKHEIcn7Yy8s6V4nrJpaLvpBRUom96ieiBdsGM6h2r7pWfcO6pXdGLN0Ucc3Y+bZmN+3mG55gmLDLPSLGVX1VGXAJVl6EuyzAblnHbEwumiwlzcQqIB6OV0DMsoM3qow2WVdU9JP6Mmal5iuEL8wm4i3umxpu+deo3VjjH2GPlBRFK3+yQN3TNQDWwnr79jG+rd/pPsDg5rf78SxR7TNeHX/cVlvOL1iLfe2M+9DvRu+kkmiW0nKjz2O4PAkRaNlqjuRf5AwSjQzo0cEG3mV23mbYdmlQfTfO3rzjc1hcrwVqq1Lq2pIwojs5MxSwFl5Pdd/Zrd3RbhdNYtNEmYKiP+pyYIzGJzF3N+c0wTmmjtd2D03MfA9bp/Y2aYkP5/4qevt3FwZZy73zV3qaopyjFmmUnNVrbAUi/DvksI2ivFOlsv63BQAkql7WJGKkeeAJ2kqQJH+ceMmZ5sLArkCUCyC+bw6pqgr GoJoIsDQ YS71dovXLTHKRm6/xJNv569Zx7LkxbedKswwNdDJ9Upcn/IvNL7JrRU1Bem/rw7/RDGgEtl7VjdXWd3KZGCUnpGmEXRWJCfzznrvM6dEVKFOSf1MRPB0jurIqBy6nOOh0HBS4+q09CD1YIQOqe6VGJi0xT2rX+uHRylD2soK32kjxV0krAlQl76clZLY0jGEXsg5/pkFHHQFt9tz4/7frngvbaX2UCGO8pWjzqD8uk/kLnqW094NU4EQ1Iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 May 2024 00:10:44 +0200, Jan Kara wrote: > I have a program that sets up a periodic timer with 10ms interval. When > the program attempts to call fallocate(2) on tmpfs, it goes into an > infinite loop. fallocate(2) takes longer than 10ms, so it gets > interrupted by a signal and it returns EINTR. On EINTR, the fallocate > call is restarted, going into the same loop again. > > Let's change the signal_pending() check in shmem_fallocate() loop to > fatal_signal_pending(). This solves the problem of shmem_fallocate() > constantly restarting. Since most other filesystem's fallocate methods > don't react to signals, it is unlikely userspace really relies on timely > delivery of non-fatal signals while fallocate is running. Also the > comment before the signal check: > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] tmpfs: don't interrupt fallocate with EINTR https://git.kernel.org/vfs/vfs/c/f113ef08b6bd