From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66515C27C44 for ; Sun, 2 Jun 2024 12:00:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C44686B009A; Sun, 2 Jun 2024 08:00:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8976B009E; Sun, 2 Jun 2024 08:00:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A46186B00A0; Sun, 2 Jun 2024 08:00:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7EFC16B009A for ; Sun, 2 Jun 2024 08:00:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AACDC140459 for ; Sun, 2 Jun 2024 12:00:25 +0000 (UTC) X-FDA: 82185806010.04.ACAFABD Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf11.hostedemail.com (Postfix) with ESMTP id D303C40018 for ; Sun, 2 Jun 2024 12:00:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R5PlTd64; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717329623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XL/a/t0HNCjbSIN7BOvuvI2I2oiI7guAXKEDmSOgeTg=; b=sEHa8bk5Lyy7E8varNWURup0y26PR/X/VP4MCzKw9GR/QK10HcWSjC1XHWo9DutgieUc9w CKZ57l3u6OAzgRHolFkvADeObt+TG8QlE8/IWUzJZZ9qWcbDtzoYxr8fYIdTpuTC45kI4f +wL+NXVYzHKvT/BO49apqAGckYndn10= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R5PlTd64; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717329623; a=rsa-sha256; cv=none; b=mxrJLLxwAnTi7oTYcnRyAuhjB9Gt537/M2YYnbLa5Hxl0twaKKNOF+cVyVRn8S56kgl8FT /w8woKFJfDNvX+FQ9m6g9KZU+CtInwWo3u10oWPWsfCytYNjimA83fadUP+EXrTvBY867z jVWaQdi2HQqTWY+PcCsai4t8HZsrCY0= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f47f07aceaso19827135ad.0 for ; Sun, 02 Jun 2024 05:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717329621; x=1717934421; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XL/a/t0HNCjbSIN7BOvuvI2I2oiI7guAXKEDmSOgeTg=; b=R5PlTd64CdEkdYiZQ+P7H+rVC+LvPjEZdj4Ss6SwGc9aHSW/6wzO7VaeIr45oaTSEy G5kLioM79SXUKLNZLgXCpMYbCJ+F/+fdSfN4iMYcpbq2vReGDoglXAD1WLhQZXIm3aSP WSM3k84UXhuiijwFO1plhkhvry0rdliEVSZyf56xFDVL4o4yCo6WdaBzUgP2HS7o78C8 PH8PcXKGEB7Maut81tSR9rmu4m3NNKSUV9e3/AG+8RUX5JE5XZjSDMxYlWtP99I0PT5j gstrWP41/XHVkyC8PP3GmyR/FY+txrCFMiGBervEvOz0Tf4PlEA/LkoA/a/qVLHeFehl 85+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717329621; x=1717934421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XL/a/t0HNCjbSIN7BOvuvI2I2oiI7guAXKEDmSOgeTg=; b=YriaB82jmu2QfvKppSVlms+OtzTtc2lcP2ljYqFTC/sdJ5Zq49Lel3rKKhJlnBS6Ms B74dLr3Y47j3/WOUtdO7kYOJ0KwRFxIgdBM3TsNPXMtNiBW6+qEx+LNNB3LbVTWs36mo UevP+x9zd8kTpjEPaLBa7vR0DOU0U2LeYsuHdtQMIv/U3ExnfHpCk94sXUnk6ZpFA1p1 7Sawexz+ZRPbX7qKflrmBV9bxSRxcNrPpgZJ2pYtzDnbDwYuCn3fJnHAFVvHGYk139d/ iWsayafMDp70CAp7/69V19jRkW5MuBtKUBdiRng7+H6b7QMkrmHG+dgYo9WeUzAZ3BZb Qu7w== X-Forwarded-Encrypted: i=1; AJvYcCWxfn1vKZbCScrPU9nLvrHdw0kro657G1XZiVZrf3cSyyisOWJrxY3A8rx/JDL9XRxbaiEihMU5a/bG0mTpFgmQ6XQ= X-Gm-Message-State: AOJu0Yy/eNs6VFa9ZciyfTFHTAjbT0pwolDHjeLNRRETb4kSuqA/pUes ST0SVie7hGuSbnnwzPbg9ji4wl1JA1eh5FZvSrDLXDitFTeLPVJ+ X-Google-Smtp-Source: AGHT+IF8WFkaK3EXTkxUu6gRPru1fAOvWM2c0mlQjQmyQnj2zt8/lLuvAtw7w0j0TNqvI1WsRBkJKw== X-Received: by 2002:a17:902:dac1:b0:1f6:1c1f:f31f with SMTP id d9443c01a7336-1f6370bf132mr85003295ad.64.1717329619913; Sun, 02 Jun 2024 05:00:19 -0700 (PDT) Received: from LancedeMBP.lan.lan ([2403:2c80:6::3038]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323f6d97sm45919145ad.218.2024.06.02.05.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:00:19 -0700 (PDT) From: Lance Yang To: roman.gushchin@linux.dev Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, shakeel.butt@linux.dev, willy@infradead.org, Lance Yang Subject: Re: [PATCH v1 13/14] mm: memcg: put cgroup v1-related members of task_struct under config option Date: Sun, 2 Jun 2024 20:00:04 +0800 Message-Id: <20240602120004.62824-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20240528214435.3125304-4-roman.gushchin@linux.dev> References: <20240528214435.3125304-4-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D303C40018 X-Stat-Signature: znj6c98gfod4ejp4ftqya1drkwpctxkc X-HE-Tag: 1717329623-680418 X-HE-Meta: U2FsdGVkX1804UK29jEvUEL1vZZlNYtCE+lZ4n1YhOIO94CevpHxCO9MOcs8WiIhbTEpTTUbp7tsXQyMHTcAuJyzo6fAwRWMWEX4eWmOe1X27Eeu4lfTZadsXbqJrABgTk9aCB/tN0X7CjuDPDNcaD57sxZlYfP5vLN532/oY534GTtfPwhMENzSWPlS4Pyie8fw8igWAONYlfqT1BpQFmvC5O9pKLufeTGGZL3OQiQP1PTjzlweVE1wXpYzft9aKMwHyr6Z+nxOipsDFtdL0FNqCmvZe2Y4g42Daaj+CZIpR5BR2/p0RJmQ6PEYeFv4SeavoONdKaxoHd4eaeAV9DfrM6ggj2L5mReH6fbOeQH1DGQTfBLH4TDvREbuvx4H0OWOkomJAG9Wif6VjzgBHrdMnMxIdc8S3/3Rc014+RkC/v8dmn5ZiXB7v4pxqYA2YzhG+6jCUus+luu27+U/flQq7u/8inSQNRn0TtoBJE+CMHEoZlc7estz0WG6sSaC6zznFlpxIbTwqX0U6t1SGOMbdq06NoH96ZBk7Q8Z9BGbjNK1b2+2whAk+1IDOZXA7BO+lXQANU4glbkghcFUGSzIjQG/eMtB4GJv2tM/K/9qUvJGqVpsJngJSDTRXH789pKBWjwAVzMhZoxdc3A76MRsGFdGojefpMMhbA+Qyi7dICPawGrrf+Et1PntP3DL5mZ/jZwx3VxuD9ZTarfe/mV3OpWRrGkb0cQflVvhxcMie/n9wtVTC4LYvP9wBWBL2y6zV/0v8RzJ3IuomcLBPgL1DsbSzsWP/KBnPjYcKUtm0w5Wp1Eg7hWftH+ft4YRxeQ05BWmqqBsKn7//DRYPa4OYKxjuv2fSw2PNKx9vqVtuod5IM/EYds3B91uHCM7/5M/81j/sUkaigsnbCJeey2kteGM0iZh2yr7h3tBW/oBKzkfwCeE6OnHscE5Vk95o4c1KmmuBoyD3afhYk0 JorAd7HS UV1f5l1V5EF+0dKY2jFD1WdaaCYbLz3fd+mFEXo51ho4oD0Tsb8ffUad7iQCTFfO3RMLmQhIZEpVkGpVh1DXZMTrznhAnfLHF3qDg2lsJs7aVJUueqElCdlyWiS3sudnBZ7XlR3znAe2Jjm2GxUNKanJzAALZ0oyEeH+wkdGQrBD0b3WO4CZM/MSbJfuc0knxsVuX61//MF2TtlUI39aQeTDs+pnymE3O1eD5Pare5QzT337uyibwgopqtS8t7575fiUSJ5vl9VKCBG2iQv5zTiayCExZFVp35gQZ5F0sykVARQ+UURLCzSWqHZwlbO7Ytj3hKalT4iayqR4EoYsKaRGFB6EaPePnYheRAXACg/9T3HcOZ6DP0bh9n/5Mokdfk098uGTAlIN9vQW9WdPQ7OP4aOq5scd1rUj+BnL3csSopsfddLITsDv2D4BtJzJsRd3ytpErNkab/Jn+lCBY8kJEwZD7NZXKj3To3O9gjFFZMYYohsnDgd8S46KNdGiqJHvV9LPmlj3ZViw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Roman, I noticed that you changed '#ifdef CONFIG_MEMCG' to '#ifdef CONFIG_MEMCG_V1'. However, it seems like the comments for the corresponding #else and #endif were not updated accordingly. It might be something like: diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index ba55ebd15354..796cfa842346 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1883,7 +1883,7 @@ static inline void mem_cgroup_unlock_pages(void) rcu_read_unlock(); } -#else /* CONFIG_MEMCG */ +#else /* CONFIG_MEMCG_V1 */ static inline unsigned long memcg1_soft_limit_reclaim(pg_data_t *pgdat, int order, gfp_t gfp_mask, @@ -1922,6 +1922,6 @@ static inline bool mem_cgroup_oom_synchronize(bool wait) return false; } -#endif /* CONFIG_MEMCG */ +#endif /* CONFIG_MEMCG_V1 */ #endif /* _LINUX_MEMCONTROL_H */ --- Thanks, Lance