From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531ECC25B76 for ; Sun, 2 Jun 2024 00:58:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9986C6B009A; Sat, 1 Jun 2024 20:58:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 948956B009E; Sat, 1 Jun 2024 20:58:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8104C6B00A0; Sat, 1 Jun 2024 20:58:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 648436B009A for ; Sat, 1 Jun 2024 20:58:26 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ED3CC40D58 for ; Sun, 2 Jun 2024 00:58:25 +0000 (UTC) X-FDA: 82184137770.09.052CDE9 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 089E6C0003 for ; Sun, 2 Jun 2024 00:58:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CE+ra9+B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717289904; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bncXwu8Ax8ha+4C6GSyOUQkQDhDK9jzy+ZqGYdikJW8=; b=NcS8puJHkgeEK81V46nMRxG35Xdx+/nFAcIWF2BCFff7aPg+rMSiAKVlOYBrauRX1gBgcq tTti9hYJeyYn1w9olhcG/WRMwpPS9M60DuUqHNcZ6GOEMdRBf6EngubGjZYxqeKFZwdW68 Tic+R5K8nNkbGG8mus3nzYh38WclKyc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CE+ra9+B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717289904; a=rsa-sha256; cv=none; b=Ny5ICIpYQkOxLrW5VOQV/SPvaO0yBG1RwHQrPrQBWuompl0SiAPwnzFYJ1/2Texi9FMoPO ss3e42+6CVGHckrCLlbd7a+Zpwect1ww9RWfomNbZ5E9gGz6iJwsA0YJYMtgCDx4xyTNcc T0ixnJoYcJ+C2c6/iesX60Q1Pa2a//s= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a68ee841138so13900766b.1 for ; Sat, 01 Jun 2024 17:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717289902; x=1717894702; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bncXwu8Ax8ha+4C6GSyOUQkQDhDK9jzy+ZqGYdikJW8=; b=CE+ra9+Bd9ujXS+bKNEnb13jdpMcV4aOuU3oT6qlcpTqoIvtsyaTkgMLZe7oeVwxdu T4FLHat5s94bkuYHVgXiZTJu0cJr0HaSQKx80L/90lfJUB8Xty5UVh/vMVj04G1bqhsA 0/aw2iCE04lOc6rojYU4Dyn8Hb9Qy79wiN4gu4GhqjrLprNQI/bdjLKyFv6GVZvU/Kj9 S6/UcOXw0rcxaY7CEP0U4FfjLQU07BzlNbefBjBB15L2vsZS+y0Z43SbmiNQVkAaPqlW pLRzzzc9gRU49CiqkjPjWve3zMnTlcv9BQRcB6GvCvCA5grnPYCzHbpzP8WI5yzySYN9 gjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717289902; x=1717894702; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bncXwu8Ax8ha+4C6GSyOUQkQDhDK9jzy+ZqGYdikJW8=; b=sfJj3o/622I5XPmj3y71s1BThtp1SIl+DlrLsynWrKRKc2M132A4A4401uF9/U4lHN iMyMqtqyHez+CPv6cQvsYyr843OXciNXcLsvL828hbuoB9pPkfNf5wM5r81LsXlpGHu0 xKjjAyN/HsafPtECB/4UN1T+wp2j/x+jl96x29ROo2qL/SF9pRxIxpwOaLc5Q9f84hWo GlhZVy/GmVQ7nQcTm5tpYF/1Pur8T/wVPt5drW2MrZvrm7I9TU41JWzEdnWb9p7aRdvi ecRQpiRfQQoxR7oFV+cYcqqVPiqM7PLafcAauT/hs5/AmJRc6t88Gx3Xt4Opj5yt4HsC NcqQ== X-Forwarded-Encrypted: i=1; AJvYcCUIFSzbhIK2vFHgTMB5ts004sLGhJKUJ/hmZM5w7XLLw8ABNQjmhiOM0PB+C23RPyKDZ0VYd22IwKQdduQ0NXPYAx8= X-Gm-Message-State: AOJu0Yx7ziDkp6HuyQF1UPDl0DHTqU1FsI1LFxJAazNgQOfrRwdf6M8g JSa5tIaDTYpzTRE5GfRYfxwttptEWvglzaUfJ/h73nFO2Vsj8j3e X-Google-Smtp-Source: AGHT+IGuX4iXy64p11VQivxEBb+/cU50YeWleJzXZ9ZbbrDg/gIOB5H7eWgWmMk646enio+3cZLZGg== X-Received: by 2002:a17:906:5fd4:b0:a66:2265:2bc7 with SMTP id a640c23a62f3a-a6821b71ebcmr355188666b.47.1717289902166; Sat, 01 Jun 2024 17:58:22 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a67e6f02dfdsm259191366b.26.2024.06.01.17.58.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jun 2024 17:58:21 -0700 (PDT) Date: Sun, 2 Jun 2024 00:58:21 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org Subject: Re: [PATCH] mm: increase totalram_pages on freeing to buddy system Message-ID: <20240602005820.2uk23ot4mskfl5sl@master> Reply-To: Wei Yang References: <20240601133402.2675-1-richard.weiyang@gmail.com> <0316a276-a0d8-4fc2-ad67-0d4732b6d89b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 089E6C0003 X-Stat-Signature: 8e1mo6msz4fkax1iwbyge1sm5wp7s37g X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717289903-249410 X-HE-Meta: U2FsdGVkX18CWxoV5FjsmOMptsq91oxGFzfETK8LYL/XObhtvlJkSLwTCObDTd83aVRNzo3P+nY5N5eJWzoym2G6uc0QRS1qt8J6XVjicBfEyZt1SUwYykVrxV1iVyNzdt4s3F72RxUFR8swuzja2kPx81C7FtQG10iXSNQynwFhKrZReWDOOzAI/iG7mDTGEjKxvGcRvDaJqzQElHiwSxw0fiPVzL7pQrl3hKRnGln5fIp3CM59encYL1XTpXNM8XRD18ooUnTiGwJrAQq8WZ7ZSw9gLib45kjf3itMC8uxmtO7ndHMNTE+k1THDJXYCRHbhFxYi5lx3Xd59RaosyxHO9RFIpv+ctymg4j+8oe6sYGJKZs73MEg8Md9aGTwzrSTszWdYrR15NIO/eN5ZTkl65GI3CtahIxjlIuJhCbBmmVXeG19+1BKqk46xzvyyoao9m2vnzOgM+hbsFpw6YrSODVdSiGbr7FyYqtffsZw8SkxGrKFuSa0nhK1uI/Yx+duW+vnyNG8WZs2rjLNOYESqxyJejltamvVCnxu+/UJyhy6EREWB0NfXqTaDpHnnW3xETlVl8+Kpl2jhe8H/wwdaP4sXJc56mbFu8iN+ca5t0LCYMW2OnSVZ1pWMHT4ulAnAsRo2APaYIKxqbFOufD3EJtE2zIoPCT7wBsUlRO8LJs+MYqgMP/KmyriYEnWbsT1g/V1iD8V7TNwrUkZUO0cl8Wjj5v/pzxa+aqYk2cs3u7ch9/0kPERn1rYFOz4FH3+uXzvyP/5FqDnsSlQrcmQgPT/fTW0LzvvOjeQ+V/DKDFfnqELEOU3EfPCJAx6Jrv7jDg/KYqpcWmYZfcIKrFKzNlreUiiLH//rNUGkKbhbyusq6d8zAnJd1eQtKeCzLeI0qEL/OifjS9BFvzYkgLRDtorkuAxEk8ST+veDbRDp37c3ucPdt1UtEdI4/bDDdPz8hjweOhhi2AL/iG Au7FyAde jkSGoAGzFdmn9r1OayUCJUGXFfUdspoD/AkccwnmQfchqeiso+hLFct+LK2os36BwooQQ/LQxRpvYMB6tuN6f58jdCYianbHdB2HG7iqJBdDjhuH9te5AZZ098E41SAAEnkZ5PF3xpwTZvYrcyi8VeWjvvzlft9RvwzJ7/PtOgwo99WZfaVALZHm1sjATJyuOd20FtHrTl8C41GbeTpJ3kNzDFbcmfspWFd3bYkJ5w/9hb2vgiONtpsnhRXAdkmG2dfjUAODOiWgxIzhwlGdY+ew1bqf5PUfmJPdBWB2IwSDhOh88OnWG9dg79KVZMdpWnXgdBBgv1KXJCDUE3Qft9J5o1/oyyWmsiEuyVHVkWIGw6muuAY3Qj2qzxA8a17axDVsTjBOoZYcMlAQcjP+0YcCENjUMVVSqLh6cZoLUCwm0Jhr9Xi83fuJ+aySSyIBxZU+wWTanKc9ESSrFfPm5TSN9SVl1X+WrYe2CkxN9N9MIAltZA6Sghbl9Q1Uoqr70oZOkR4MXwgz5F5QCyzf2Rrm1RBkDhfk0vOaDekYan4Xap882O+Q9VeTYtryVRnC0KRIkhTfCxqKiRWTjGFB1Zr6rsqyfAsg9H169Bb9/piSfoiO+hrNr77f8XMOqwBKQwm7Mln1QZdCoQ5YxmBf/T1OYD8Gjx+ZSGnPfdU6n1krkTnfrlXdNkkw/8tjuqERyRfjkRfsECM7EM5Vf6iwqWii+hzwKyl6iEJ2shtz5Vlguiak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 01, 2024 at 06:15:33PM +0200, David Hildenbrand wrote: >On 01.06.24 17:32, David Hildenbrand wrote: >> On 01.06.24 15:34, Wei Yang wrote: >> > Total memory represents pages managed by buddy system. >> >> No, that's managed pages. >> >> > After the >> > introduction of DEFERRED_STRUCT_PAGE_INIT, it may count the pages before >> > being managed. >> > >> >> I recall one reason that is done, so other subsystem know the total >> memory size even before deferred init is done. >> >> > free_low_memory_core_early() returns number of pages for all free pages, >> > even at this moment only early initialized pages are freed to buddy >> > system. This means the total memory at this moment is not correct. >> > >> > Let's increase it when pages are freed to buddy system. >> >> I'm missing the "why", and the very first sentence of this patch is wrong. > >Correction: your statement was correct :) That's why >adjust_managed_page_count() adjusts that as well. > >__free_pages_core() only adjusts managed page count, because it assumes >totalram has already been adjusted early during boot. > >The reason we have this split for now, I think, is because of subsystems that >call totalram_pages() during init. > >So the "why" question remains, because this change has the potential to break >other stuff. > Thanks, I didn't notice this. >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me