From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA74C25B76 for ; Sat, 1 Jun 2024 23:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B46B6B0092; Sat, 1 Jun 2024 19:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 064A06B0098; Sat, 1 Jun 2024 19:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94786B009A; Sat, 1 Jun 2024 19:38:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C629D6B0092 for ; Sat, 1 Jun 2024 19:38:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7536AA0191 for ; Sat, 1 Jun 2024 23:38:37 +0000 (UTC) X-FDA: 82183936674.02.D170041 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf20.hostedemail.com (Postfix) with ESMTP id D63B01C000B for ; Sat, 1 Jun 2024 23:38:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dDTjGYBn; spf=pass (imf20.hostedemail.com: domain of 3-rBbZgYKCAUxzwjsglttlqj.htrqnsz2-rrp0fhp.twl@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3-rBbZgYKCAUxzwjsglttlqj.htrqnsz2-rrp0fhp.twl@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717285115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=kZYI7szeEV/JGCAfsUUNi2/D4wUrEpjRfowLgkGTZlA=; b=dkECS598QqiVSDphi3Fk6qsBfeC7kSJfZiAd9UjmS2jGq2rLF8j2H8E23VIuobrUJkuTs9 cv+fFFnKdvlaMmvHopqgvwFGCHFMzdaP79utIMk9Uz/i+mI5yqRtho7c9QjdUHnlj6rvOS BCbAA+L1E0fpljZFFYNE44TFzHPrlXU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717285115; a=rsa-sha256; cv=none; b=SqZW/zGUyEZXJaPKvKh+PU3YSM40ERqr3jvj8CZC3Ucjv8quRqw7lHQwUukCs8sItH3GJ2 nxim0XLsxQ9hXG0fPvjBg0xpGFR9N+sj+XXTMD+7GT4JVwiRszB6P4E7of95qtoPo2bAe1 cODOlEV2n198OYrkGPEzPzRuuMixjJ4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dDTjGYBn; spf=pass (imf20.hostedemail.com: domain of 3-rBbZgYKCAUxzwjsglttlqj.htrqnsz2-rrp0fhp.twl@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3-rBbZgYKCAUxzwjsglttlqj.htrqnsz2-rrp0fhp.twl@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-df78fddad5dso6386178276.2 for ; Sat, 01 Jun 2024 16:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717285115; x=1717889915; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=kZYI7szeEV/JGCAfsUUNi2/D4wUrEpjRfowLgkGTZlA=; b=dDTjGYBnziRCMzsNN8hunGTe7DnHqwlNgrAB4dLb/4TdCSHINTEq4j5FifJseGkFby PqRx2Nvwrh9BUcRbp7IiOKHBDV+mE/YkbJtinevniaDqPbsaqFRkyhOtKAmeuTv1UcG5 FGFcRUF4lNGJGoIi/WbV6Jr58tdSF/kGhfeIWbf2Q6ki/P2TD56NUgU5T6BTihh7dIPR 9fz5eBoKeogBhy2PFdNCttUWEJHbXATNT8DVhvu+2Sx41PqWUyd5F6oFgywoq5nNUNKo lu+u2DwFcU5ssjIpyXFh+DZyWji3KUYtqDBwDzEQbBmXyYTmrYp21bXk4epf6FjmpCfC kHtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717285115; x=1717889915; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kZYI7szeEV/JGCAfsUUNi2/D4wUrEpjRfowLgkGTZlA=; b=arpm3CDiEqroW9kCBQNzQq+QdUgUFzYyJCMi9LwtAhfWru3oqkczG40Uqnf/GFyRD/ RUpcHzp0UoldANTKEXpUFLMK6bngw+tFcFRpNpqQ8GNNaeTUL2Arj/T0Nu8J5CHbSOUb fh3IH/dSzWT1hGB7CBqc4QxQK26yM4OJKTUbnGiA23KtBJZLA4OOOE+bKU8vk97g3N99 n0mBCxD+tMCeVs8tzvxrkvQY1saag5/8pjha9PQSkDwLkzvwwJbsTlUU5LRI0QTDR0P2 RNA7LcayJX36X9QP6ZOF833ABOqB08p0rIExK/5aFnfSWzs0s/gGtMmh00Pj9zfkYOBl z83w== X-Forwarded-Encrypted: i=1; AJvYcCV3EXgmzqoJLebCnWNnGoo5V8crLi2seSm1a3h72lZAnwC+BHsOJZVcQOW3dzyE0MjkCzrY+/7JB9Fyzdd+w23OhGM= X-Gm-Message-State: AOJu0YxLtQG7u3q/e3QFwndLOYg+xSqhe9PKBn+6dzOaPfQCU5Boxp6Y bvcCtr01FTJGyDCqpXlBXbeLvOP8LTqQkwa/m3vADzm+HBbImfoWtWsHQM2tHLOcY4G/9sZEE4Z JvQ== X-Google-Smtp-Source: AGHT+IGc0EzkS4huRPd+zXDTXGm4OldrghJAUs34M6l7DcRfqwVB2dZkEWz0x5Ey8il+XQ4f1eJpCGyyUt0= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:81fd:fd40:a37b:76d1]) (user=surenb job=sendgmr) by 2002:a25:6910:0:b0:dc9:c54e:c5eb with SMTP id 3f1490d57ef6-dfa73c3429bmr1273251276.7.1717285114740; Sat, 01 Jun 2024 16:38:34 -0700 (PDT) Date: Sat, 1 Jun 2024 16:38:31 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.45.1.288.g0e0cd299f1-goog Message-ID: <20240601233831.617124-1-surenb@google.com> Subject: [PATCH 1/1] lib/alloc_tag: do not register sysctl interface when CONFIG_SYSCTL=n From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, pasha.tatashin@soleen.com, vbabka@suse.cz, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 1an7q6ngbuze69z74g9ewqi4hioyf9zf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D63B01C000B X-HE-Tag: 1717285115-852955 X-HE-Meta: U2FsdGVkX19USodvg45Gd0khM3hUcqucs99hPw8Tgd2cJg0/8m/3Cxia+lqCQUKwXI/dfXD33ypgI6yBmLktThCjrqFZp0RuLUUHrAvNhTyFyb/H9KlnuuCZbprGkKsF19T94niDVaVfD+rCdXrMhN5YsY/H9eEGp5zBU7gCTD3GdoxFTf0onlW3fpJzKFLOiV3GlQkLbSAs1s0SZRFOH88k/1b/mGPlFIqgaU39MZwqwFKLewUsJM2vzZ8Z6emLJqxYKkdKDzal+GDgctXdBZ0Ry5kAiCR1+g+DlgY8VtXpLYSmqvOHJLFk0D7xSfnwbrZ9Q/4kOtgivPc+9XNVTpNHMGqHnrP5pdev/IM17n70Xwx3F2pSSKrAwVaHtG2FxiEB6AJMOxit+AQAneSGvJdDrFOoqHvwhKnjAmv4tqXqcof+FJ4Xj/x4s05o8oZ9xiRr2Vlb5Ia4wZc3q9lGu7VKpxjRO5sHzZToagZhOgYJKMGoWx7tauYAcfguCrgcWKojzqMOexTnZagfqWhL+VQ1cCuwxDP1RZ0v+w7HxShlI2B0AfoU4U8hMuJ6N7jZYd1TddFxwgJDHrU5ds5GIdZ5PZffLAqfSQxKt9rxEf8XknfF3zTJCi3irpabN+X8VE5dVq73yPaQyZKbb7lmBI7L4AIl9mTPdQtL9ybfQJ6CUVudCbUDxvWXx6D6JJypUg4csTP34owNQdPsA9Tbepyrnc5MjHrg4D40MpGY2591kzpKeOIU2qhUNmvWWGK/3myfpKkeHwrS8VQ6UuHlOCbNfGRGINptoWirEwTq0gX3eahud5Khzc81iIDTN9wkUiIyYsojvRrh3Tljc6cFRw5aCIBY+zrL5Kmp1hdHKWg+FmoA0BXHW16IXVpHtKL3lq4iNoql7BohLsvosTe1FdaC03gT9YtyhCiiW14PIFN4XwaTJJCOd1593Y+/lXJCfMMxMET0BDeS8QvFFWo lbTlNOwU VgR74WDAnY6DJkOnJ0AFv/OXtn9SkRrc9wUYhQ1sYJP0lk4aJNvbbREIt7/JuJWzk6ZfJCXTg8vLpTan1lHZ6YynaGUn0ZzwkGCrID5bxux9JMGpKl5TFo/ZeYGXOUoJYIHUEGC+SF+MqfOf4ubaScu9Ovh6uUsUKKhgMNfvximdznmKORYzvbbwG+fysgc8RX08AEYPPD1UaqYeEk9DExdxcNds9fIZS5BhjUdCsMx59/9eCsU1fo+2ttzWQ5Zw/Vh5XJ17GGYtYJNj/kEQhnY7M6KsGur4lZ4UAYVgnvEsHndBUwReBWSAXzAZEWoROIg+hsJ6aXorXXa4JVYUMuLATSODC6y9PMm3hIgt96BZjlNNEaqqW8pOvOoDxF6h4SEKoIqfUdipoJpDPPDxsDwSYrWAoG6nZd2d67oSTh/5S3W0Jt7HIhq1/KQCW7apGeUtcsaoV6ZdJBs2RWaMz154nlHIr+x1B+Nqd31RGOB8cLYCqD/6s2caIsr22Uz24b5PHZGrHtmF6LeTQ6+6TzGa4n3nr9MhgjyDUJfDLt8uQj9jHboUw9NfGmAY5stoJtOTWCcrx/v/6TE628uNQOqNRZdz/Wnqxq/FCtDk8YkdEtTJd0GPPICoYsu8+s7qgke0wm2TUBR0JK/fL0t51iVy5pfQIQCmlQAybwFHx29hfQjeua30pu5aP/AiFK63JwBornkwOAOHM3N8Gk/aTGQXbbQxIqdBc+v7ZAVRTnYAuXvk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memory allocation profiling is trying to register sysctl interface even when CONFIG_SYSCTL=n, resulting in proc_do_static_key() being undefined. Prevent that by skipping sysctl registration for such configurations. Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allocation profiling") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202405280616.wcOGWJEj-lkp@intel.com/ Signed-off-by: Suren Baghdasaryan Cc: Kent Overstreet --- lib/alloc_tag.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index 11ed973ac359..c347b8b72d78 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -227,6 +227,7 @@ struct page_ext_operations page_alloc_tagging_ops = { }; EXPORT_SYMBOL(page_alloc_tagging_ops); +#ifdef CONFIG_SYSCTL static struct ctl_table memory_allocation_profiling_sysctls[] = { { .procname = "mem_profiling", @@ -241,6 +242,17 @@ static struct ctl_table memory_allocation_profiling_sysctls[] = { { } }; +static void __init sysctl_init(void) +{ + if (!mem_profiling_support) + memory_allocation_profiling_sysctls[0].mode = 0444; + + register_sysctl_init("vm", memory_allocation_profiling_sysctls); +} +#else /* CONFIG_SYSCTL */ +static inline void sysctl_init(void) {} +#endif /* CONFIG_SYSCTL */ + static int __init alloc_tag_init(void) { const struct codetag_type_desc desc = { @@ -253,9 +265,7 @@ static int __init alloc_tag_init(void) if (IS_ERR(alloc_tag_cttype)) return PTR_ERR(alloc_tag_cttype); - if (!mem_profiling_support) - memory_allocation_profiling_sysctls[0].mode = 0444; - register_sysctl_init("vm", memory_allocation_profiling_sysctls); + sysctl_init(); procfs_init(); return 0; base-commit: 065d3634d60843b8e338d405b844cc7f2e5e1c66 -- 2.45.1.288.g0e0cd299f1-goog