From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF6CC25B76 for ; Sat, 1 Jun 2024 14:09:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69FC76B009E; Sat, 1 Jun 2024 10:09:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629366B00A0; Sat, 1 Jun 2024 10:09:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F05A6B00A1; Sat, 1 Jun 2024 10:09:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 315506B009E for ; Sat, 1 Jun 2024 10:09:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B99DA140E5E for ; Sat, 1 Jun 2024 14:09:42 +0000 (UTC) X-FDA: 82182503004.11.76E717B Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf18.hostedemail.com (Postfix) with ESMTP id 929601C0010 for ; Sat, 1 Jun 2024 14:09:40 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CYfO52Ut; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717250980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NeTRSu6+PVl0/7CNPkS7f6S2msS+Cn+G1loShWvSDbM=; b=3pzK5KqOfnGqkPWRk7wfYGmXNmIE3PAlKkrZKiK8JBJ4LlDQa4Z02HjT6d3z7AsIPGTQOJ JHtj1ilkDZx93THlIAIpPqURtTxr/AidfPP9MOuy19gV0CvZhBoCnoRpmvpiN0HG1UXmQW nwblxXn5KH2lK+pTcrSmksddfUps0nk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CYfO52Ut; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717250980; a=rsa-sha256; cv=none; b=6FDv7fbONMo+A7U8OUFcJBq+kWTRysXwjGnv3wthWd26tokszsa/J3qHSgn8cx+vZ4aShC VzF1UeP35u3tsoO7N5xQh5bz3gSYMzBF1PWlrRGVQ94jhhyqjezcLSppLZ2Fz6RjaTWoYU 6NbygjHu5j45r8v0hqto0ssS0KRVHxo= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f480624d10so24114725ad.1 for ; Sat, 01 Jun 2024 07:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717250979; x=1717855779; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NeTRSu6+PVl0/7CNPkS7f6S2msS+Cn+G1loShWvSDbM=; b=CYfO52UtYnNUzGv89KdaUnyI8Z8QXF6dMGHvD0yYm2p9HgfUZp/wKR8+vyxU+KpZ5o 46bLBX8PkD5avy4Hhceb9rpXBzwS81NCbrihFSkeGricZs7fYZYJiIl5Zp4usOOXI9Dn xNT0OBQXTBEr+Xle6STXe5o50Tv31FcyBPRYsZrxDeujVFhAiLlm4Z1WDYFaVWUAuxDb 9/hAA1SxHclkUmCjqTNdpJ7IUcTIqb1sUGucTAfvvRFueLJRdBPhMPms0EVvpfeq6S9w MTw6G1aixYBwOd9P/np3OmGNrWIAbBNnMWhuDellbXqJYaKruL/puMd0sww4oiOO+vCE v+Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717250979; x=1717855779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NeTRSu6+PVl0/7CNPkS7f6S2msS+Cn+G1loShWvSDbM=; b=H/q7P2YXwnh8Ngtr4DBSufNrBNt3/ooCa35p1DI4WomHEzfJs3Cm8XI9UV2DLet6E0 j9O93EHfeZuylMXLo55aZZIZKfACGj6dsFpwJaNq9HrbNHsMCd5lv+EXflbss8wjYuxd ynMiiDF5LMja4HV9m/fne3lWHEYe9erEkroueX6LGfqH9Kim2kkFWqGOHJPhurt0dO4E QHUYCZ2faVTr2ZJYQ0BJvW4EfmLy8uNC8g85SLd1UCpyrkczx3hUFYdb3rMRiYjVOPMM 4WIYGdeLlncr/BvdiTjW/C7w16sUxCGZSzMB4Wo+O2cUmkqymS33ElJXsbZBFiebGPSQ eI3A== X-Forwarded-Encrypted: i=1; AJvYcCXNZrHK3Bkk3Km9LyRl5UQ8WCfY9WjJjNmpRSfv7ZAgbXjNPg4CFMqfYFqVstB5tlZb4IgcAcfdTTYxpS1WI8O4Sl4= X-Gm-Message-State: AOJu0YzY+8lQK17sTnBq53vbu7tQgWjxjayoSduKudAEhMRZEbOsbqxC Zo48uCZRNK5XWaJbw4GQ5PxzFJY8ZX0eB/ZyBNj2VcUiWb/sORJ5 X-Google-Smtp-Source: AGHT+IHoXMswpDOWGSy+4K1bobmhUaYAqM21uBUd6ThnxUMFjUo3ZLjid3d/YNdVvRCSx33hRGnjvw== X-Received: by 2002:a17:902:d548:b0:1f4:a6cb:db3d with SMTP id d9443c01a7336-1f6370cebbamr56641815ad.44.1717250979177; Sat, 01 Jun 2024 07:09:39 -0700 (PDT) Received: from LancedeMBP.lan.lan ([2403:2c80:6::3037]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323dd7fasm33091795ad.125.2024.06.01.07.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 07:09:38 -0700 (PDT) From: Lance Yang To: david@redhat.com, akpm@linux-foundation.org, yjnworkstation@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, 00107082@163.com, libang.li@antgroup.com, Lance Yang Subject: Re: [PATCH] mm: init_mlocked_on_free_v3 Date: Sat, 1 Jun 2024 22:09:17 +0800 Message-Id: <20240601140917.43562-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <8118eabf-de9c-41a7-9892-3a1a5bd2071c@redhat.com> References: <8118eabf-de9c-41a7-9892-3a1a5bd2071c@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 929601C0010 X-Stat-Signature: 3qoeurext7rn3ao39heixuufbennscyx X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717250980-392444 X-HE-Meta: U2FsdGVkX184f9WbmTB1KRVH201+Aq2XrWLdU4hbYpzlQ9XAaQGJFkAcda9xngWY+mOp9m1y0raF9A8IZkfZnAip1AEbQLw3HZtCjETbVK8j9UsnsggV+Fl5gpHxRv06Ak6jrJKn0jt4gThSzlUtf9onTKOtsW9/zKabXLDd22yNsTT1zZ7gBk7KkSPUMD4/N1VNzTGaMivaKBCVVAxzChmpj8Se6ISabJL7XBJ2w4oG6Gk6zzhIbHVyNr257qtB1Cg/q2zpw0QcOCpkpYVFc+jSYMvca7LVwkoky6sbv6mCJ7uITJn63Mvm4clqgDSjQUJxjtvA/eiOb2OOTfn4oGRpl2dXO2QGGrnmaDmnYS3/hCr2ILYdIkbKA9OhTq/HpFyLrM7PK1FI3XqSVls687C9TGRXfh5sXmIikS4b6+t90CEGCmAXHDnvqpJwO3ofM+ZcnsIXz2FykDEd/1z/EMuMe/wF34cBs/idZwP4wLSa8RtetUcLg1mLRS2cx1lLSJFXTHcqyZG+9X4XkSpOcfj6xfmnxfyVRBDJ85AZXKtbF/Rn+pBoUgVhJBVZsThg65MP4BUGQZjlhrIRoy7oWQOy8zvrgemPPielPumjQJFQr2h7vnjqhl0f+YRkIdevY/0q18qHF9e5xxp5BLlGlNFDMycgj2HY28xGxoFM/uje9nh6AsXx+iatnc2JKFa5uduWSENORY6yqn3EDI5ANc9UnEswImsev80+cClJikvuKSpsQgIpWJJ8bycaeybSO2afq429q1s1thhJ/ETCmw6TqxriIC5vo+7HC0k32cckxQMiz0DSFxTy4TxIFULw+wO27alcwqNjYEVDEsw/5wflWkShcVJnmZ+/ScAi09DPcCwuvuRefFqMpRfIdAfyVRMvd6VAVxi1jrSN4irfXi6iO600qs3gJKpojtUVFCbksXbT4D9PwevbMDN4dSQuG3RX7BI1KwIPOInuZ2N gPImXBDv zK1jOP8ai6BoFrhedRS2dAjpys1WB+NX+z1FYFQIzlEoOO8fj37D5fyxWXZJeMwbnXhyQtlwg4wucuGJTJSFJeN+o59YiXsrfIIMKX7Ywb12rM3sk1TZJ5eqmgTpTJiyk5rh71Z6HN57AG+h6CAQ3b6e2+eiElekfI3FgFgTLGvaQtKfdS+WENZta9my0rTT1DGFQkypyOsoFsSiyZOIFDvpc7ZSsOwzT/aujjioYKbRT4suHGgkwYserIlQgB6NHw+Zb7dpa5FpU3Dp6FT1+KSkqLubfHSsn8FJjrNORDhBCVQTyV3AgA0Tj3YUwFZOeKNDuzzHhc7b1poqQmiWMRMijq0s+arYBZsaMdyGNo4Bpo+Wcztheena467MbIvHVVXxRsmZTTbKEuhWJ18S1fpRCDI5K4cj1nTgUlDNYIgKLWzKL9Y0vO4bye1VC72XePooe7vJUA2YsJYBiTp4xTt11jHNW933Nezm7MtCPpRiB/Wg8JjRgzsOOWj5wmvRlke0QbY092qHGzDg1pcHp+zFECjvGY+664GbPWDFQD+A7irLIx8IiMNz9sPklxMd3gL7gSdVF1OwuzURMTictnxzlhUSnIsjC/UujMuhZQPy3cDrubc2tA19lDXSpET7HQWSvDnL+56q5fQC93eQ7V5efMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000053, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Completely agree with David's point[1]. I'm also not convinced that this is the right approach :) It seems like this patch won't handle all cases, as David mentioned[1] before. folio_remove_rmap_ptes() will immediately munlock a large folio (as large folios are not allowed to be batch-added to the LRU list) via munlock_vma_folio() when it is fully unmapped, so this patch does not work in this case. Even worse, if we encounter a COW mlocked folio, we would run into trouble (data corruption). Hi Andrew, I just noticed that this patch has become part of v6.10-rc1, but it has not been acked/reviewed yet. Is there any chance to revert it? [1] https://lore.kernel.org/linux-mm/8118eabf-de9c-41a7-9892-3a1a5bd2071c@redhat.com/ [2] https://lore.kernel.org/linux-mm/20240517192239.9285edd85f8ef893bb508a61@linux-foundation.org/ Thanks, Lance