From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE48C25B75 for ; Sat, 1 Jun 2024 01:40:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16626B009E; Fri, 31 May 2024 21:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C3E6B00A0; Fri, 31 May 2024 21:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A16006B00A1; Fri, 31 May 2024 21:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7F6F16B009E for ; Fri, 31 May 2024 21:40:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3F5AC0C81 for ; Sat, 1 Jun 2024 01:40:50 +0000 (UTC) X-FDA: 82180615860.26.E8B7145 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf11.hostedemail.com (Postfix) with ESMTP id C85224000B for ; Sat, 1 Jun 2024 01:40:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LVzV3vL7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717206049; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FjOHl1wOhX5TnmlUnEwReTihPRICcI/82ZuID7RA0Pc=; b=Csy2llyhYTeXwIlMKaE6TXfmvYxp4RVt/AASmh+FNFW0fSFWddwyj6f53Co5Ke2t91+R5h Qs3OvritxncvFb/NeREOCmYa12ATf8+pIf3+3xWZqF/Srb5936OQW9V5/zQUn60hcRAxMr 2tA+h8pzfxkfMnJ3LirgYNlELiJZ6s0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LVzV3vL7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717206049; a=rsa-sha256; cv=none; b=LYJ8CnSXeCo1wDr+92DUROw4pdmWuQ2ZmRxiP8tPbJyfJdr2SQRA6EM1T4vlATBAWQXfuL W62ELOQJ9Qy4pbREXXHSFn2sowWjerForzOee9YZN5fwYhpZa6FsSQTU68pCz32qO8lzsk tGF0nXb9jekxRtL7cw4rxwA7MZ2REt8= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57a2f27090aso2806439a12.0 for ; Fri, 31 May 2024 18:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717206047; x=1717810847; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FjOHl1wOhX5TnmlUnEwReTihPRICcI/82ZuID7RA0Pc=; b=LVzV3vL7j8Fv5xddvjt+0c9XPz/2TvzTw4CdNoAGs4W8e/tW8t0+6jJ21+RaX9KcmV BlEgumywNK2fdvLfislUvEbjCTGTAJwfi846fCbkyDEe39+ZLQGackXV6q5eEnd50RUV w3bupdZcGOsChvUHzPjLGFU0U3F+W1WKae7LEntBJqg0Qz9zT4c0FsvKPNIKOZqamNiW nWJdjSOw+hWFO0AUyUFxwab7Zw+rijauQBw+Aj4czGrodLakj8CGmVyTBVKhZS4GWQCq g/0vzqEXtTDwsWqCEvuLah2DXADG154qrlPMgkXdOdanXlLeyqhasnVcrcaouO/rBC9f AjrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717206047; x=1717810847; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FjOHl1wOhX5TnmlUnEwReTihPRICcI/82ZuID7RA0Pc=; b=iDfuZ/hsPdbyQRFTjrw0qEWs+gx+jpLYAnOH4i1snLhB84W0nCkRqUMA9RhiFacLgq gi9SeesdOh517MoHsbFuJueLu2Gpgq8zUCuZI7Miyqrs2Vfm6zqZ6xyFylGg0XvpPLkh dxiXSonz9jXAPEisaD1ntl1qdsr+CQ/yKh9Ekqv9X56GZOrN0GLmUr6I3lClYkc0PBBR llkfy0KA4SRUZCAzxGuBJhPhUUZf+wgIoRpQz79LLm4v6TqYYtzj4u3/HmJA/XdR2jzd 28XrlxhkOkVb4I3akLdkpvekSELfKCF+3WN7llHntQYtN29U/DAQldABBfpsOSsWSZAo yUzQ== X-Forwarded-Encrypted: i=1; AJvYcCWjezcVILv7IGSStM40qN+r2sKDac0+r1lQPHCe9rVc2r0Qzv0QITvTDvHSM2c6Adh5tUlranZmLplR4veLfukhUYU= X-Gm-Message-State: AOJu0YxLTpH9c3hVxdW+gzS6gzSFcCr0mtSGf8m+SKwwunHCpxmG68rd MytLiBsWjxtpMJJmBnzHXiRTvOIcccikHR8tKuM9mVhJj0LBKsZ6ou9GFA== X-Google-Smtp-Source: AGHT+IGsOwecO3L7jlAJRHay/1doV/X5ideh6MAQspfpuUObYwnhWa0Zlmfl4iZTBXwVdzeBvE1R4Q== X-Received: by 2002:a50:9349:0:b0:578:6484:24ff with SMTP id 4fb4d7f45d1cf-57a19f546ddmr5802199a12.6.1717206046824; Fri, 31 May 2024 18:40:46 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a468ebb00sm387592a12.52.2024.05.31.18.40.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 May 2024 18:40:46 -0700 (PDT) Date: Sat, 1 Jun 2024 01:40:45 +0000 From: Wei Yang To: Jaewon Kim Cc: "richard.weiyang@gmail.com" , Jaewon Kim , Mike Rapoport , "vbabka@suse.cz" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "tkjos@google.com" , Pintu Agarwal Subject: Re: (2) (2) [RESEND PATCH 00/10] memblock: introduce memsize showing reserved memory Message-ID: <20240601014045.jkk3ydsu4zns2bfc@master> Reply-To: Wei Yang References: <20240521025329epcms1p6ce11064c0f0608a0156d82fda7ef285c@epcms1p6> <20240521101753epcms1p50443f6b88adea211dd9bbb417dd57cb1@epcms1p5> <20240524090715epcms1p274939a1d5954be3423f6ce14a3df6f92@epcms1p2> <20240527013504epcms1p22bec7b83f2a42e76877b97ed0d769009@epcms1p2> <20240529095119epcms1p73f0e9ff756bcb2ee6a14db459128a644@epcms1p7> <20240529113519.jupuazcf754zjxzy@master> <20240530104928epcms1p8108ece61c39c6e3d0361d445c15352d1@epcms1p8> <20240531082141epcms1p49d8d2048e04e90eca45644723614faa8@epcms1p4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531082141epcms1p49d8d2048e04e90eca45644723614faa8@epcms1p4> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: C85224000B X-Stat-Signature: iqjnu1gwusgn1r8cda44spjabuj6runz X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717206048-799392 X-HE-Meta: U2FsdGVkX18PI25QVzsgvyk15NA49Wx/Z60m3BGJDB0XCXci3//0eL8o1/tjcNqbhoTIh4fpwUABZ5zITfU5qrP+8LkxY8jaHAvYDoCPSAG3WuDxlRAmGxHxQ60MSmauJ+ZugnX84nUCr3aGY1+CyU6mfJDuxMycfO85Qp3PlI30FQBYC30Es6iolDy8QFMZYtMgVX2yfh8Rpo3TSkxR+6VBWNTpTis39UhstmlHB3GryftBOrsSvtmcHwN8X5LcRH0ERiZWV+CNo0yApzi/61nB7j9uylUkfgjSidlnPhH/lIF6Cs5UWUQXnmlYCryUsSuafy2K+X2d5u6M/n4MyObEZUac6KwAsJ1AXxIAzBQEhMzm7NQDF1hkzwziRcMNRRQ/lle4C1OXi8x6vvL111uu77rtQVM7fSFQjaN/jTe6nUmVgo3tn3D/7TSMtHZQ25zLhn50QemtyF7li7Vh6Prh03b4r0hBZtFhh3c2XFPbIGwNee7uAcZlT7Kwz6241iYowqnV+blE0CjN6x3b/nAETrX6RSIp1hkoNPntwNmS1O5d35bTISpPvC6U2XKRRQ+7DEHooJocQvNehIAThOIkHW/wOMpbrBLCG8L/aKXqm21vrAQlhFqmWmH7977vnRZcfCQWW/oFWH2UxGH1+wFVpu432Z8U/objSh+uvlmIpIcMiymRbInJ6GFE/HLZV3G+ODdwAxTB6CgrBELwCsNyD6Q9Awz4rOZsrs7Uw1o00ADBq73FP2tcy1BLPZ/T9Y1GOIOqHBBMsffZzieoq0GTbeevVAOlI5vXoK2Tz7jM8NlcC7GgHcwMZpUbby7mhRq2tdYYBxAifL9WZhk+fXZXu+NTEvq5aYApJnJ+3D10mnJP5RqNVUJ0Ae+8WVwuDM4Bf2FvhpLaZY+mMCBZnpt11cvVnB7Xmjvx3q+tJtwdf+cMpjZeXt7bJTjkNlSBSE/LLUbVuygfj8GoyEg DTsY24vl /908N5T93ZBNAYLz4iF+Os4pAeTRO1QbgDD00Nn5fA2bmmC41OrLSpT6fjoWJva9agcEeni0GR5RvK5OD5n74ppfCns/P9E7/A3jTrI+H+2HVR14KetL4VjE0nFeZZtf+NxJIkzrz0GKuf8OWYnzgSDomDsHEiKimqjIvuCDtA20MfnMLDUKytjQfKwOdzlH00rlqyqW1j8cX5iSIDAkVivxKTjHqjMlTDHDwMvamTCTS+/f65XEHOT003+jvVc1zYB6RJJtb8ppOsjSWZOWz8G35zYz64Sv9eNrs3HZSf7EVrQwnJXovKz+on5mhH5YTWEIw8/4GAvlX35qwG1yHbqP0JmTkHqt/Ubhc1WlUShe/qwGvWTBkVdKNiaCRux3lV49al1NzTWK4X31H8sOYOfowPndeuyW8V+tQHGCoG7Nb4bP++TSFsAXZe7WyOE9eIN6TNi+a/W4u2ke+i+1ZzPThs3lvLiPOHOcZVAhVaDa7QUSKxGk4zYQUVQ07t5c0vjyaC6iHQ8AXAt3nY/vtu5+/yvOITMs6hz0tLRBqOGJs8wHAGa5ihZQyukVhKdgt6lGorMGzMqJuwkNayV6ijUxUkiTPx6AXb5gjs1QYLJHNwanlPh5Usol+4R90gGhkS0HWQYIqL37FJEigljummNUtK/muk7rZDgERSZycAhN9ztV39f2tOTWEKgyFo9GJTeL3X+uEYAEXLo/w+oFOLxlL/Qs2SrIM4qrg+FejukG7ARs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 05:21:41PM +0900, Jaewon Kim wrote: >>On Thu, May 30, 2024 at 07:49:28PM +0900, Jaewon Kim wrote: >>>>On Wed, May 29, 2024 at 10:10:29PM +0900, Jaewon Kim wrote: >>>>>(Sorry I might forget to change to be plain text) >>>>> >>>>>Oh good thing, I did not know this patch. Thanks. >>>>> >>>>>By the way, I've tried to get memblock/memory and kernel log from a >>>>>device based on >>>>>v6.6.17 kernel device, to see upstream patches above. >>>>>memblok/memory does not show region for >>>> >>>>memblock/memory only shows ranges put in "memory". >>>>memblock/reserved shows ranges put in "reserved". >>>> >>>>If we just put them in "reserved", it will not displayed in "memory". >>> >>>Hi >>>Let me explain more. >>> >>>In this case, the intially passed memory starts from 0000000081960000 so memblock/memory shows as it is. >>> >>># xxd -g 8 /proc/device-tree/memory/reg >>>00000000: 0000000081960000 00000000000a0000 ................ >>>00000010: 0000000081a40000 00000000001c0000 ................ >>> >>># cat sys/kernel/debug/memblock/memory >>> 0: 0x0000000081960000..0x00000000819fffff 0 NONE >>> 1: 0x0000000081a40000..0x0000000081bfffff 0 NONE >>> >>># cat sys/kernel/debug/memblock/reserved >>> 0: 0x0000000082800000..0x00000000847fffff 0 NONE >>> >>>The memblock information in the kernel log may report like it allocated those memblock regions, as there was not overlapped even though it is already no-map. >>> >>>(I removed the name.) >>><6>[ 0.000000][ T0] OF: reserved mem: 0x0000000080000000..0x0000000080dfffff (14336 KiB) nomap non-reusable AAA >>><6>[ 0.000000][ T0] OF: reserved mem: 0x0000000080e00000..0x00000000811fffff (4096 KiB) nomap non-reusable BBB >>><6>[ 0.000000][ T0] OF: reserved mem: 0x0000000081200000..0x00000000813fffff (2048 KiB) nomap non-reusable CCC >>><6>[ 0.000000][ T0] OF: reserved mem: 0x0000000081a00000..0x0000000081a3ffff (256 KiB) nomap non-reusable DDD >>> >> >>This looks not printed by memblock_reserve(), right? It is printed by your own >>driver? > >AFAIK these log came from the commit below. >aeb9267eb6b1 of: reserved-mem: print out reserved-mem details during boot > >> >>>So a smart parser should combine the krenel log and the memblock/memory log. >>> >>>In my memsize feature shows it like this though. >>> >>>0x0000000081400000-0x0000000081960000 0x00560000 ( 5504 KB ) nomap unusable unknown >>> >>>BR >>> >> >>I am sorry, I still not catch your point. Let me try to understand your message. >> >>You mentioned several regions, let me put them in order. >> >>(1) 0x0000000080000000..0x0000000080dfffff printed by driver >>(2) 0x0000000080e00000..0x00000000811fffff printed by driver >>(3) 0x0000000081200000..0x00000000813fffff printed by driver >>(4) 0x0000000081400000..0x0000000081960000 expected to print in new debugfs >>(5) 0x0000000081960000..0x00000000819fffff listed in reg/memory >>(6) 0x0000000081a00000..0x0000000081a3ffff printed by driver >>(7) 0x0000000081a40000..0x0000000081bfffff listed in reg/memory >>(8) 0x0000000082800000..0x00000000847fffff listed in reserved >> >>If you just want information for region (4), sound we can do it in user-space? >> >>BTW, are region 1, 2, 3, 6, reserved in membock? > >Yes correct, I though (4) case could be shown to easily catch these hidden regions. >As I said, I think 1, 2, 3, 6 seem to be not passed to kernel, it was just tried as >they are defined in kernel device tree. > As you mentioned above, 1, 2, 3, 6, is printed by "of" driver. And those information is not shown in memblock/reserve. I am afraid the proper way is to let memblock know those ranges. Sounds "of" driver doesn't tell memblock about these. > >> >>-- >>Wei Yang >>Help you, Help me -- Wei Yang Help you, Help me