From: Andrew Morton <akpm@linux-foundation.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
jpoimboe@kernel.org, kent.overstreet@linux.dev,
peterz@infradead.org, nphamcs@gmail.com,
cerasuolodomenico@gmail.com, surenb@google.com,
lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz,
ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram
Date: Fri, 31 May 2024 17:38:23 -0700 [thread overview]
Message-ID: <20240531173823.4ec7b4693a4e433b1da91e75@linux-foundation.org> (raw)
In-Reply-To: <CA+CK2bCuiDAv05Xu6OuKB=gqJ5NM20F_uUyJV8E=XH=r47ik=Q@mail.gmail.com>
On Thu, 30 May 2024 20:14:17 -0400 Pasha Tatashin <pasha.tatashin@soleen.com> wrote:
> > Couple of questions:
> >
> > 1. In future with your on-demand kstack allocation feature, will these
> > metrics still be useful? (I think so but I want to know your take)
I do think the changelog for this patch should reference the dynamic
stack feature. It strengthens the justification for adding this patch.
> It depends on how on-demand allocation is implemented. On hardware
> that supports faults on kernel stacks, we will have other metrics that
> show the total number of pages allocated for stacks. On hardware where
> faults are not supported, we will most likely have some optimization
> where only some threads are extended, and for those, these metrics
> will still be very useful.
Also useful changelog info for this patch.
Pasha, could you please prepare some additional text which I can paste
in? Thanks.
next prev parent reply other threads:[~2024-06-01 0:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 17:02 Pasha Tatashin
2024-05-30 21:56 ` Shakeel Butt
2024-05-31 0:14 ` Pasha Tatashin
2024-05-31 22:42 ` Shakeel Butt
2024-06-12 18:50 ` Shakeel Butt
2024-07-17 16:50 ` Pasha Tatashin
2024-07-18 23:19 ` Shakeel Butt
2024-07-19 2:56 ` Pasha Tatashin
2024-07-20 3:41 ` David Rientjes
2024-06-01 0:38 ` Andrew Morton [this message]
2024-06-06 0:03 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531173823.4ec7b4693a4e433b1da91e75@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhijian@fujitsu.com \
--cc=nphamcs@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox