From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AC2C27C50 for ; Fri, 31 May 2024 21:08:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81C576B00A2; Fri, 31 May 2024 17:08:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CCCB6B00A5; Fri, 31 May 2024 17:08:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 694C66B00A9; Fri, 31 May 2024 17:08:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4B7356B00A2 for ; Fri, 31 May 2024 17:08:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7749817F3 for ; Fri, 31 May 2024 21:08:09 +0000 (UTC) X-FDA: 82179928698.26.1FD94E2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id DE4212000C for ; Fri, 31 May 2024 21:08:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dSTxV43/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717189688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G9MVV0i50OJrq+7gsNLqk9unrOrpdnroXNwmF/sDlko=; b=17KG+fLIcf9eRSz0CaIsN9ZkZnLWDxIsr5VRhWn/BgdUSE02oRTa86WQDb+tJvhI3Gd57n LSS7PIHb5qHsPJwYFyIQuYAmPaGficEONX70YTxStwX15wn3xxqdQPO1QduP8ZPCrsjKcH tGyg/Ew4FxF6phzM5xsk/iRctbSLAf0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dSTxV43/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717189688; a=rsa-sha256; cv=none; b=CbZPVV2TXb9ipjtYopW5Ve7DOYLSuVcFgjyyTzW6SguWLM0jbGDyU/R0qXScGJT7FY+W0t OSX351cgrt1lVY9tKnKHedOZq2J/dARQeSmOJQfebSRLtJIaP2pOGI4qAiU9T0yd/MdOtz TjnI2fjrXlE5EXO8oq/tDBk5N3QfkuI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CC27CCE1A1F; Fri, 31 May 2024 21:08:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A842C116B1; Fri, 31 May 2024 21:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717189684; bh=jySXDNeokm7iuVZtdpS/Y3fW/yp7AlExakgw7S88qFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dSTxV43/YOLNlF2y0mUfKZEvaZR/2abCx4X/cQkXJj9XD0EBWcRe5qKvs8ppPLEMM uP9ON6V4912/GEjROWHr7zx9Uy/O2axyvfKUWIDG8Zda/Nu8OeebL1XEZ2LMhsnVIf FB3Tuyafus+oV6vh0wH2C4s4X3GWgCZV4Uz6O7hftIh9uKRZa8TjKFtROzOP2n1zxr hMsHRGHWdn/j4mY/ajzcaZqabMo2ciyoStD6ela21qbbt2t+3YnnMTAK/Bx9DS5Dkf JPcow4TYE2ykHBbl1HoRwRu3hshds+CMcKZ0MAmE0XIK33QeyaHLQjCQ2jshIKevP0 ej6oAZ2t6PW4g== Date: Fri, 31 May 2024 14:08:03 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm: fix xyz_noprof functions calling profiled functions Message-ID: <202405311407.E21104C0@keescook> References: <20240531205350.3973009-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531205350.3973009-1-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DE4212000C X-Stat-Signature: yu8bngkmp8xix5qukfjy3m1afs9h1rqp X-HE-Tag: 1717189687-778101 X-HE-Meta: U2FsdGVkX19fKenJCdwsyWak3NhBJ/ofD6aKzVq42Xen2FMuYTIzDGGGlmIVX1HTPcZmXxK+BOfkDSjl1OAZHXzfMVXsMM7oLiTy+2IQ4sMFSR2aoVLJ9Ryz96t9s+6VjAwkdxshW7+Lbm1l6j1rOFijoXw93JDQa4JtvWIyeq54YIuStnsxe2ZuIfiszBtyXfegjRytqSiMXOaFx6ue0yLwEkjkzK+LdWA5YQBtZtltoSULLZryBNZNyv7C8gSxEMEa7u5E+0TyfzCKrTyddCFeARQsVuI69GI49i4ksxbbPxmcymr894deYf4KQ641Kcbqfd7QTdUx3iw7I9rMjBr2T9uS8bTzkt0nF3gjzAJBzz11r4cN8QWBNxjBY9oyG2RQIZcRVz7dAjE2jl2lpgkWaMacnqNNaEYbAG71/K6iHW+lyj3eJ5fn62DVwlFXxlrf1IecUR/AW4GlXuZgcUrPN3Zb5ug/h5tMeevJxpjvpXoZSfDvmfsSWw6AE+Xyo52sj4uQH2WF3sS3WHW3avDgjDFo9Oy2YhIy3JT6YZw5oRLLFht7gkgN3UmEygJy5MelxQBS2VnV+LIeVj9/BSnU7x0gFMewewmieAyBojQj3IThS9Gt2M2/yaGiGpwQ+90+QjhgOqxbzrO82qZT9lS8w8RWPh3aFv6jCU7FcheqR8WgHc5cXMseF9Ce5XIgo/9nqvKV2ZFiaorg0+Vd63kSZ4pO6eKLGh2dszoDRvd/IC3iLmODhr8trPtN6Y8sFHhVI9MKOpwlRtXqkGxNmDD+ufPiOApd0vCrKQ97nvlZZHI7FxNlPx09eq/2CUvRH2XWwpnI8TPC7nPJubBexiW6746vYMWL9jXSGSy1J/MfRAd/+yyEYzj0H5MsfviIdZSLRoAaoSsXlmHcRZET0lJjVdZtUo7QUdrrifj5K6WobJWFA2tCmoYzfQtBooziffb+yaeweX0tqmtlDK9 mYg5hwTl yncZyRSKahFlTqD7H6RWrw1Kiq/YE18qZHNQQ4Z7TrvqEBMAxSxpJ0MKgRQxXmrqpDMur9rggNs3dIHQHb6tFwZivJ2JgW+wtSPnO7cAuga2SXD/BL6tK6ZOs2azQsKJ6q1eZ1deYn0hoG4Lc9Jltfmz+oSqCaN0Coxy3brn+Ou5RJ6jVXJ4jUxu3HTwq9CIofOuEbFzKXRZoEHL5xIH4UmZOQpGTtNivMjgdW+Wc3vyFtAafoJSdDcCV1oJxvSkaozkP+mw1Ub8QMngxNuglWaBOCwRh8sp98MwChIlKq/2jIvAS5PeK085Jrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002447, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 01:53:50PM -0700, Suren Baghdasaryan wrote: > Grepping /proc/allocinfo for "noprof" reveals several xyz_noprof functions, > which means internally they are calling profiled functions. This should > never happen as such calls move allocation charge from a higher level > location where it should be accounted for into these lower level helpers. > Fix this by replacing profiled function calls with noprof ones. > > Fixes: b951aaff5035 ("mm: enable page allocation tagging") > Fixes: e26d8769da6d ("mempool: hook up to memory allocation profiling") > Fixes: 88ae5fb755b0 ("mm: vmalloc: enable memory allocation profiling") > Signed-off-by: Suren Baghdasaryan Reviewed-by: Kees Cook -- Kees Cook