From: Kees Cook <kees@kernel.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm: fix xyz_noprof functions calling profiled functions
Date: Fri, 31 May 2024 14:08:03 -0700 [thread overview]
Message-ID: <202405311407.E21104C0@keescook> (raw)
In-Reply-To: <20240531205350.3973009-1-surenb@google.com>
On Fri, May 31, 2024 at 01:53:50PM -0700, Suren Baghdasaryan wrote:
> Grepping /proc/allocinfo for "noprof" reveals several xyz_noprof functions,
> which means internally they are calling profiled functions. This should
> never happen as such calls move allocation charge from a higher level
> location where it should be accounted for into these lower level helpers.
> Fix this by replacing profiled function calls with noprof ones.
>
> Fixes: b951aaff5035 ("mm: enable page allocation tagging")
> Fixes: e26d8769da6d ("mempool: hook up to memory allocation profiling")
> Fixes: 88ae5fb755b0 ("mm: vmalloc: enable memory allocation profiling")
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
next prev parent reply other threads:[~2024-05-31 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 20:53 Suren Baghdasaryan
2024-05-31 21:08 ` Kees Cook [this message]
2024-06-01 20:58 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405311407.E21104C0@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox