From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C9CC25B75 for ; Fri, 31 May 2024 06:30:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EACB6B0092; Fri, 31 May 2024 02:30:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79C456B0093; Fri, 31 May 2024 02:30:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662456B0095; Fri, 31 May 2024 02:30:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 487A66B0092 for ; Fri, 31 May 2024 02:30:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6045C1211 for ; Fri, 31 May 2024 06:30:23 +0000 (UTC) X-FDA: 82177716726.18.1176F09 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 1BFB614001F for ; Fri, 31 May 2024 06:30:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=QFoB69CH; dkim=pass header.d=linutronix.de header.s=2020e header.b=wjDiGFYZ; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf23.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717137021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0QKmm22JdPzh0GWkCWU77DhQui4Y/61huUJNDliaZA=; b=3p2n+9weI2FdNhQ+z/hY7HBvzdd/JlhTS070jVUh41X25ctNU6B6w0cNUI/CR3mBkv8Gc5 H86OZ5ZOtb5nvkIMI+o3zAxl8i5DmmKTR0pOYbV2QEL2RSKhxvZuUB12znFmmWVPbg3jVa Om55uKsVOtrugEHwZRaQaRshN+9Ba8s= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=QFoB69CH; dkim=pass header.d=linutronix.de header.s=2020e header.b=wjDiGFYZ; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf23.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717137021; a=rsa-sha256; cv=none; b=LRBe0EnHt/L4jHrSpSc035gYxE/JBN4bl0R9pU83ABPBk+SQxHrVCT/nt5j3VmYzViJ7Ix jV+yavazfd5CkmTBOw0Qb6RL0Du+vdp8YQujHPtiN0Ne4sZdLLh8B2IM+j/8F1SXzs68FY oO7D4wh/PngQL8Qbfp8i8u86RHATwj0= Date: Fri, 31 May 2024 08:30:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1717137018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0QKmm22JdPzh0GWkCWU77DhQui4Y/61huUJNDliaZA=; b=QFoB69CHRFvRO1Fso0pUfBNcwKfvV+h0+FJ/JubW7z2q2efjpJH6b8WXySQFplvr1+uXPZ KLbaZDksbyDfeWdtuooMyEMWp2ZoG1Uk7JhevAk1v/dMmfGLQ9hpLraPoG2PxVOz3zv49k x2CDiEMw2/V/a4e3tSwnS2ueF1V8p9oolXLmNYaG04PACNgDw2vxMaBZrDUbJv1i6YW7RG tg6VtHYT2cTLxQicta5t7yKAAsTuCWRA6rUmFrJfxOR9tsinUBUOzKeatteAwEd58UKcAO CvkGDyB+LajttHbABral2JxJId1Skikf1EwZDGXGZhhxn6JKsXDxr1bKpcvtbw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1717137018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0QKmm22JdPzh0GWkCWU77DhQui4Y/61huUJNDliaZA=; b=wjDiGFYZOlVuL2w0+5a4ueNxOgXg4POfy35IGj/X1kD63/lhPCtWQRjwR3TImhrfyR/JY7 a3VsRjTwQkRt8gCw== From: Sebastian Andrzej Siewior To: Qais Yousef Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v2] sched/rt: Clean up usage of rt_task() Message-ID: <20240531063016.OCMg21Uq@linutronix.de> References: <20240515220536.823145-1-qyousef@layalina.io> <20240521110035.KRIwllGe@linutronix.de> <20240527172650.kieptfl3zhyljkzx@airbuntu> <20240529082912.gPDpgVy3@linutronix.de> <20240529103409.3iiemroaavv5lh2p@airbuntu> <20240529105528.9QBTCqCr@linutronix.de> <20240530111044.d4jegeiueizvdjrg@airbuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240530111044.d4jegeiueizvdjrg@airbuntu> X-Rspamd-Queue-Id: 1BFB614001F X-Stat-Signature: m7wuioq5eqf9hn3ggmf34yjj7ijzrp55 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717137020-432760 X-HE-Meta: U2FsdGVkX1/olLuT61FruWunjgTDAgWFfIEI2rU70jtlZXOYGck46dqb+ub6iZj/fAowM8lsizVTVhWLhT7OYu+90XrDZcDKNTQcO6acpvsfQQVkzSEQNYlGHXqLi8glicWuGh2KZe6q1JnJjuzKCsFTcM6qb8HAO2vnO6skcLkbTcCi+ytr9++djOPjiMBW4RY5/DMXTDs+4fFvu+gkwqUM1zuIwBwMRhJTRNtlDMiLqAFt37d3kG0llMtSGRrEo/Ipm5UbdKdP57EsEaVyrH3Cl042lPGKyLXykgTM6qmV5gICXJXRuo84Wbrhxd/+M9e6QUxFWLcnuptLb4KuA0ixgY38zGlX27BL2nL7coTG5FiBeXGxhGQG2Dqw3ZfGer/v7xDqHXMbKCS76X4By+S3c5pF6K14sFFkH71+YoU91iZJWYgOKDrsHeWfypxGOdllmyRCbKI9UhQ2ROcaBa5ARN1qzQ4t/xVpIV3t18FPVb3+WzYP6Uw2lxCOcH9ifB0TpyEcrICuyPffo4DOHLVJitWwSQ2NWmAlaVzbQV9xjIAqQ7UR5GnCzdRbTTKUfm3zZnpc7kjL65juwtKifiLF7oeQ2IIzyGP2e7M8iSyycKWPgwkn8o0MPpDLzHlYhFawlQSm1wmXOH0pNDlk20WzCyL3dFKpZ/8Xt8r2haRB98gaGazN0zSDhkwRVMQQHpnfw08BuYHAiOkl2DH6l1Mn2UWlixGPNaA7PLsJ9/+qPk7oOFiwe/PLDm8CC1ty2jEM7Srt7g/rQ22fjSbYL1Lh1PtLz8X1KD9azSTDQqHNrusb30lhiCfo0ZRyAV9XiE00FeWJm7EE3QrgFdHruG1OyVvoolgtKYCwiNEOctXk5JArQjQUY5fSx7NykpVFCCSGw4dRQYNl0QYfJNdKDe3FgTFOVUyM2+os7tD76i2wAuJ9gYEA/hc4C3v38VEw3xIMNlcSebQvNBMfqpQ yXhzw9oc kg+3EQSi/JWWzVYU7swdjpn/dk20RbN/wK4q5eQxL9wVvqSEm8H/9YPxDx4EASzYWqm3SVFVJqVNombZ60pH5nplfWFv+fjGC+Ugi+jZQrsgsnNoZyjyDQ90/k9+/3hgESBjzRprPGKjQrlIxtsoqaUMjtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-05-30 12:10:44 [+0100], Qais Yousef wrote: > > This is not consistent because IMHO the clock setup & slack should be > > handled equally. So I am asking the sched folks for a policy and I am > > leaning towards looking at task-policy in this case instead of prio > > because you shouldn't do anything that can delay. > > Can't we do that based on is_soft/is_hard flag in hrtimer struct when we apply > the slack in hrtimer_set_expires_range_ns() instead? We need to decide on a policy first. You don't want to add overhead on each invocation plus some in-kernel ask for delta. ->is_soft is not a good criteria. Sebastian