From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F49C25B74 for ; Thu, 30 May 2024 20:47:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D19896B009E; Thu, 30 May 2024 16:47:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA27A6B009F; Thu, 30 May 2024 16:47:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1B8D6B00A0; Thu, 30 May 2024 16:47:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 900076B009E for ; Thu, 30 May 2024 16:47:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30FD440CA5 for ; Thu, 30 May 2024 20:47:41 +0000 (UTC) X-FDA: 82176248322.22.2B736DA Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf26.hostedemail.com (Postfix) with ESMTP id 446F114000A for ; Thu, 30 May 2024 20:47:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=qt4XCaUZ; dmarc=none; spf=none (imf26.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.52) smtp.mailfrom=josef@toxicpanda.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717102059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Ga1Yixe/s4ryLMU9oA1rEgCpWnaYwXalqsXklj5AYA=; b=qTT7pXZb5xDxHX9xrtzQ8IlZD8RNJuwGA4wSpCdyyisbQ2oJz0mksy0d+0//Rk5uurMAXn k3TkMYG7uS0xLuLMc+WZnQ/JHZANtA6WM42t06cvf7GNSU5UCes4hPqZCsLce6N6JBYk/c 6ofEavvwGy9xq8ha1Arf3enlaxkrOkg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=qt4XCaUZ; dmarc=none; spf=none (imf26.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.52) smtp.mailfrom=josef@toxicpanda.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717102059; a=rsa-sha256; cv=none; b=4VtKk8K7FfjUhviHvETT2p4ixME0a4l8ln+waVoAThbtO3sOpiOXv8iJzFqwl/FOgJXqzi rOuL1WXeiNg7Qs+0ASjW8sgpnhxU49dMa8ux31bY9dq4AjSw4O5/OTcYktqD4li2T8UY9f 7peNnCBrSbNLQtwIxSSfqq5a4qLlDgQ= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6ab9e011f62so13568186d6.0 for ; Thu, 30 May 2024 13:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1717102058; x=1717706858; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Ga1Yixe/s4ryLMU9oA1rEgCpWnaYwXalqsXklj5AYA=; b=qt4XCaUZ/OAUlpXATRaw4MwuBdnzyZQ8sj7l0OTZv0v9ZCQIez0bn5Btaai9e8Cjlr SeICmlSkSe546cDPFbf+DR7AvEmW7UBvsouYQcGQzq2pehJHssKsZ+KScWqw3ioe7qLY ZNn4P3G41mhURdWZ8fkJM+wYG/9kq3lJPmfaMNWHpGmxpK3giFaXKEtA4ecUc3ERT4kV ju+5OzjwGDlQv9DMRNT1OWYDkvYkwQToJeHpf4/JuWpmBdH9cjgukYBehx208TkjSiER uE7jegWR5NEsuKeTsRHg8SXJEggL05thrxSKHAN95KpL26Bp3Q2rdvx4yv4hMOFYR+rL HQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717102058; x=1717706858; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Ga1Yixe/s4ryLMU9oA1rEgCpWnaYwXalqsXklj5AYA=; b=mG5orqJsTs4E/TLrEsAYJnGhR5MTSi2744kdSITBrgT4BtUhPWEYhHyUqoV7fzsUUa FucaUywd/BilXiEk9LNaufqnoWiOMBYSvSy0O/WxwqR9nlRYN05TdQGIoPmTWoXBjL55 WReXYYhwOqLagIopSGU7meH9pn6GvzNX7Yji/9WgmPB8x8bztG2jxwGSucoqnJmXhq4Y P8XFUosUED6lRH2/8fu8Abinr7D3Pxm0aa9cey/FVAdBT4WY/AtbJ5o3aYkXEAHvCJ6a Y3tTCqajPH2egUinAPtMIRu/DSfs7xYSU5lFo48kg3zLB5UWTjInhWEGoUqm6MPwIP+3 Vasw== X-Forwarded-Encrypted: i=1; AJvYcCW9LZCCAHzvdfPsgWGMMHo4eBP1K7hiLnGwg0K04PalREW0fjfGLyCFmQm3Xsm/olgCO/CdMiPKKUDPfkE7sYzILWs= X-Gm-Message-State: AOJu0YzBQbrASg4z8RmKEAWQkVK9Ppkysvk/haa2Gb5kgcEvUUTnCXHF rmkCZhK90ISEnzXobneyAg45ZfY1eZtOnpR3Vlfh4Pb85EIWgLZNhOqfSGiBZJU= X-Google-Smtp-Source: AGHT+IGLu7Utvn4d35cKADWO6xyI2iy9v6hacZFhv3Dr/b0t0erkbT0o+o7A9sG+I16KFAv8qHzmlw== X-Received: by 2002:a05:6214:b61:b0:6ad:657d:9d47 with SMTP id 6a1803df08f44-6ae0e87f2bfmr56543066d6.14.1717102058329; Thu, 30 May 2024 13:47:38 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ae4a74770dsm1587556d6.30.2024.05.30.13.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 13:47:37 -0700 (PDT) Date: Thu, 30 May 2024 16:47:36 -0400 From: Josef Bacik To: Bernd Schubert Cc: Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring Message-ID: <20240530204736.GH2210558@perftesting> References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> X-Rspamd-Queue-Id: 446F114000A X-Stat-Signature: o5ziwwtgdw1was8i4hgaf1ys7oheh6f5 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717102059-452765 X-HE-Meta: U2FsdGVkX18f2IYfsHi3X7ecEHVg4TL9/cKOlpOPTTno3u1q3Bb4xU3cTbq98qyYvzx8oNB3AAja+4pFXDBKbmteZsxq5EiwtJaP4PzlJeHRg2w1NUUWx0yBHRWAbQR5KNrmDbHqNpTBHcaIrN2tN+7o4p+Oghbi6who5VoS5E+jkxNIp65cEYAtsB+Hf/h5sza2GGZaluUHuF6Cq8u5OevVtJ6sZ+tQiiKqXjgSpfoCoEQEVqfOtHTajz24vOqw6dcI+d65FYuzIEgYI43oKRDxJJWNxrjliXkEfKnoP7eBskDoionKfEaisR73YDnxvkQNE02lsF8Vx3EIHh7quF1mi8y9tN+0u7ZyRQSg7u5/0RTCgD2gKXuI3asCCSpNVBnuG5m+f24h1Znmf9R0v9klTSKMoHoITAcYEVzX9Z+G5OdSvynRxIxwDi3GHC8ZT2N8NsDZK97uTe5Lf8ErgqtcmW4Yfc5hhEEJNLfrdh6c8Nk3FWVa1D27jXeaoVUDvMUMK05yvkP48Bq1nRj/SCRFPZf6XDn5J6YZmKoAZpQFWVgAIyn5rz+StWQwJRVxxneg3YU6P1CLvaarSnM7+WWoePC5sW0qNPMK2s8HXFdFubykDQrU1D54HHmqoK5ojTEHZReWodseokCpQglbIW8B6jc7LMkz/KWgQB8UjAFBp36H1KA3wBV8Vz+pyyogUcsiI7IYqPlnJ1kWVy1tzq7Q2bAoK3rJszOg5B4cjNLgeXMZXPGjQzB0BZNnHZlx0PHYtwRRidBTujGuS8HBG+I4eSNlXRncToo+FM11THfY2+g6ss9fzd/9brECXG61YidtxFmGfZCs7ALQPgP3hzP3Gvw2tONP4YweSTIsCa/3gDw3l0BSHUh4g/pQyvbZeJELVl7Oz4tWVwHj74q1g7RaJOAi6DgqZxr+gNwo6u7XBX13fq/QpwZROov3jqXxwJUpQ0VEkVBARvCc6M6 vUf4wuOS dNI/WXoJGyT3byNKy3NrrHQep/BfPHOh02mysZriXLxKdaeqtZfN+q6YlCrUb+wnTUzxu4hKikXyBUketE7GDHgXGmvo7IuICXsGsLLNMabTQsfPBk43QUtgs9tGkr1U5tA4lFW71jyjIHVYTa77h9TJ1tSidUGX+VPGlhFO7Zyu7ROsd9Af/rwKxesetpUKUR/lWDbiTRQYEVr6abDSOLj4XSvuSNnoIquTbgHz5S4STSCCQA7srNWTmI5PWzqI6XavxLMPHgbUyV7wC4BF/LPEKLgBUVL5E5xPuYTfiNYb5jr1bChHRNOFecGws7v+JJT1jnxdRTK6oU/f4azLa3IrX7rWSirnLVygn7jkipDWpBgb0EdxfQLrvyCIIGyCdWy2MCt5CG2bwW94ntTCgkyGZM9xlXUBctplNhUIL9iLZfLtlLqW5x9rv49lLMaWOLYLV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 08:00:35PM +0200, Bernd Schubert wrote: > From: Bernd Schubert > > This adds support for uring communication between kernel and > userspace daemon using opcode the IORING_OP_URING_CMD. The basic > appraoch was taken from ublk. The patches are in RFC state, > some major changes are still to be expected. > First, thanks for tackling this, this is a pretty big project and pretty important, you've put a lot of work into this and it's pretty great. A few things that I've pointed out elsewhere, but bear repeating and keeping in mind for the entire patch series. 1. Make sure you've got changelogs. There's several patches that just don't have changelogs. I get things where it's like "add a mmap interface", but it would be good to have an explanation as to why you're adding it and what we hope to get out of that change. 2. Again as I stated elsewhere, you add a bunch of structs and stuff that aren't related to the current patch, which makes it difficult for me to work out what's needed or how it's used, so I go back and forth between the code and the patch a lot, and I've probably missed a few things. 3. Drop the CPU scheduling changes for this first pass. The performance optimizations are definitely worth pursuing, but I don't want to get hung up in waiting on the scheduler dependencies to land. Additionally what looks like it works in your setup may not necessarily be good for everybody's setup. Having the baseline stuff in and working well, and then providing patches to change the CPU stuff in a way that we can test in a variety of different environments to validate the wins would be better. As someone who has to regularly go figure out what in the scheduler changed to make all of our metrics look bad again, I'm very wary of changes that make CPU selection policy decisions in a way that aren't changeable without changing the code. Thanks, Josef