From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A00C25B74 for ; Thu, 30 May 2024 19:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 977076B0089; Thu, 30 May 2024 15:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927BB6B0095; Thu, 30 May 2024 15:09:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8996B0098; Thu, 30 May 2024 15:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E3E06B0089 for ; Thu, 30 May 2024 15:09:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08F5240B1F for ; Thu, 30 May 2024 19:09:46 +0000 (UTC) X-FDA: 82176001572.02.F1B0567 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 182BE1C002B for ; Thu, 30 May 2024 19:09:43 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=z8JrxycG; spf=none (imf20.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.167.182) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717096184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=STEkyafVIcde8Faj8aThfnneXmr4cChiJsEg44JX/7E=; b=inqwFhcAPR2d9og4nJY+asD2spHKC4lLew9zxlO5LBiU2PH9zWhCt0KiqFqiSC4pzbyIcq dqtpBWLsPpjib8nGDJPeI2C7vld9pSpnUUG4Tp6BH+K87hPolHhU40lQ32dqScdONd4Hod Dz2T9kbvETrgdwHVzPRTCOxbTb0oXss= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717096184; a=rsa-sha256; cv=none; b=c0RJLorKao7nZvY7VJJth9fMJCzQdZuPn4UYRvOwMjlhV0kuRaBNtQ1RzSp8plOKW/xLC8 CrV6SX8kr/evKptOcYKO7/8l6dHjGNniBmlnYNqJmnSf5RJCq5nUDW1UsncqJtBxxPXOg5 s+8+/ViagkP39ac28nAuy77GquMBtO4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=z8JrxycG; spf=none (imf20.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.167.182) smtp.mailfrom=josef@toxicpanda.com; dmarc=none Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3cabac56b38so690366b6e.3 for ; Thu, 30 May 2024 12:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1717096183; x=1717700983; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=STEkyafVIcde8Faj8aThfnneXmr4cChiJsEg44JX/7E=; b=z8JrxycGDbiAA995mTd0XZyjwU8IX9Y93yNr+3Z6i0MpJ1RAd3CLFUgLLnkD8WfkH6 Pofx8h1Ek6cxqn1g2aUGStBmvNMDy9GK3h5n3aifTq/s87UOChjtCzbWSL4UCdRysaDm 08fj5rWWbRuNrxQxIWOb71CvvCxolYip+IOFmOV0tZaeAUEEUjnVrKlb94eCHl4pUQgs ShLmmJlnuElaBAVChXE23TW6NHYHQbSr5NcG7xTrLmlk7rCuBkSCokq+cgNhVxNHJNSj KB3k9ufkOvpOSTU/mHo2k0uJPaq6KC1RSnMmS8kB3xZZrP7ddXvVNNtFdkYKX845+nz4 w+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717096183; x=1717700983; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=STEkyafVIcde8Faj8aThfnneXmr4cChiJsEg44JX/7E=; b=KKtkDeYEPKNwnndfScwgw+TrrZXTL3qotBjrxDE/PWEXH3YqBS5jBKhcKbg6nzU/rb 7kGTPR2nn5Io/Tj8EZUZu8AI0FNKgZEn7orS8tC+TGwNwpReDrLWVWi+NBS9ylWhGsSr jJMM+8bRbnTSyqBHTatY9d7gTHECDQ4LDxeoA81Jl3lVGMJj3y9+cJzFUIQACSFg0j29 fQHz65xGKWrLRs7T3WMVnhwVPl5FmSdkHa1qSAD4B7pFPWNhRQSWRrwbUZCgPEy6n6a8 szwGBAGuE5OVW473GP9jtzOpPBgOMJhANaDgbxlaNRkqZkAgNGygk0ZsUhpJs8aDA03k VuRQ== X-Forwarded-Encrypted: i=1; AJvYcCWqcB47I4jpZ12+SpsnBhyTP53f5kxd9fBOzthZoYEHg2TWfZSg1Rzx8eBotER5KoLHKtrW73ypuGINOFOa7qDMi7c= X-Gm-Message-State: AOJu0YzBRm1jaNiUqXT810qARY7xKu9kTjTyNghxb2WiPemgA7r31nN/ AQkVZssw+6HNGXAj7ewe2C8h+yqK745bcEsrVbKXpuo7iKfZnFtaa0el/2ZTPQw= X-Google-Smtp-Source: AGHT+IGzMKqBOeUDnXYclSdBYnjrIWAc6XIydaMi9nNxv5fMnkBfm9Ebgas0uhT0ClRRJz1TCEyANg== X-Received: by 2002:a05:6808:f8a:b0:3c9:c2fa:4585 with SMTP id 5614622812f47-3d1dcd0f337mr3580047b6e.42.1717096182765; Thu, 30 May 2024 12:09:42 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ae4a7463a5sm1004726d6.46.2024.05.30.12.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 12:09:42 -0700 (PDT) Date: Thu, 30 May 2024 15:09:41 -0400 From: Josef Bacik To: Bernd Schubert Cc: Kent Overstreet , Bernd Schubert , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org, Jens Axboe , Ming Lei , Pavel Begunkov Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring Message-ID: <20240530190941.GA2210558@perftesting> References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <5mimjjxul2sc2g7x6pttnit46pbw3astwj2giqfr4xayp63el2@fb5bgtiavwgv> <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 182BE1C002B X-Rspam-User: X-Stat-Signature: xmmwjc9acuot8apcxfzqg5z3o83y9y5z X-HE-Tag: 1717096183-790727 X-HE-Meta: U2FsdGVkX1+lXBsJ/CbBfc/P381/jzSnKzRrLNWXcHXjEYe9nBD7TN/1K7QJz8id6ITC9sZNr+5hCD8+sRl4q8wYAj12ePhD/CdD04WcaHgpBJLb1WMDnT6Dir2EclRWF8DfhA7L0bUopFPKt2yx+lNZW3G3BHUcIz2qz/KvzDEm/iexjbYl3LBXpJdh1L/Ii46bafknwZFNIkC1wOQs151fpLmnvZNGgE0CDWaWeRh1NGZniTgvFLXMg7v+9AnbH37HLgWpwogS+6UbiuPTEC7548+IuUTMJD2oADpXo2I9KF7NPP0EfqsVyMkmkZRC+IUzyLqf6xwmG0DyqWCRIVmY3fkHPD0R2vqjLp3l1ljuzE9+2fj+lro0onqsg6afQpSNdI3wYViqlcOhdnJAYUgcos06ZLTT8oJNg3IKyHKfJD3UZij1IJKYGbi6T4QdAJ8AnN9fjMfXhYQDjJIMaMr+CgY69Cxlf5l4QjPJvEhKo0EwR/oOsi5XKic5h3WDyhj/xU/ziSl2LNODy1KUZ2Ab9kskYumzuxlVc1JD5Ljre0IpY+BGhk8pZsRXZw1JmVZUWWTOLKBSfbTIOOpYCSGlI5sjUKPrzXhOL4yXnSMCVIMvSeuzOuaY6SqGyzgj3q0qPCFCQrv+O8C+lKAvOm/q7BuUAk+GNrU5nx7xAY+AbAQBjIbJJTG2kiBZRtZBxOTf4DBMcJsV1l+LM/IarxtItEAFQruMct6ahptsR/+AwBihmTWz1grmpGBGE203amQZz6+8xeTXXAmzD0s0yQMBMtk2YUiXy2Ox5+5a5xZP/JwAFVPV+1M7jPX7ZwJrl38ogW37+fM6G3TUWYOUR0kHBkjx841gPeXuUlwYKVojGLQafZnxvJ7NBNV6orlx+z9RDasctItPgYHqu4rtDzrKPJly6BbUNKTmWx1yvIBgjPnAGGcom8aiArkZntz5fjjsdhetYuaiScLvbYR pCRfI2Ys t/IQ3ld3xabqFJwMQU1FWCxfkYV83+RzWQzv/XYqTFUbmpD4EEiZZ7GlPpcfDgAnvTKNX068021DA6f2+4kSAAb0uKHjNLyBopXnsdW5Bz42TOTc8dQea1c/ZmUHPxUMzDhyTH3QjDQ4cKLBUT7/4LmJicDL27KYPymYsUOlaX/nkg7CHp4UFCnkDhcP4ZXTePAaUZ/mhSOg6VZKbpUFQ1mC3wLYuEu7u0tCNUkQUibA4D/N1tIPXEB7WPThOD6FkrDq3gfskmzcrmRPwk05upOx94WsBpeXtwyyz1lmGYKnHVEOij3QE6nCEyz9FPxoja+3ma4phRV92BM+6rnpKRzobN0RuNp/zrtoeAwiOAVtvP0pccs3ofywXv2f8fV8X0AVRVJar2LTt+hozmq8MogBbcodS9ASzWblWEaM87rZc4KXnGyY6Xk2xgu4KgKtI/Td2fW//yFN8fywweBgA7SM0zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 30, 2024 at 06:17:29PM +0200, Bernd Schubert wrote: > > > On 5/30/24 18:10, Kent Overstreet wrote: > > On Thu, May 30, 2024 at 06:02:21PM +0200, Bernd Schubert wrote: > >> Hmm, initially I had thought about writing my own ring buffer, but then > >> io-uring got IORING_OP_URING_CMD, which seems to have exactly what we > >> need? From interface point of view, io-uring seems easy to use here, > >> has everything we need and kind of the same thing is used for ublk - > >> what speaks against io-uring? And what other suggestion do you have? > >> > >> I guess the same concern would also apply to ublk_drv. > >> > >> Well, decoupling from io-uring might help to get for zero-copy, as there > >> doesn't seem to be an agreement with Mings approaches (sorry I'm only > >> silently following for now). > >> > >> From our side, a customer has pointed out security concerns for io-uring. > >> My thinking so far was to implemented the required io-uring pieces into > >> an module and access it with ioctls... Which would also allow to > >> backport it to RHEL8/RHEL9. > > > > Well, I've been starting to sketch out a ringbuffer() syscall, which > > would work on any (supported) file descriptor and give you a ringbuffer > > for reading or writing (or call it twice for both). > > > > That seems to be what fuse really wants, no? You're already using a file > > descriptor and your own RPC format, you just want a faster > > communications channel. > > Fine with me, if you have something better/simpler with less security > concerns - why not. We just need a community agreement on that. > > Do you have something I could look at? FWIW I have no strong feelings between using iouring vs any other ringbuffer mechanism we come up with in the future. That being said iouring is here now, is proven to work, and these are good performance improvements. If in the future something else comes along that gives us better performance then absolutely we should explore adding that functionality. But this solves the problem today, and I need the problem solved yesterday, so continuing with this patchset is very much a worthwhile investment, one that I'm very happy you're tackling Bernd instead of me ;). Thanks, Josef