From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D536C25B74 for ; Thu, 30 May 2024 06:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95D986B0093; Thu, 30 May 2024 02:37:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90DA16B0095; Thu, 30 May 2024 02:37:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FBEB6B0096; Thu, 30 May 2024 02:37:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F5B36B0093 for ; Thu, 30 May 2024 02:37:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3D72160E05 for ; Thu, 30 May 2024 06:37:19 +0000 (UTC) X-FDA: 82174105398.07.C4EB0BA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf10.hostedemail.com (Postfix) with ESMTP id A1D46C000D for ; Thu, 30 May 2024 06:37:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AvI7k7u4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717051037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEv8Rp028WuYIUHENUDpVezQkQxMYD9zsTc8Ri1wD24=; b=bKWF4xg99DvEqFV56orYlj02+YPowrBs3sVaN+fviVBt1Z08qyCL6+ntl9Fcxv20Py3dLq IudswfIFA9PgiO7QCF9Bla6yNxt/ShTtVYr+44M9cvDozy6BYt/JdbMCqE9Fyxt5QMMV63 nIGGt3KdK6BvtF7UbfPHcNn4zLSTkmA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AvI7k7u4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717051037; a=rsa-sha256; cv=none; b=AA3lCQXncVfZOF7+YsV9wurKpe+aVCb4qLti7CfHfRPyHWMPp0GlO6Wjeou6a5FpilK5JX aWX1Ju65YuDug6g7zI4Hik4u0UdrzVb6mAnkddvJMvB192X0/UpvN/m7/0nT8kkU4t0Buu J/4g2i7A6I0YYDuXDLajFNvjKEmfBe4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717051037; x=1748587037; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xYfnI1YzjUptr5lHZs5yUaLN1qMaYn1bInEg9WPBe/k=; b=AvI7k7u43nzeE6SGk7oBi5rSrbLHr1pCzhzUYzeZ32BA71bxynhiupaG dEMWrvaTvxdPNDU6qAZ5KJoI9VPsvtNpXrJm+VWOUGCMnBLoh3KhuNUv3 1+hyL8D4/D1KG4rUIY6y/JqoIE/KFs9c8hB5GdPV4WHDfJ5Jxz1qXYXuV U24bVjPzby7GD84SjTdpjs3gxKQLF4OW+0aM+pDSnaVCsk8/EIrQTAyTr 6anZgwf3iBImNf8nAaERfqh/rFgA1UedXs5VYO0srfgbd8z+/DlaPcJRx GeO33XVhEBriB70x2+G0H2YRFmB2WIepEWqUEB3TK6eAp19iblv9J3CX+ w==; X-CSE-ConnectionGUID: i/xdFknVR2+zEtGwBfiVHA== X-CSE-MsgGUID: MxmhsKQpT86hQhHNg00uww== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="13693271" X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="13693271" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 23:37:15 -0700 X-CSE-ConnectionGUID: rlqGgxDjQfSLc44CwICBnw== X-CSE-MsgGUID: vO77sm1ESBeeSAGc6jOhHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="36263693" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by orviesa008.jf.intel.com with ESMTP; 29 May 2024 23:37:10 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sCZPP-000Eta-2k; Thu, 30 May 2024 06:37:07 +0000 Date: Thu, 30 May 2024 14:36:59 +0800 From: kernel test robot To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] mm: shmem: add mTHP support for anonymous shmem Message-ID: <202405301430.0NRLTOWU-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A1D46C000D X-Stat-Signature: sz9rkowoc9o7brrpsd1qqzdapnjengrq X-HE-Tag: 1717051036-334334 X-HE-Meta: U2FsdGVkX18rPmoa9IjCMLz38RZ+k+aNx3r/3yorkC3XYmjdT3n78H7pJnDzJ/FtjlnRsdlJ7JTLPMAr2z92iUdQ/M3jYorSqU/EQY1FxEVLHL2iom2ERCzy5agZL2GsCh9R90aJibOgmWWSkBVkCQlGwYbsLlDiLknGZXR9o5ACXZtmbdfZjk2PcISH7FWQUtacKh7LRMtf2nVruSobklGcRIBg8dMZZ/fkcB1dAk+IVeKOzp8v7iM5WFafKBgo8dnyzOUK3IdbcUSOAdSwg7uIg47GArMrD0FzFMcNur1Y0vCs/jxEH46B7nxwSOAQXSI+fJqOMpFA001zbWzZDq165eb4TkRK0pibrZGeBgzvKzsKcoRTa2l98ygm15CenqfN2xpP+mRMu7F/DFvo+oyZETk/xAe7ihxHgecveODUPPrR8+bVY35kMzCCQF00dVZgFf2dwek9blN8nM+wAgQLOr7BfEvqXVLlNlV9vE6CP/KNmOCBZZccmHGe01iphyS3oziDhACkQvcE1W4DxhPL4jNtLu9HPN13fls6m1my9TQvMCYNe1BUaASTCeo0XJs3JNAyPIbvZrvUbnrbDG2xUKaevT8uND0iCFLY0PGUXoFiWXwgHBqiWpMh0LurwEfWA+GGhSg83lwcAkq+oObmJfSQYnGc0Nd0xr2VulVyT8dfLA3xiJh9P5vjMu6lRbRb93mv+Xye9/a61bh4EsEOc50VrHUtGf9X+yIeyn++q0whVFdHLa2+TyhvxQii222HZDAmiwDftJ9GlAvowVqIYWTlVyXS2G5MkrNowfOMDWyjb8fRnIUbqNde5/F5rHu1VHbyWjMRz/d2LS4/IxjoMoHu68BPatDGPBi4vrdrPFeXumTHzmwQQxeYuc2sboQk7JZbNuu//0AdQYqvVjb5WybYOi5e04S47gY5YHAbb160IZ9qPTDOUrnh5ojWPKId4I0LcCFKixXslM5 yjdVweOu gSTiwJcQh8ybX5x/LRVLL29/CRnwgso95LNPDIKrXPbE4qCMSeftjC9a9ciTObN9h9cej1JJG7uEccvT3AdfUFvtr6OoZvmHt2YL9vU8YWuYsV1RZ/cNK+w9xqX+Ug0lrAyHtSGnQ5YYyMLHIvDQLQDUefBEo5YpzDnlI4A+JMCOoXHLlABUZ1ybbNF85HW1yzEPaAT87oZoji+aOo1hK5hvsGepRCUEb4nw6lhejtrJge7seBbQD/HpE0DJnH/MjxGC8PDiC1Pf1uOYq5WszpIUcXXIxzGuycM81b83/yuONdnJu4jMZ4kOrdAGezrIoVJvS1QQOpd+ioPdPOy32bKQsPdxeG/6CmsHYaM3DOy4tdCqrfUS2YR4JHcY39wYyQKwr851NNiG/jUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baolin, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on next-20240529] [cannot apply to linus/master v6.10-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/mm-memory-extend-finish_fault-to-support-large-folio/20240530-100805 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/ec35a23026dd016705d211e85163cabe07681516.1717033868.git.baolin.wang%40linux.alibaba.com patch subject: [PATCH v3 4/6] mm: shmem: add mTHP support for anonymous shmem config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240530/202405301430.0NRLTOWU-lkp@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project bafda89a0944d947fc4b3b5663185e07a397ac30) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240530/202405301430.0NRLTOWU-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405301430.0NRLTOWU-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/shmem.c:28: In file included from include/linux/ramfs.h:5: In file included from include/linux/fs_parser.h:11: In file included from include/linux/fs_context.h:14: In file included from include/linux/security.h:33: In file included from include/linux/mm.h:2245: include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> mm/shmem.c:1748:14: warning: variable 'suitable_orders' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 1748 | } else if (orders & BIT(HPAGE_PMD_ORDER)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/shmem.c:1766:25: note: uninitialized use occurs here 1766 | order = highest_order(suitable_orders); | ^~~~~~~~~~~~~~~ mm/shmem.c:1748:10: note: remove the 'if' if its condition is always true 1748 | } else if (orders & BIT(HPAGE_PMD_ORDER)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/shmem.c:1736:31: note: initialize the variable 'suitable_orders' to silence this warning 1736 | unsigned long suitable_orders; | ^ | = 0 2 warnings generated. vim +1748 mm/shmem.c 1728 1729 static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, 1730 gfp_t gfp, struct inode *inode, pgoff_t index, 1731 struct mm_struct *fault_mm, unsigned long orders) 1732 { 1733 struct address_space *mapping = inode->i_mapping; 1734 struct shmem_inode_info *info = SHMEM_I(inode); 1735 struct vm_area_struct *vma = vmf ? vmf->vma : NULL; 1736 unsigned long suitable_orders; 1737 struct folio *folio = NULL; 1738 long pages; 1739 int error, order; 1740 1741 if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) 1742 orders = 0; 1743 1744 if (orders > 0) { 1745 if (vma && vma_is_anon_shmem(vma)) { 1746 suitable_orders = anon_shmem_suitable_orders(inode, vmf, 1747 mapping, index, orders); > 1748 } else if (orders & BIT(HPAGE_PMD_ORDER)) { 1749 pages = HPAGE_PMD_NR; 1750 suitable_orders = BIT(HPAGE_PMD_ORDER); 1751 index = round_down(index, HPAGE_PMD_NR); 1752 1753 /* 1754 * Check for conflict before waiting on a huge allocation. 1755 * Conflict might be that a huge page has just been allocated 1756 * and added to page cache by a racing thread, or that there 1757 * is already at least one small page in the huge extent. 1758 * Be careful to retry when appropriate, but not forever! 1759 * Elsewhere -EEXIST would be the right code, but not here. 1760 */ 1761 if (xa_find(&mapping->i_pages, &index, 1762 index + HPAGE_PMD_NR - 1, XA_PRESENT)) 1763 return ERR_PTR(-E2BIG); 1764 } 1765 1766 order = highest_order(suitable_orders); 1767 while (suitable_orders) { 1768 pages = 1UL << order; 1769 index = round_down(index, pages); 1770 folio = shmem_alloc_folio(gfp, order, info, index); 1771 if (folio) 1772 goto allocated; 1773 1774 if (pages == HPAGE_PMD_NR) 1775 count_vm_event(THP_FILE_FALLBACK); 1776 order = next_order(&suitable_orders, order); 1777 } 1778 } else { 1779 pages = 1; 1780 folio = shmem_alloc_folio(gfp, 0, info, index); 1781 } 1782 if (!folio) 1783 return ERR_PTR(-ENOMEM); 1784 1785 allocated: 1786 __folio_set_locked(folio); 1787 __folio_set_swapbacked(folio); 1788 1789 gfp &= GFP_RECLAIM_MASK; 1790 error = mem_cgroup_charge(folio, fault_mm, gfp); 1791 if (error) { 1792 if (xa_find(&mapping->i_pages, &index, 1793 index + pages - 1, XA_PRESENT)) { 1794 error = -EEXIST; 1795 } else if (pages == HPAGE_PMD_NR) { 1796 count_vm_event(THP_FILE_FALLBACK); 1797 count_vm_event(THP_FILE_FALLBACK_CHARGE); 1798 } 1799 goto unlock; 1800 } 1801 1802 error = shmem_add_to_page_cache(folio, mapping, index, NULL, gfp); 1803 if (error) 1804 goto unlock; 1805 1806 error = shmem_inode_acct_blocks(inode, pages); 1807 if (error) { 1808 struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); 1809 long freed; 1810 /* 1811 * Try to reclaim some space by splitting a few 1812 * large folios beyond i_size on the filesystem. 1813 */ 1814 shmem_unused_huge_shrink(sbinfo, NULL, 2); 1815 /* 1816 * And do a shmem_recalc_inode() to account for freed pages: 1817 * except our folio is there in cache, so not quite balanced. 1818 */ 1819 spin_lock(&info->lock); 1820 freed = pages + info->alloced - info->swapped - 1821 READ_ONCE(mapping->nrpages); 1822 if (freed > 0) 1823 info->alloced -= freed; 1824 spin_unlock(&info->lock); 1825 if (freed > 0) 1826 shmem_inode_unacct_blocks(inode, freed); 1827 error = shmem_inode_acct_blocks(inode, pages); 1828 if (error) { 1829 filemap_remove_folio(folio); 1830 goto unlock; 1831 } 1832 } 1833 1834 shmem_recalc_inode(inode, pages, 0); 1835 folio_add_lru(folio); 1836 return folio; 1837 1838 unlock: 1839 folio_unlock(folio); 1840 folio_put(folio); 1841 return ERR_PTR(error); 1842 } 1843 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki