From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A19C25B7E for ; Thu, 30 May 2024 20:05:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F239F6B00A3; Thu, 30 May 2024 16:05:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED3BD6B00A4; Thu, 30 May 2024 16:05:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC43E6B00A5; Thu, 30 May 2024 16:05:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BBDB16B00A3 for ; Thu, 30 May 2024 16:05:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 62B63C0D3F for ; Thu, 30 May 2024 20:05:45 +0000 (UTC) X-FDA: 82176142650.14.4BFF3D5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id B1630140004 for ; Thu, 30 May 2024 20:05:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ButqOVXN; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717099543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8LAtmFegHwyHiShddEqtFydMRSngBCshlNojH0W+UyQ=; b=d103deIY73xt9BVFqC+EiVbsPtZ+6PZIeDjC+kMappkv3weXRl8d2GXQpX2DgF2jUZSmGs gbCAQIcK20ffL7esigQMqmz99+oG6yziapNZgIxs8vqIuJQ4HiWaY3GfhSELIalu4iaALk tIS45w+Aba+9Y4F9E2KrvVF3+Ou89Qg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ButqOVXN; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717099543; a=rsa-sha256; cv=none; b=OpIPcPGAIN7pJFj5Ioy/Az5W3TzEID1phF9AX7qncPto5l4wupSeUTvGx6P+I8MiyZxiX2 u/gelYDKaTS9ZmGSji8ysTpCmTFhzYTUS5lFLtGBgWyV7pPXZFC4zh+H0U28ebDTb+yxl6 Rcz6xln+TbAX8TuQt/UODSqrync8k1s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F255B62958; Thu, 30 May 2024 20:05:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CCAC2BBFC; Thu, 30 May 2024 20:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717099542; bh=kRBwLlYCuKNk3Fl0J0lD/a6vXcmLqtYeu1cqzVACock=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ButqOVXNDS+TCCelEMmoNeITCkjmvKoaPnVCR1oqMNKRNyy/ojaP70KejUyYhVR5L oKgk0iKAshkcBnZeSMx2bLClJgskdhV22Jluwx6Z/GD9ykQferXI6Gr5borcBHpUK5 XWh5m37/X/nJIDKsQ9uu1OVUbgvb5O0MSlex87LA= Date: Thu, 30 May 2024 13:05:41 -0700 From: Andrew Morton To: Cc: , , , <21cnbao@gmail.com>, , , , , , "Hailong . Liu" Subject: Re: [RFC PATCH] mm/vmalloc: fix vbq->free breakage Message-Id: <20240530130541.c615fcfc1e6f211199315e13@linux-foundation.org> In-Reply-To: <20240530093108.4512-1-hailong.liu@oppo.com> References: <20240530093108.4512-1-hailong.liu@oppo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B1630140004 X-Stat-Signature: prkrg89mwd943u534y56q5juffn3skfh X-HE-Tag: 1717099543-330401 X-HE-Meta: U2FsdGVkX1+G9MIo70pY7cjwVBMC4ExgnmAmI0uDeFKwSn++QkqYZwpKh/ilIiZUzFbdY7yMzANWU8w1KdCWIjwcTkZxBgSg39g8aTt7FHvG53V4t09S2vTcF88FhtmLnhwS7oLFPTkplkoXocDNp57XCGMK6DN3IhB6JWjE9z55oUppsHNEt7pOnSQT3Sn5YS5Z3Ps1cmsKUyx8Ul9GvqHgUJKdK/pSNAda0W8hqS323UYy34GHG1tGMZo4GCsgRvf4236JnWquYdvWkyQN0K1Pb/7xGy9Jhpb2Pr9SCtyn+WKloUbP/Pa8VeOOToVSROuCpmcsUXX8SW37VKOvdZk9LsmSut4gr2zKBf4I7narnmigGfmlAmzN+xc51u26ukY5KA8l9HASJ1N8QqYFJozUc4nQInbFyj0yAngOYwH6xRZpIMZhd+4DAJUCMztdtHH9BER0no/UBHowGNUuV/wMLtyG/mNCg+QB0kC9UGsJ2hLTNIfq+00O35cv2zz9q2/buMSuU2kKuXc3DJ7lavbn1dXXJAQviWh1+WKZ/CuWZ3Pm6HcpMXEQmWL1kEpkslbVSylmAMUpYJOzYFg3ySEfwQcA8Mv30ind5nh3WIZwzzUtnqUuZwCxz8kIt45TCGJh2CVyvXldI9SRVgtVyS42aRr4UWqxPjp7d2ZeS54xYEuodVQTIoAaxE7QBf/OAM7Sb/CS4KJ34wIcZoFBeTsDhYE1PXWmpic9D16PZ335NTXnVganYPhsVrhYE6f3HU8wnRtKsKBWEn7GbJLogxVdtNOQOKCcmHn/g7MMaZ0JVxuIolror5PpwUkLEd7/Cocl92TxiJWppMPsZq1PoIRGUHWKQFrlMVlYtT8AAs92MpswUAopO9IOmliwLoIq1OZYxNKHqkyhl+lWClewK2JDytXGg/1ABYln/KicO5zn39E9999Pu/kIBn2zcivBDjnrbx+FoewSssBHio7 sFEMmtsh +lWYAqgQE4R0WNl9UnyZW8xbcTxMMfPROQQnY54ZZMVaxPPUVZ6wqTtZ1XcgovoxN40BtWKffjI4XT9mp9CkLG9my6b885wVHlSG3e41K1OZoVhrqLfPAsAjarUQCpjFeMLE6FGTE7UzSBtGJpp/zK5RzzMv1HZ4eJtSs6zUWe2MNi4Vk1qbLkyH9Uq26/WshJXjWCKW0t6TYRLtGzf/wIHIokjQ9jBFU0hQ4Dr++EHxDDroDnTG8z9MjOT9V5uu5jOCUd6aXbmuxsoVNZkYujEjzRvyByAu3D4+P4/78U4vC9k0PgUCQmzny+jusZVDOjkiVC0ytB3YIckkOkgkoqyVbR0lUJojUTnoJGR020MLDW2sCMbtJMGxaS+8BP2GZDC9VSYmhJih0z2GrS8wlfpIcHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 May 2024 17:31:08 +0800 wrote: > From: "hailong.liu" > > The function xa_for_each() in _vm_unmap_aliases() loops through all > vbs. However, since commit 062eacf57ad9 ("mm: vmalloc: remove a global > vmap_blocks xarray") the vb from xarray may not be on the corresponding > CPU vmap_block_queue. Consequently, purge_fragmented_block() might > use the wrong vbq->lock to protect the free list, leading to vbq->free > breakage. > > ... > > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2269,10 +2269,9 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) > for_each_possible_cpu(cpu) { > struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, cpu); > struct vmap_block *vb; > - unsigned long idx; > > rcu_read_lock(); > - xa_for_each(&vbq->vmap_blocks, idx, vb) { > + list_for_each_entry_rcu(vb, &vbq->free, free_list) { > spin_lock(&vb->lock); > > /* > --- > https://lore.kernel.org/all/20240530025144.1570865-1-zhaoyang.huang@unisoc.com/ > BTW, zhangyang also encounter the same issue, maybe revert commit not a > better solution. we need a map to get vbq from vb. I borrowed the Fixes: from that patch and added cc:stable, pending confirmation that the runtime effects are significant.