From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5213FC25B74 for ; Thu, 30 May 2024 20:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63696B009E; Thu, 30 May 2024 16:03:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13296B009F; Thu, 30 May 2024 16:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB34C6B00A0; Thu, 30 May 2024 16:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8DD506B009E for ; Thu, 30 May 2024 16:03:23 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F1EDC0E48 for ; Thu, 30 May 2024 20:03:23 +0000 (UTC) X-FDA: 82176136686.13.AF1E150 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 5336B100009 for ; Thu, 30 May 2024 20:03:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KG8OgMFc; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717099400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8WIvvZ5hk/ptSvSBf6Ha9B8uNyWqyavLCIUNhhI3Qjw=; b=8OUumIDW4vuMuRWFZkBJGog8oGZ7d6H11F8KhNBgV5srIefhGmcBPByY0PdC/iZ0JTs1/k cNmVN54fopptW4/PY2/VZK67C95EepN5v0Y2h5VlWa+xGKgVr1nr9SNlfp4KTEIIoCIuB7 V4UTtTwvOk/OeDB9YOYoONVp8Cs1S1c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KG8OgMFc; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717099400; a=rsa-sha256; cv=none; b=WPe4EXm/nXpLQvIj4qznhf0bwxc05dOqErpc8sqwOTKtBDtic8aIQ0NLYPIK0JVS05Z0Ar qwz2rh1i4Detip9yA7LviEpLF3URwpUQHJD2/idm353ys/663yI43AT7FHJbqdKNxgPmMn TIpkVLp8I/Ft4JkIxsjMX+zlHCLOWtA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 51D8662989; Thu, 30 May 2024 20:03:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 995FEC2BBFC; Thu, 30 May 2024 20:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717099399; bh=2Zk9G4N1QVb6dL/7eakVW9j4sKX8lEMickryI8gm060=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KG8OgMFc2LRGn6x9Y62ndM1Cvk9t0TmadtaEYAsyIXFPl3B7/RAlkOSxYeReyw6ro viThB6cIZ9P2/i8ZGwC88TQaXdFcU4sevPvdES7ZDT4GU9pXN+/jQbtGcPDCsgbA6+ DQs2uCwMZujFkb3gaXK8uc/DMXlET8eXedwqkgXA= Date: Thu, 30 May 2024 13:03:18 -0700 From: Andrew Morton To: Cc: , , , <21cnbao@gmail.com>, , , , , , "Hailong . Liu" Subject: Re: [RFC PATCH] mm/vmalloc: fix vbq->free breakage Message-Id: <20240530130318.2a78c0797c352a4d38cfb2c1@linux-foundation.org> In-Reply-To: <20240530093108.4512-1-hailong.liu@oppo.com> References: <20240530093108.4512-1-hailong.liu@oppo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5336B100009 X-Stat-Signature: n6y9nf5mkc165tuomcnfxikbdnjguoe5 X-HE-Tag: 1717099400-124745 X-HE-Meta: U2FsdGVkX18dA1h1p5VfBKmlBnArR9i24TubbsypvF8RtiPprjy4vVMWgoPR8TLkiKz+4ySd9CGQQkKgT4pYvaOCyaSwX654xWifjktRhWfzHT8iTmF9qpaT1SCWnJ8hT3hR+1Q7xmiMYBzSYC+GxRIxrxmHawOZkvju+lHBUGAYCE5d9XIOXbV6BMWt2IO3CadqO4Mf3o0J1l/WGSFvOkaNXxUOw3/Frpu1TEPGOq+I9zFMknbOUHK1H8mHRK/B4kvsMyMY/S/vCZjQ+hSc6o+bz0rRFeTPu5SqAI/e7VM9jiiMEmKJPXkheZw8TnLE09s3EimmtE0z+uja60YumpJKTcWY4Nm/27aj3BpGO3NsyJPqgqrJKy0YBBgSSPL8cDGy+Xx5ZU9ar/0WhbOdLYtKOc1xrQ3sy6CK4/2Z6Lgs8AhBd9MiEHiG62QyLmHgzyJT7CcW6toK2mgvDRSF4+mRezS+zquREI0VzhIxR4y7dxyigwoLgwf7sax+6sGcXWHmJncl2A+Fztc+sdBwhsXKd2SxKeLBMGlBthcZDd/S34JSPrGM/JlabAlPRcksrLdBLRkSub/ix9u/iNXEVZAPLeG/IMWCeJiMODK7BStZKLxDgMmmAnwjRFAW6C/DHxbMr0u3mzO1cYSnKYcYwlV14qw10uNO54OTStqtM5ScYSwl6iQLqodJMLnz/i3ATD5uQbn6hQbb/msuSptyqZwBQda6HApIOAFrKQRcYQmOWB33OnJwqhVHOOD3qHXhXRxsZtOF1wd/NpMmJYNeWhPIE37ucYhfdIV9LCPJlOp+nhYEznkuO3/iJ+pAkJt5zmUb3I22vtxex7HvFr4C+ds5sTTScOm/9+10rrh1NHExKkmD/yiq2NoIVProcx2y8keGZvc2W6L8dhUfSfl35KBK1QSZmKHzco802OmK5Rrm1b69E6S4SAz747AojGk0rE/I3/QVNetLVLrIajW tKp3Uk3q sLygvyXeZx1ZKqqR6F2vdQEvwL/RiSsJUcAm1XpMFp95AsIwLsLohfhlH3Q33f4NJ2CDKJpI8pC27CJ6YGmOOmrGbrc/6VgSMPEAUcs0GNY3t7VdmYWSL7016TMa6vPrxAuXx8L+LR/W9QKkwz1LrHAqirFFG55YgfFP9/8ULKgYO3gzEAJUGTMH5oFoT4q9RZ1yGSrYB12RuhnIEWRkI4vXf0NAA6SBLrRaJmcpXXF/hza2EsFOCUD/YnyDep7H7Bf0YG28KD+GOWszxc/mjRBtZ1DcPtwp9+3zoxsbNIy1q+PluEaC0WxonuCW2mJbsBENmcYEh7uafotnbN4FbTgp6GfPa4MgR52K0gok3kRJbNgfYyYj9eUlUrAPrN3TQ1X0Zrdwy2HePW0dQt9NSfrzISA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 May 2024 17:31:08 +0800 wrote: > From: "hailong.liu" > > The function xa_for_each() in _vm_unmap_aliases() loops through all > vbs. However, since commit 062eacf57ad9 ("mm: vmalloc: remove a global > vmap_blocks xarray") the vb from xarray may not be on the corresponding > CPU vmap_block_queue. Consequently, purge_fragmented_block() might > use the wrong vbq->lock to protect the free list, leading to vbq->free > breakage. What are the userspace-visible runtime effects of this change? > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d12a17fc0c17..869e7788a7d5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2269,10 +2269,9 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) > for_each_possible_cpu(cpu) { > struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, cpu); > struct vmap_block *vb; > - unsigned long idx; > > rcu_read_lock(); > - xa_for_each(&vbq->vmap_blocks, idx, vb) { > + list_for_each_entry_rcu(vb, &vbq->free, free_list) { > spin_lock(&vb->lock); > > /* > --- > https://lore.kernel.org/all/20240530025144.1570865-1-zhaoyang.huang@unisoc.com/ > BTW, zhangyang also encounter the same issue, maybe revert commit not a > better solution. we need a map to get vbq from vb. That patch didn't describe the runtime effects either. Folks, please always do this. So that others can decide whether their kernel needs the fix, and so that others can decide whether this fix might address an issue which their users are reporting.