From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38556C25B74 for ; Thu, 30 May 2024 18:55:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E5826B0092; Thu, 30 May 2024 14:55:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 995726B0095; Thu, 30 May 2024 14:55:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85D206B0098; Thu, 30 May 2024 14:55:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 67E266B0092 for ; Thu, 30 May 2024 14:55:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D8BA21405DF for ; Thu, 30 May 2024 18:55:24 +0000 (UTC) X-FDA: 82175965368.22.C52F3C5 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id C001AA0015 for ; Thu, 30 May 2024 18:55:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iw1pGLR2; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717095323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qCwDNVvoLckV2y4/aZXJohvjkiQuKxt5yo00ZDtV4lI=; b=XrMeut+f+8FIv3seLLsE8Ny4SsN0ruzaB07lhhW+d+2hvAjdyCflDpbR2mec5KZVi40Pce zhx5abhMyd9yvgxMR0mJrgiZS4vlDd721BjqN2PYBObddoo7hShQDQcoNmf7XxhE21vLWu UPMBqyjgTCXW3wrFeKGiTBY9rd9iYvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717095323; a=rsa-sha256; cv=none; b=56xPqK7yzlO+l/CUEVZsoCt52/fncHPRBIsQtw/jfPQwkpq4Szbj5NCnl/ANibPJvFk+WJ zHXve8SCpKYUYfMyMYKjvu04IDW/uzMnT45yOs9An6X6/TqETvo+ILbx7Ef3rzaFe3Qtms wpjgQZ/OhcXzuIjNOR4ay63t+EVOJEc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iw1pGLR2; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CBE91CE0BDA; Thu, 30 May 2024 18:55:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7642C32781; Thu, 30 May 2024 18:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717095319; bh=4hWBQo8mKhTDOaJg0ytrw+HQ2Vee7IeEmNaUpqVR9Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iw1pGLR2r+v8CUGMhN5abhUVsfMLtQajfepQTw58H/C9SEHWTdsQJVctscnEg4Fk2 UMUHY7LTTHkyxx+aSBivctH9wxOl3HmMhOYzWmgqAPXp1AKtF81keyxJRcvRMe1mQj IfyrrC1diBcUuv0nb0GJjvggBECt8mTxNLJJOTh0= Date: Thu, 30 May 2024 11:55:18 -0700 From: Andrew Morton To: Tejun Heo Cc: Kemeng Shi , willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] Add helper functions to remove repeated code and improve readability of cgroup writeback Message-Id: <20240530115518.a4be2d0afa4139e346407583@linux-foundation.org> In-Reply-To: References: <20240514125254.142203-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C001AA0015 X-Rspam-User: X-Stat-Signature: sms6saiz1ukqrzrtgf658hrwnqditoti X-HE-Tag: 1717095322-568238 X-HE-Meta: U2FsdGVkX18+5AYvIlb5dlQtVqZN01vnna/nfI6xy8IMpGNOkjfL9f4ymdDqg6ZrEtAyrvcE22NkYD22j2jDzWH049JWALDLl4IdPwCwcbZzMQzhzxz8dDLjv8wgj95IyIEW1Zh7Pt9I7R3u2MBF4ojrBZwHYO9vcZwHZRUUEFSCpjpAmOyg7SdDgwjaZIvgss2mIDaYP88Kl2nlSbzCwkdV6j3PL+sUxvWnJVbFuP8XdIIeLGcZxaAPH2l5zCr6fmEzuih9AZj3E1mMtksrCr43qwO3+Lwjg/5OSt9khTSuyg0RH60KIxbjeccQDQnzCvfsLkBXesaFRFsz5LU85Qzi46lty4X2E2z3caE0Tt3gkWmTFaQhY1jwaqnKFWwuJgIra3XiLqOkIrxQAxQnaJrzHghmnrq+PaqrzXHeidL5rDwsPFLegz9jxBuMlLFP6LlMK3BAZRxT/uBEalDLKZHNHgdMiQsldCjccan21cdi+R5h7dm1MrK1hOe9mkoFGt+uK7u7s5mZBgkcyCb5EJGQTVQPUhsQ/RM8kG2cEA0m2JsnqbTrVoJ3K+KfEAw1vvcyWlY4JHtxf/bKPpDukixINFdPBEif2xFqRAfPYDYaB8pcWNh/ojFB06Mrjbt8vjq55zlU9VBlgJNxK2z9zysg1OftBQnDibbY6E/UCcq/KKpDUv5i1iaA+e6XyW/6IURsLqdxWnAXOWklDS7ooS7kCZ91n+LblLJ4stqC0sp/2HfB5uHACN3Nu0KMgaPRtkOcjYyoxMOs7TEZXZCIivIYutYeobablxVGBIma5YTJeczg4X9RWuVgiCu/2gRHuAGIcqUVhpSnNXnuzJuY0tek27VuVUMB1i4UOHsprmkXP1yMoliHl+Jwuy8QwcGQhkhs9D9sJMP4bvSzI/cikjtxvrGgPSLCPNCisL00i6BdO1ivZ7CsD0EqjbRohAY9RQBv8KFw7zEhA7CobKt zaMbmQQA WTASiYvqJ/oV9tToJ+OaXTKBoS7Vwk+PTOtkCtj8qrTBSax7XxO65sZyg/yp4P7Ln0OpGeg6kHt1YQvEk77gop9sxZvxHNzRa+qjeDK40Ra5mzv/6w8HgVyGTLYLcezxQFkEml95UWE76SpdcqvQLsCvDfz5Xs3ZIeWhLBkwtdvL9G2WUF6gXYw0r/U2/EKcEaL2wN+JqRc1ajv9j3Z4WsBBPRlONW88uwGBf/HNk2EWn9ZqCKgSU9ng4heXRi3cB6juRW4O6gJxcGs0eoUJW6w4qmDMe6dou3ylX2N/87jFZEfPbfN/QyXRyRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 May 2024 08:35:05 -1000 Tejun Heo wrote: > Hello, > > Sorry about the long delay. The first seven patches look fine to me and > improve code readability quite a bit. Andrew, would you mind applying the > first seven? > Thanks. All 8 are in the mm-unstable branch of mm.git. I've added a note to the eighth, to wait and see how that unfolds.