From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DF5C25B74 for ; Thu, 30 May 2024 15:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD09F6B0099; Thu, 30 May 2024 11:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80786B009A; Thu, 30 May 2024 11:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A70186B009B; Thu, 30 May 2024 11:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8A8386B0099 for ; Thu, 30 May 2024 11:16:59 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C3B5141725 for ; Thu, 30 May 2024 15:16:59 +0000 (UTC) X-FDA: 82175414958.28.C6F18C2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 8FC63180004 for ; Thu, 30 May 2024 15:16:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JqM9B8lg; spf=pass (imf24.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717082216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ORYwaxh9up/d2sIKUXpb0kYzb0BU20ZxfZelxBlvNq0=; b=HPsp3rlX0pAtyOcK6nOuXmK3WkSi04gJycvgBvByjeXUgDcSOzzUJgUeCM1ttE54YseEIk e8CJS2j3iyQ11Ulj5r6d1IOADrn3tVj6lj2f/CyRaT+pJWpiheCKxvlxR2M3tYd4TmutLB TC8xX1OMiiLe7IzUmboIb94nWi2aD/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717082216; a=rsa-sha256; cv=none; b=Isk3XtIh9pnp4JX0uMh2fOZbCf5tybM+E+g3i/aPJYcQ/Czes01QeoOX36gD1Oxq7zD2w5 oiiz5dizBg7l+4zeMp5HC64WkuipVXK02JoBNLJbpOQ6nvWBoVRQF0cZ7N/XEX1sACmpw+ QuzNx6mkCWgnKRJr9/h0EFQSXxqyPFo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JqM9B8lg; spf=pass (imf24.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6C771625F2; Thu, 30 May 2024 15:16:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE0DFC32781; Thu, 30 May 2024 15:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717082215; bh=fa0yMmxC2QPbMThwYz+/xLlUrjogilIctWdLDj2RcM0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JqM9B8lgLMEU14G4JMKkVxyi0rQSZ0GgNxBmdZ31ubamsPc3dAsXAPpNIsH/KHkIg mKhYPU5eqT0XEfOdVIfwx3e1xJ/9bslazZjlL6GJRYiLyzFI5/FHsgY5alz4vsg+Yl uxYZhauXnZkjj18On86xNKMvuypSdlN9XZ341erSw5lylEkj7AtuXzWoOTsLAA+uAH 7cpnm2s5ZS9XFX+TsFyPGXV0a2VoFX87MeUHrFZVnrfpcZvwi7/vMGjOioJSAemWNm n8Cx1Mty3Qw/sNkVaN07nYH353czFcdFcGpoJvTruWwqicqmEXb6+4VLuvZiMVxAbv lNJWpwXOdPpJw== Date: Thu, 30 May 2024 08:16:53 -0700 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , Alexander Duyck , Andrew Morton , Subject: Re: [PATCH net-next v5 01/13] mm: page_frag: add a test module for page_frag Message-ID: <20240530081653.769e4377@kernel.org> In-Reply-To: <1cba403b-a2c7-5706-78b7-91ccc6caa53b@huawei.com> References: <20240528125604.63048-1-linyunsheng@huawei.com> <20240528125604.63048-2-linyunsheng@huawei.com> <20240529172938.3a83784d@kernel.org> <1cba403b-a2c7-5706-78b7-91ccc6caa53b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8FC63180004 X-Rspam-User: X-Stat-Signature: axbs8bxipcdeuyomc7ki75n9qhdzr3ng X-HE-Tag: 1717082216-164247 X-HE-Meta: U2FsdGVkX1/NzrNDlOn7mvXAg4uzd3xA6rmu4E0N62bS9bEjEPmViJhS2Ze0lc2l5HN/ofAT4zY4FND5mAGFFRNUy6P44jrKkoBKcVV0lt2xfdjfX2bn6f+MOh9uWS91H1beLosifFDXDncgueRMb+NEdvax2qZL6uZyu8G6iGMCnCFm7YZaEziUoCdwr9LwGCDRVoAXotJAZIDWJowrfcTyZN+u8+igKwD9UWRYIeZ1eULPhLVu/4IcDyH6i14yBrcbY+fPFz+N2wCPKybHBI9FLvcAhVZaBaLKVHUgqV8oapfPJEvQJ9izjvbqrRi/XEFI9MGXmU5k2y3Hk7CgPdGXXaWlh0bz1ps669G+0Yow0zMMj3Qy+ZzOXExBuEge8cXpQM9JBAZGjeM9act+Zl+UdUEibJFBLSLMN77tyG964DcyqZabXAiE4lRdedmdad8lzKR3YAcW5hO2wxCN+5Iaxsmh0LgnjUTUY4yz7EY6bLv+sAk4Xd8k44zHIAnqZVP7j7W29LUBd1CcO3ExF79CZ/Rb1sylI5OCSJ230Sv3EpMrFzNGZAYQTZiJzqWfhXBqBPHkxu72IHHbaCJK3z1LAJLJUpEORhaKt3O46Z3NngEKz6rX1gTPkhlTmZuSe+/X8EJ8EBcqJPh57uoxeRBCGfQ6X/uMVLVX7HR3lfAqQFMRuV3lbPHQ3mevTyTf3nDJXkv8QcjD9DvJHS8pQ1wkdDrQ1oGxQf1Ds21FvBm8EQXeBG0PtsplhOnvCFrNy8ltAZgZ+N3j6h5PGbIJx3f+AgQQqR9AxfsSCGMPqeKB0QP+xtrz7RuPvInrp13ApKTP2ld+DeeFHkspWAISi85KEoKwkEnklnH6/zGJ3iBZ3FK6AFUYvloXy9LdRgB1hgPmgG92NGtjNr0Gpw0g6ra54K5AnSNF0zIkzK/HrziZYUrTnV7U32Edf9UryHpfhvc6IW2ATWhmGd6Sg0Y HfhEFI1i R1Bzznjvw2dBsBlTqcvsYUR16Y96MHEKYI/1HlbqC7znJoWp7lwaX2InoPTNUmXUrOl9tp0hx+T3u+H3gGDHB7ANMAf8W0gPGKVH+xkyVnzfG9FD5DUlboeKi6Iex9r3XVJvh2tII0tCvlGY/4eqqgvoMh1k3qsVTd/8wAWVaA/XepqeU8PhFenqtb0oo6fa5i3UYIHGagQv2Av6hF5X1mpCg21exLsmM7HSxlm+r0P1XLiOPNTKXuF8wHGul6Ar5m6p7+IxXnevDyVVpgvuiI8EjmW4/qnDCBMae3cJM7S42uXf20JJdJV7xnZ3Qlc9x3y1wytwYwjuc3GM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 May 2024 17:17:17 +0800 Yunsheng Lin wrote: > > Is this test actually meaningfully testing page_frag or rather > > the objpool construct and the scheduler? :S > > For the objpool part, I guess it is ok to say that it is a > meaningfully testing for both page_frag and objpool if there is > changing to either of them. Why guess when you can measure it. Slow one down and see if it impacts the benchmark. > For the scheduler part, this test provides the below module param > to avoid the the noise from scheduler. > > +static int test_push_cpu; > +module_param(test_push_cpu, int, 0600); > +MODULE_PARM_DESC(test_push_cpu, "test cpu for pushing fragment"); > + > +static int test_pop_cpu; > +module_param(test_pop_cpu, int, 0600); > +MODULE_PARM_DESC(test_pop_cpu, "test cpu for popping fragment"); > > Or is there any better idea for testing page_frag?