From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60402C27C43 for ; Wed, 29 May 2024 15:21:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C79226B009A; Wed, 29 May 2024 11:21:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C29876B009C; Wed, 29 May 2024 11:21:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF0796B009D; Wed, 29 May 2024 11:21:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 912B86B009A for ; Wed, 29 May 2024 11:21:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1F3AB160B03 for ; Wed, 29 May 2024 15:21:35 +0000 (UTC) X-FDA: 82171797750.12.89B4E90 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 6098D10002A for ; Wed, 29 May 2024 15:21:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FgNgboAs; spf=pass (imf05.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716996093; a=rsa-sha256; cv=none; b=tgkjS5SaUq1PyhlUCy9X28xz7hRY8rz9s3T9wtnNndZcR+EIHucRLDxKhulq61n8SJVXdK mbBTNY+8upNoO3bgtkPxgj87hxd6/1QGQRSQ5eF3+e6TmpDdrcQq8YpKO6yFdYr80bfB88 WypfKTjdq50CJjHa6d7KytuY8S4SIvo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FgNgboAs; spf=pass (imf05.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716996093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VNxcZgFfcodyps6/cP1ELd7JgcGrGVKAVdw/HXZfhHg=; b=elS8srFbQ9DsLkuXD/jQiJk49mGxiB/F6S/epwLMXhqTIHjPTPuTer8Pp90Ai2UnM2MOTF 58bBiTKNMgAcpuyDKfgqc9At+z2yY/HKn7K1zV0uwHnb++7WCZz3HXrPSOhCwdUeIolcF3 JxyibaQhxb8l50rBJ4l6bmD1qY/hK/Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B7B5E61204; Wed, 29 May 2024 15:21:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1F55C113CC; Wed, 29 May 2024 15:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716996090; bh=TvcuEg9n5sSq+m+PI5BmZfgamlWMCayUM1VGOKQGHuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FgNgboAspZjEFliAH6Vtbh1m/WDWqbpBZrRCT0Wkv88OVnS57/o/x/+XOTXjvXTs+ eE01gsFT84ZHNM8qt11w7G0e6Mm9ilCA7KS40Pg9+w9ksCcazgfZ0VGh3zo9sLP+L4 K/LiuIjGXpf26zis349iv2FfyF7Fk/uw326MFqMbE8JeRBf05RGdsWM4n9DEZppwoS kCAqnVeFzPpS/oUVt9hHXValY3EfL4oO0NZFRxLq0LOKA8C3YV3JHxGiCQgN/wg4MM EyYgYEc9K9aXus0RIr/brTZrMo1LoivrFFUPTYSvsu0ui2vfq6C8KukR1Picns1Pru ZoW8aUsDTanWw== Date: Wed, 29 May 2024 16:21:23 +0100 From: Will Deacon To: Mark Rutland Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Ryan Roberts , David Hildenbrand , Jeff Xie , Kefeng Wang , Michal Hocko , Minchan Kim , Muchun Song , Peter Xu , Yang Shi , Yin Fengwei , Zach O'Keefe , Catalin Marinas Subject: Re: [PATCH] mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty_ptes Message-ID: <20240529152123.GA13782@willie-the-truck> References: <20240524005444.135417-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 6098D10002A X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: rorfcx9a96n38bbo5iisecmwii1xpgui X-HE-Tag: 1716996093-815727 X-HE-Meta: U2FsdGVkX18dc5J2HpqGeASntcNmNwo11E5d4XGuCQkMS3zAz0C1NfLuNhmPkUgIYS3ibYJrNTM8Wt66IHfkGsnnYQ2HnmI9GfPfTgB47cVhGWdcOT/XUa5Ha00Ma/VB+ZSxx11i81ez/veegU1YSmXXx4HZRTHrzE/4XWI7XTaa0L8zb7tTTUhF2AtV2eBHuP0w+54CpJW5wXjhMR7PMeu4b1/BFXHGRikUtgYUURJytDMslJozey0p17cdLqulSZhFes91IcL/NIbCbRyF2EzxEE+usZ97/W1nrKDJxdDVRMCew875su8Jwoa7d6rw12qS916xIK6+IFvEIgi4Bf9k209SA+Rblf0p8R0rYHUfCb/44ngDpJaIl5xAsC3Nd0Eb7kq6sMvw4OXYSvd48AWVY//QzNbo83UAzzTKzIz00RJaz2Efkuida7a1WF5/uvN0gomoFqveq6j8MROLL0FKT+hP5RkF5yYSi3wI+aB52haGzry0vifazAdac6XyBQ6UOwLxem25T2JXYy63x9uKnAxFUeVD32t9V1GiJ8AOzIkKy7rtDazvwgIuC6njIZfR3gVctR3aYjSovU4o5otT29py5TdBTo7mKlBYOKE7/WiYhOxQ+oXPUf41szutbxlmRZcZikeiong6H6hZzCn1G8Wys10aUb09GOoB/cmPFvfzhLt0LqrGks6OeytcqNH18UhbEukM9To9fn/2fzCoGAXkXOzcnMtTjRwwlZ1eHdhjgYsxac53RBCwknYvvto9yzY2eXfOWKIElxGCod/gDbckiK9ECEPO9remooZzjYD+m68crKndWEifWEtO4voayo+YOKsxGotLSBejRA2DqRfx0l9jED/7ywQ1I3zQ3FyXZPxBBQLOZyP9PPby5ENgRgqilmtKd3E3BtXGzXgpyvzZLLmuaXKRNdXKgoo2P3qF7ngbGiqiiDdD68O2gH1tailuTJsdRuMYBml wZNdVEfQ b21Qui0xiA5EXx5K1DnaXMViKKCTU/P8xx2O4P6Z45EFK16bcRMWkPmkArVQrBIVEtOpkUG2wb345a1gTOYDtt+dk55adSTV9yVK43HmvXevCsmdqoYrfxHoNup4n56kWWIZwQJnqZ+wS1ChlROUM54bNWFlNemanD4gzED9h+skAaDXKVhN7vhD/AtTaDAwd6yVnm1wu8+qvwJT/tVCF7XUbyw8fz1lAYl6walrG7aw30V1R/cejkdFMVVDBhxdldV2/uklsHkwyNaXwtxxERRGnBeYH3j60c0/7Wj1Vma7ne3vaSqC5RVEBV29+BwicRrVqvS977vfxxZdaMQMrqPZL0maLijlWKi8SP70631lK9H7qKn+vY0Azet2e/jHiJfJM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 03:59:13PM +0100, Mark Rutland wrote: > On Tue, May 28, 2024 at 08:39:55PM +1200, Barry Song wrote: > > On Tue, May 28, 2024 at 8:26 PM Mark Rutland wrote: > > > On Fri, May 24, 2024 at 12:54:44PM +1200, Barry Song wrote: > > > > From: Barry Song > > > > > > > > We are passing a huge nr to __clear_young_dirty_ptes() right > > > > now. While we should pass the number of pages, we are actually > > > > passing CONT_PTE_SIZE. This is causing lots of crashes of > > > > MADV_FREE, panic oops could vary everytime. > > > > > > > > Fixes: 89e86854fb0a ("mm/arm64: override clear_young_dirty_ptes() batch helper") > > > > > > I was seeing ths same thing on v6.10-rc1 (syzkaller splat and reproducer > > > included at the end of the mail). The patch makes sense to me, and fixed the > > > splat in testing, so: > > > > > > Reviewed-by: Mark Rutland > > > Tested-by: Mark Rutland > > > > Thanks! > > > > > Since this only affects arm64 and is already in mainline, I assume the fix > > > should go via the arm64 tree even though the broken commit went via mm. > > > > Either mm or arm64 is fine with me, but I noticed that Andrew has already > > included it in mm-hotfixes-unstable. If it works, we may want to stick with > > that. :-) > > Going via mm is also fine by me, I had just expected it'd be quicker to > go via arm64 (and evidently I was wrong there!). :) Sorry, I was fishing! I'm happy for it to land via -mm. Will