From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Cc: Tony Luck <tony.luck@intel.com>,
Miaohe Lin <linmiaohe@huawei.com>, <nao.horiguchi@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Benjamin LaHaise <bcrl@kvack.org>, <jglisse@redhat.com>,
Zi Yan <ziy@nvidia.com>, Jiaqi Yan <jiaqiyan@google.com>,
Hugh Dickins <hughd@google.com>,
Vishal Moola <vishal.moola@gmail.com>,
Alistair Popple <apopple@nvidia.com>,
Jane Chu <jane.chu@oracle.com>,
Oscar Salvador <osalvador@suse.de>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v3 4/5] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio()
Date: Tue, 28 May 2024 21:45:12 +0800 [thread overview]
Message-ID: <20240528134513.2283548-5-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20240528134513.2283548-1-wangkefeng.wang@huawei.com>
This is similar to __migrate_folio(), use folio_mc_copy() in HugeTLB
folio migration to avoid panic when copy from poisoned folio.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
fs/hugetlbfs/inode.c | 2 +-
mm/migrate.c | 13 ++++++++-----
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 6df794ed4066..1107e5aa8343 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1128,7 +1128,7 @@ static int hugetlbfs_migrate_folio(struct address_space *mapping,
hugetlb_set_folio_subpool(src, NULL);
}
- folio_migrate_copy(dst, src);
+ folio_migrate_flags(dst, src);
return MIGRATEPAGE_SUCCESS;
}
diff --git a/mm/migrate.c b/mm/migrate.c
index e8acc6c38574..78cfad677789 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -532,15 +532,18 @@ int migrate_huge_page_move_mapping(struct address_space *mapping,
struct folio *dst, struct folio *src)
{
XA_STATE(xas, &mapping->i_pages, folio_index(src));
- int expected_count;
+ int expected_count = folio_expected_refs(mapping, src);
- xas_lock_irq(&xas);
- expected_count = folio_expected_refs(mapping, src);
- if (!folio_ref_freeze(src, expected_count)) {
- xas_unlock_irq(&xas);
+ if (!folio_ref_freeze(src, expected_count))
return -EAGAIN;
+
+ if (unlikely(folio_mc_copy(dst, src))) {
+ folio_ref_unfreeze(src, expected_count);
+ return -EFAULT;
}
+ xas_lock_irq(&xas);
+
dst->index = src->index;
dst->mapping = src->mapping;
--
2.27.0
next prev parent reply other threads:[~2024-05-28 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 13:45 [PATCH v3 0/5] mm: migrate: support poison recover from migrate folio Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 1/5] mm: add folio_mc_copy() Kefeng Wang
2024-05-28 14:17 ` Lance Yang
2024-05-29 2:16 ` Kefeng Wang
2024-05-28 20:13 ` Jane Chu
2024-05-29 2:16 ` Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 2/5] mm: migrate: split folio_migrate_mapping() Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 3/5] mm: migrate: support poisoned recover from migrate folio Kefeng Wang
2024-05-28 20:15 ` Jane Chu
2024-05-29 2:19 ` Kefeng Wang
2024-05-28 13:45 ` Kefeng Wang [this message]
2024-05-28 15:41 ` [PATCH v3 4/5] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() Luck, Tony
2024-05-28 20:19 ` Jane Chu
2024-05-28 20:30 ` Luck, Tony
2024-05-28 22:02 ` Jane Chu
2024-05-28 22:10 ` Luck, Tony
2024-05-29 2:48 ` Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 5/5] mm: migrate: remove folio_migrate_copy() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528134513.2283548-5-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bcrl@kvack.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jane.chu@oracle.com \
--cc=jglisse@redhat.com \
--cc=jiaqiyan@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox